Re: [Buildroot] [RFC PATCH v2] package/uacme: requires TLS support in libcurl

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Baruch, All,

On 2022-07-17 12:09 +0300, Baruch Siach spake thusly:
> On Sun, Jul 17 2022, Yann E. MORIN wrote:
> > On 2022-07-14 08:49 +0300, Baruch Siach via buildroot spake thusly:
> >> uacme configure script fails when libcurl does not support TLS. This
> >> means that BR2_PACKAGE_LIBCURL_TLS_NONE is incompatible with uacme. But
> >> there is no way to change the choice to something other than
> >> BR2_PACKAGE_LIBCURL_TLS_NONE. So instead make uacme depend on libcurl
> >> and !BR2_PACKAGE_LIBCURL_TLS_NONE.
> >> 
> >> As a result we can no longer select BR2_PACKAGE_OPENSSL since it causes
> >> recursive dependency. Use 'depend on' instead, and add a comment to
> >> explain this uncommon choice.
[--SNIP--]
> >> --- a/package/uacme/Config.in
> >> +++ b/package/uacme/Config.in
> >> @@ -1,8 +1,9 @@
> >>  config BR2_PACKAGE_UACME
> >>  	bool "uacme"
> >>  	depends on BR2_USE_MMU # fork()
> >> -	select BR2_PACKAGE_OPENSSL if !(BR2_PACKAGE_GNUTLS || BR2_PACKAGE_MBEDTLS)
> >> -	select BR2_PACKAGE_LIBCURL
> >> +	# We can not use select here as it causes recursive dependency
> >> +	depends on BR2_PACKAGE_OPENSSL || BR2_PACKAGE_GNUTLS || BR2_PACKAGE_MBEDTLS
> >> +	depends on BR2_PACKAGE_LIBCURL && !BR2_PACKAGE_LIBCURL_TLS_NONE
> > I don't think this is correct. Indeed, even with one of those packages
> > enabled, there is nothing that prevents libcurl to be linked with
> > another TLS provider, as that is decided with the choice entries, not
> > with the packages being enabled.
> > Instead, what about:
> >     depends on BR2_PACKAGE_LIBCURL_OPENSSL \
> >             || BR2_PACKAGE_LIBCURL_GNUTLS \
> >             || BR2_PACKAGE_LIBCURL_MBEDTLS
> > That way, it encodes both the fact that libcurl is enabled, *and* that
> > is has the proper TLS support enabled.
> As Nicola explained on v1, uacme does not care which crypto back end
> libcurl uses, as long as there is one.
>   https://lore.kernel.org/all/Ys5vPCrxDXWvj+ok@einstein.dilieto.eu/
> Regardless of that, uacme requires one of these crypt back ends for its
> own use. So I think these dependencies are correct.

Doh... I somehow got it backwards...

Then you want to also hide away the first comment behind "depends on
BR2_USE_MMU" too.

[--SNIP--]
> > Also, comments about packages being not available should go either
> > before the main symbol, or after the conditional options. Otherwise, the
> > sub-options are not indented below the main symbol. With your code:
> >     [*] uacme
> >     [ ] enable ualpn
> > while we want:
> >     [*] uacme
> >     [ ]   enable ualpn
> > I'd have fixed that when applying, but I prefer to get some feedback
> > about my proposal on the dependendcy condition.
> I'll fix that if I send another iteration.

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot