All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Alexandre Esse <alexandre.esse.dev@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/kvazaar: add cryptopp support
Date: Sun, 17 Jul 2022 23:24:31 +0200	[thread overview]
Message-ID: <20220717212431.GA2249625@scaer> (raw)
In-Reply-To: <20220710212822.876720-2-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2022-07-10 23:28 +0200, Fabrice Fontaine spake thusly:
> host-pkgconf is only needed to find cryptopp

... yet the configure always test for a pkg-config that is the correct
version, even if not needed, so I restored it as an unconditional
dependency (and it is a very fast-to-build one, so who cares).

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/kvazaar/kvazaar.mk | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/package/kvazaar/kvazaar.mk b/package/kvazaar/kvazaar.mk
> index e2ab132203..9354f7ab5f 100644
> --- a/package/kvazaar/kvazaar.mk
> +++ b/package/kvazaar/kvazaar.mk
> @@ -10,7 +10,12 @@ KVAZAAR_SITE = https://github.com/ultravideo/kvazaar/releases/download/v$(KVAZAA
>  KVAZAAR_LICENSE = BSD-3-Clause, ISC (greatest, x264asm)
>  KVAZAAR_LICENSE_FILES = LICENSE LICENSE.greatest LICENSE.x264asm
>  KVAZAAR_INSTALL_STAGING = YES
> -KVAZAAR_DEPENDENCIES = host-pkgconf
> +
> +ifeq ($(BR2_PACKAGE_CRYPTOPP),y)
> +KVAZAAR_DEPENDENCIES = host-pkgconf cryptopp
> +KVAZAAR_CONF_OPTS = --with-cryptopp
> +else
>  KVAZAAR_CONF_OPTS = --without-cryptopp

    $ make check-package
    WARNING: package/kvazaar/kvazaar.mk:17: conditional override of variable KVAZAAR_CONF_OPTS
    WARNING: package/kvazaar/kvazaar.mk:19: conditional override of variable KVAZAAR_CONF_OPTS

Fixed, and applied to master, thanks.

Regards,
Yann E. MORIN.

> +endif
>  
>  $(eval $(autotools-package))
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-07-17 21:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-10 21:28 [Buildroot] [PATCH 1/2] package/kvazaar: bump to version 2.1.0 Fabrice Fontaine
2022-07-10 21:28 ` [Buildroot] [PATCH 2/2] package/kvazaar: add cryptopp support Fabrice Fontaine
2022-07-17 21:24   ` Yann E. MORIN [this message]
2022-07-17 21:22 ` [Buildroot] [PATCH 1/2] package/kvazaar: bump to version 2.1.0 Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220717212431.GA2249625@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=alexandre.esse.dev@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.