From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org, jgg@nvidia.com, glider@google.com,
elver@google.com, dvyukov@google.com, linus.walleij@linaro.org,
akpm@linux-foundation.org
Subject: [merged mm-stable] mm-highmem-pass-a-pointer-to-virt_to_page.patch removed from -mm tree
Date: Sun, 17 Jul 2022 17:17:23 -0700 [thread overview]
Message-ID: <20220718001724.7730EC341C0@smtp.kernel.org> (raw)
The quilt patch titled
Subject: mm/highmem: pass a pointer to virt_to_page()
has been removed from the -mm tree. Its filename was
mm-highmem-pass-a-pointer-to-virt_to_page.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Linus Walleij <linus.walleij@linaro.org>
Subject: mm/highmem: pass a pointer to virt_to_page()
Date: Thu, 30 Jun 2022 10:41:21 +0200
Functions that work on a pointer to virtual memory such as virt_to_pfn()
and users of that function such as virt_to_page() are supposed to pass a
pointer to virtual memory, ideally a (void *) or other pointer. However
since many architectures implement virt_to_pfn() as a macro, this function
becomes polymorphic and accepts both a (unsigned long) and a (void *).
If we instead implement a proper virt_to_pfn(void *addr) function the
following happens (occurred on arch/arm):
mm/highmem.c:153:29: warning: passing argument 1 of
'virt_to_pfn' makes pointer from integer without a
cast [-Wint-conversion]
We already have a proper void * pointer in the scope of this function
named "vaddr" so pass that instead.
Link: https://lkml.kernel.org/r/20220630084124.691207-3-linus.walleij@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Marco Elver <elver@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/highmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/highmem.c~mm-highmem-pass-a-pointer-to-virt_to_page
+++ a/mm/highmem.c
@@ -150,7 +150,7 @@ struct page *__kmap_to_page(void *vaddr)
return pte_page(pkmap_page_table[i]);
}
- return virt_to_page(addr);
+ return virt_to_page(vaddr);
}
EXPORT_SYMBOL(__kmap_to_page);
_
Patches currently in -mm which might be from linus.walleij@linaro.org are
reply other threads:[~2022-07-18 0:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718001724.7730EC341C0@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=jgg@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.