From: "Łukasz Spintzyk" <lukasz.spintzyk@synaptics.com>
To: netdev@vger.kernel.org
Cc: linux-usb@vger.kernel.org, oliver@neukum.org, kuba@kernel.org,
ppd-posix@synaptics.com, Bernice.Chen@synaptics.com
Subject: [PATCH v3 1/2] net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices
Date: Mon, 18 Jul 2022 14:36:17 +0200 [thread overview]
Message-ID: <20220718123618.7410-1-lukasz.spintzyk@synaptics.com> (raw)
In-Reply-To: <YtAJ2KleMpkeFfQq@kroah.com>
From: Dominik Czerwik <dominik.czerwik@synaptics.com>
This improves performance and stability of
DL-3xxx/DL-5xxx/DL-6xxx device series.
Specifically prevents device from temporary network dropouts when
playing video from the web and network traffic going through is high.
Signed-off-by: Dominik Czerwik <dominik.czerwik@synaptics.com>
Signed-off-by: Łukasz Spintzyk <lukasz.spintzyk@synaptics.com>
---
v3: We have decided to remove that copyright as this is not really
necessary.
This is v3 revision of the patch series.
Please forgive me it is wrongly resubmitted with git-send-mail.
drivers/net/usb/cdc_ncm.c ssary +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index d55f59ce4a31..af84ac0d65c9 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1904,6 +1904,19 @@ static const struct driver_info cdc_ncm_info = {
.set_rx_mode = usbnet_cdc_update_filter,
};
+/* Same as cdc_ncm_info, but with FLAG_SEND_ZLP */
+static const struct driver_info cdc_ncm_zlp_info = {
+ .description = "CDC NCM (SEND ZLP)",
+ .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET
+ | FLAG_LINK_INTR | FLAG_ETHER | FLAG_SEND_ZLP,
+ .bind = cdc_ncm_bind,
+ .unbind = cdc_ncm_unbind,
+ .manage_power = usbnet_manage_power,
+ .status = cdc_ncm_status,
+ .rx_fixup = cdc_ncm_rx_fixup,
+ .tx_fixup = cdc_ncm_tx_fixup,
+};
+
/* Same as cdc_ncm_info, but with FLAG_WWAN */
static const struct driver_info wwan_info = {
.description = "Mobile Broadband Network Device",
@@ -2010,6 +2023,16 @@ static const struct usb_device_id cdc_devs[] = {
.driver_info = (unsigned long)&wwan_info,
},
+ /* DisplayLink docking stations */
+ { .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
+ | USB_DEVICE_ID_MATCH_VENDOR,
+ .idVendor = 0x17e9,
+ .bInterfaceClass = USB_CLASS_COMM,
+ .bInterfaceSubClass = USB_CDC_SUBCLASS_NCM,
+ .bInterfaceProtocol = USB_CDC_PROTO_NONE,
+ .driver_info = (unsigned long)&cdc_ncm_zlp_info,
+ },
+
/* Generic CDC-NCM devices */
{ USB_INTERFACE_INFO(USB_CLASS_COMM,
USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),
--
2.36.1
next prev parent reply other threads:[~2022-07-18 12:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 12:02 [PATCH v2 1/2] net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices Łukasz Spintzyk
2022-07-14 12:02 ` [PATCH v2 2/2] net/cdc_ncm: Increase NTB max RX/TX values to 64kb Łukasz Spintzyk
2022-07-14 12:20 ` Greg KH
2022-07-14 12:19 ` [PATCH v2 1/2] net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices Greg KH
2022-07-18 12:36 ` Łukasz Spintzyk [this message]
2022-07-18 12:36 ` [PATCH v3 2/2] net/cdc_ncm: Increase NTB max RX/TX values to 64kb Łukasz Spintzyk
2022-07-18 14:40 ` Greg KH
2022-07-19 6:24 ` [PATCH v4 1/2] net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices Łukasz Spintzyk
2022-07-19 6:24 ` [PATCH v4 2/2] net/cdc_ncm: Increase NTB max RX/TX values to 64kb Łukasz Spintzyk
2022-07-19 11:36 ` Greg KH
2022-07-19 11:36 ` [PATCH v4 1/2] net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices Greg KH
2022-07-18 14:40 ` [PATCH v3 " Greg KH
2022-07-19 8:45 ` [PATCH v2 " Oliver Neukum
2022-07-20 6:05 ` [PATCH v5 " Łukasz Spintzyk
2022-07-20 6:05 ` [PATCH v5 2/2] net/cdc_ncm: Increase NTB max RX/TX values to 64kb Łukasz Spintzyk
2022-07-21 13:50 ` [PATCH v5 1/2] net/cdc_ncm: Enable ZLP for DisplayLink ethernet devices patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718123618.7410-1-lukasz.spintzyk@synaptics.com \
--to=lukasz.spintzyk@synaptics.com \
--cc=Bernice.Chen@synaptics.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=ppd-posix@synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.