From: Jakub Kicinski <kuba@kernel.org>
To: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
oneukum@suse.com, grundler@chromium.org, pabeni@redhat.com,
edumazet@google.com, davem@davemloft.net
Subject: Re: [PATCH] sr9700: improve packet length sanity check
Date: Mon, 18 Jul 2022 20:07:13 -0700 [thread overview]
Message-ID: <20220718200713.16de615e@kernel.org> (raw)
In-Reply-To: <20220714132134.426621-1-cascardo@canonical.com>
On Thu, 14 Jul 2022 10:21:34 -0300 Thadeu Lima de Souza Cascardo wrote:
> The packet format includes a 3 byte headers and a 4 byte CRC. Account for
> that when checking the given length is not larger than the skb length.
Please describe in detail the issue you're fixing. What will happen if
we don't include SR_RX_OVERHEAD in the check.
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> Fixes: e9da0b56fe27 ("sr9700: sanity check for packet length")
prev parent reply other threads:[~2022-07-19 3:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 13:21 [PATCH] sr9700: improve packet length sanity check Thadeu Lima de Souza Cascardo
2022-07-19 3:07 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718200713.16de615e@kernel.org \
--to=kuba@kernel.org \
--cc=cascardo@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grundler@chromium.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.