From: Jakub Kicinski <kuba@kernel.org>
To: Vikas Gupta <vikas.gupta@broadcom.com>
Cc: jiri@nvidia.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
dsahern@kernel.org, stephen@networkplumber.org,
edumazet@google.com, pabeni@redhat.com, ast@kernel.org,
leon@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net,
michael.chan@broadcom.com, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH net-next v3 1/3] devlink: introduce framework for selftests
Date: Mon, 18 Jul 2022 20:33:46 -0700 [thread overview]
Message-ID: <20220718203346.6aab5c4e@kernel.org> (raw)
In-Reply-To: <20220718062032.22426-2-vikas.gupta@broadcom.com>
On Mon, 18 Jul 2022 11:50:30 +0530 Vikas Gupta wrote:
> + for (i = 1; i < DEVLINK_SELFTEST_ATTR_MAX + 1; i++) {
> + u8 res;
> +
> + if (nla_get_flag(tb[i])) {
> + res = devlink->ops->selftest_run(devlink, i,
Shouldn't we selftest_check() first to make sure the driver supports
given test?
> + [DEVLINK_ATTR_SELFTESTS_INFO] = { .type = NLA_NESTED },
... = NLA_POLICY_NESTED(devlink_selftest_nl_policy),
next prev parent reply other threads:[~2022-07-19 3:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0220707182950.29348-1-vikas.gupta@broadcom.com>
2022-07-18 6:20 ` [PATCH net-next v3 0/3] add framework for selftests in devlink Vikas Gupta
2022-07-18 6:20 ` [PATCH net-next v3 1/3] devlink: introduce framework for selftests Vikas Gupta
2022-07-19 3:33 ` Jakub Kicinski [this message]
2022-07-19 10:18 ` Vikas Gupta
2022-07-18 6:20 ` [PATCH net-next v3 2/3] bnxt_en: refactor NVM APIs Vikas Gupta
2022-07-18 6:20 ` [PATCH net-next v3 3/3] bnxt_en: implement callbacks for devlink selftests Vikas Gupta
2022-07-21 7:21 ` [PATCH net-next v4 0/3] add framework for selftests in devlink Vikas Gupta
2022-07-21 7:21 ` [PATCH net-next v4 1/3] devlink: introduce framework for selftests Vikas Gupta
2022-07-21 12:56 ` Jiri Pirko
2022-07-21 17:32 ` Vikas Gupta
2022-07-22 6:41 ` Jiri Pirko
2022-07-21 13:01 ` Jiri Pirko
2022-07-21 7:21 ` [PATCH net-next v4 2/3] bnxt_en: refactor NVM APIs Vikas Gupta
2022-07-21 13:02 ` Jiri Pirko
2022-07-21 14:24 ` Vikas Gupta
2022-07-21 7:21 ` [PATCH net-next v4 3/3] bnxt_en: implement callbacks for devlink selftests Vikas Gupta
2022-07-21 12:59 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718203346.6aab5c4e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=ast@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
--cc=vikas.gupta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.