From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Gautam Dawar <gdawar@xilinx.com>,
Liuxiangdong <liuxiangdong5@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Parav Pandit <parav@mellanox.com>, Eric Blake <eblake@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
Eli Cohen <eli@mellanox.com>, Cindy Lu <lulu@redhat.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Harpreet Singh Anand <hanand@xilinx.com>
Subject: [PATCH v5 09/20] vhost: Add SVQDescState
Date: Tue, 19 Jul 2022 11:56:18 +0200 [thread overview]
Message-ID: <20220719095629.3031338-10-eperezma@redhat.com> (raw)
In-Reply-To: <20220719095629.3031338-1-eperezma@redhat.com>
This will allow SVQ to add context to the different queue elements.
This patch only store the actual element, no functional change intended.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-shadow-virtqueue.h | 8 ++++++--
hw/virtio/vhost-shadow-virtqueue.c | 16 ++++++++--------
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/hw/virtio/vhost-shadow-virtqueue.h b/hw/virtio/vhost-shadow-virtqueue.h
index c132c994e9..d646c35054 100644
--- a/hw/virtio/vhost-shadow-virtqueue.h
+++ b/hw/virtio/vhost-shadow-virtqueue.h
@@ -15,6 +15,10 @@
#include "standard-headers/linux/vhost_types.h"
#include "hw/virtio/vhost-iova-tree.h"
+typedef struct SVQDescState {
+ VirtQueueElement *elem;
+} SVQDescState;
+
/* Shadow virtqueue to relay notifications */
typedef struct VhostShadowVirtqueue {
/* Shadow vring */
@@ -47,8 +51,8 @@ typedef struct VhostShadowVirtqueue {
/* IOVA mapping */
VhostIOVATree *iova_tree;
- /* Map for use the guest's descriptors */
- VirtQueueElement **ring_id_maps;
+ /* SVQ vring descriptors state */
+ SVQDescState *desc_state;
/* Next VirtQueue element that guest made available */
VirtQueueElement *next_guest_avail_elem;
diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c
index e3afa2ba44..e4c09e2d88 100644
--- a/hw/virtio/vhost-shadow-virtqueue.c
+++ b/hw/virtio/vhost-shadow-virtqueue.c
@@ -256,7 +256,7 @@ static int vhost_svq_add(VhostShadowVirtqueue *svq, const struct iovec *out_sg,
return -EINVAL;
}
- svq->ring_id_maps[qemu_head] = elem;
+ svq->desc_state[qemu_head].elem = elem;
vhost_svq_kick(svq);
return 0;
}
@@ -411,21 +411,21 @@ static VirtQueueElement *vhost_svq_get_buf(VhostShadowVirtqueue *svq,
return NULL;
}
- if (unlikely(!svq->ring_id_maps[used_elem.id])) {
+ if (unlikely(!svq->desc_state[used_elem.id].elem)) {
qemu_log_mask(LOG_GUEST_ERROR,
"Device %s says index %u is used, but it was not available",
svq->vdev->name, used_elem.id);
return NULL;
}
- num = svq->ring_id_maps[used_elem.id]->in_num +
- svq->ring_id_maps[used_elem.id]->out_num;
+ num = svq->desc_state[used_elem.id].elem->in_num +
+ svq->desc_state[used_elem.id].elem->out_num;
last_used_chain = vhost_svq_last_desc_of_chain(svq, num, used_elem.id);
svq->desc_next[last_used_chain] = svq->free_head;
svq->free_head = used_elem.id;
*len = used_elem.len;
- return g_steal_pointer(&svq->ring_id_maps[used_elem.id]);
+ return g_steal_pointer(&svq->desc_state[used_elem.id].elem);
}
static void vhost_svq_flush(VhostShadowVirtqueue *svq,
@@ -595,7 +595,7 @@ void vhost_svq_start(VhostShadowVirtqueue *svq, VirtIODevice *vdev,
memset(svq->vring.desc, 0, driver_size);
svq->vring.used = qemu_memalign(qemu_real_host_page_size(), device_size);
memset(svq->vring.used, 0, device_size);
- svq->ring_id_maps = g_new0(VirtQueueElement *, svq->vring.num);
+ svq->desc_state = g_new0(SVQDescState, svq->vring.num);
svq->desc_next = g_new0(uint16_t, svq->vring.num);
for (unsigned i = 0; i < svq->vring.num - 1; i++) {
svq->desc_next[i] = cpu_to_le16(i + 1);
@@ -620,7 +620,7 @@ void vhost_svq_stop(VhostShadowVirtqueue *svq)
for (unsigned i = 0; i < svq->vring.num; ++i) {
g_autofree VirtQueueElement *elem = NULL;
- elem = g_steal_pointer(&svq->ring_id_maps[i]);
+ elem = g_steal_pointer(&svq->desc_state[i].elem);
if (elem) {
virtqueue_detach_element(svq->vq, elem, 0);
}
@@ -632,7 +632,7 @@ void vhost_svq_stop(VhostShadowVirtqueue *svq)
}
svq->vq = NULL;
g_free(svq->desc_next);
- g_free(svq->ring_id_maps);
+ g_free(svq->desc_state);
qemu_vfree(svq->vring.desc);
qemu_vfree(svq->vring.used);
}
--
2.31.1
next prev parent reply other threads:[~2022-07-19 10:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 9:56 [PATCH v5 00/20] vdpa net devices Rx filter change notification with Shadow VQ Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 01/20] vhost: move descriptor translation to vhost_svq_vring_write_descs Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 02/20] virtio-net: Expose MAC_TABLE_ENTRIES Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 03/20] virtio-net: Expose ctrl virtqueue logic Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 04/20] vdpa: Avoid compiler to squash reads to used idx Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 05/20] vhost: Reorder vhost_svq_kick Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 06/20] vhost: Move vhost_svq_kick call to vhost_svq_add Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 07/20] vhost: Check for queue full at vhost_svq_add Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 08/20] vhost: Decouple vhost_svq_add from VirtQueueElement Eugenio Pérez
2022-07-19 9:56 ` Eugenio Pérez [this message]
2022-07-19 9:56 ` [PATCH v5 10/20] vhost: Track number of descs in SVQDescState Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 11/20] vhost: add vhost_svq_push_elem Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 12/20] vhost: Expose vhost_svq_add Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 13/20] vhost: add vhost_svq_poll Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 14/20] vhost: Add svq avail_handler callback Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 15/20] vdpa: Export vhost_vdpa_dma_map and unmap calls Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 16/20] vdpa: manual forward CVQ buffers Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 17/20] vdpa: Buffer CVQ support on shadow virtqueue Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 18/20] vdpa: Extract get features part from vhost_vdpa_get_max_queue_pairs Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 19/20] vdpa: Add device migration blocker Eugenio Pérez
2022-07-19 9:56 ` [PATCH v5 20/20] vdpa: Add x-svq to NetdevVhostVDPAOptions Eugenio Pérez
2022-07-19 10:04 ` [PATCH v5 00/20] vdpa net devices Rx filter change notification with Shadow VQ Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719095629.3031338-10-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=eblake@redhat.com \
--cc=eli@mellanox.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=liuxiangdong5@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.