From: Jakub Kicinski <kuba@kernel.org>
To: justinpopo6@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, jannh@google.com,
jackychou@asix.com.tw, jesionowskigreg@gmail.com,
joalonsof@gmail.com, pabeni@redhat.com, edumazet@google.com,
davem@davemloft.net, f.fainelli@gmail.com,
justin.chen@broadcom.com
Subject: Re: [PATCH 1/5] net: usb: ax88179_178a: remove redundant init code
Date: Tue, 19 Jul 2022 13:41:55 -0700 [thread overview]
Message-ID: <20220719134155.409fe0e6@kernel.org> (raw)
In-Reply-To: <1658188689-30846-2-git-send-email-justinpopo6@gmail.com>
On Mon, 18 Jul 2022 16:58:05 -0700 justinpopo6@gmail.com wrote:
> From: Justin Chen <justinpopo6@gmail.com>
>
> Bind and reset are basically doing the same thing. Remove the duplicate
> code and have bind call into reset.
>
> Signed-off-by: Justin Chen <justinpopo6@gmail.com>
drivers/net/usb/ax88179_178a.c:1329:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable]
u8 *tmp;
^
drivers/net/usb/ax88179_178a.c:1328:7: warning: variable 'tmp16' set but not used [-Wunused-but-set-variable]
u16 *tmp16;
^
next prev parent reply other threads:[~2022-07-19 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 23:58 [PATCH 0/5] net: usb: ax88179_178a: improvements and bug fixes justinpopo6
2022-07-18 23:58 ` [PATCH 1/5] net: usb: ax88179_178a: remove redundant init code justinpopo6
2022-07-19 20:41 ` Jakub Kicinski [this message]
2022-07-18 23:58 ` [PATCH 2/5] net: usb: ax88179_178a: clean up pm calls justinpopo6
2022-07-18 23:58 ` [PATCH 3/5] net: usb: ax88179_178a: restore state on resume justinpopo6
2022-07-18 23:58 ` [PATCH 4/5] net: usb: ax88179_178a: move priv to driver_priv justinpopo6
2022-07-19 17:38 ` Jose Alonso
2022-07-18 23:58 ` [PATCH 5/5] net: usb: ax88179_178a: wol optimizations justinpopo6
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719134155.409fe0e6@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jackychou@asix.com.tw \
--cc=jannh@google.com \
--cc=jesionowskigreg@gmail.com \
--cc=joalonsof@gmail.com \
--cc=justin.chen@broadcom.com \
--cc=justinpopo6@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.