From: Jakub Kicinski <kuba@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v4 4/5] net: ethernet: stmicro: stmmac: generate stmmac dma conf before open
Date: Tue, 19 Jul 2022 18:07:05 -0700 [thread overview]
Message-ID: <20220719180705.45208cb0@kernel.org> (raw)
In-Reply-To: <20220719013219.11843-5-ansuelsmth@gmail.com>
On Tue, 19 Jul 2022 03:32:18 +0200 Christian Marangi wrote:
> Rework the driver to generate the stmmac dma_conf before stmmac_open.
> This permits a function to first check if it's possible to allocate a
> new dma_config and then pass it directly to __stmmac_open and "open" the
> interface with the new configuration.
You missed one kdoc:
> @@ -1711,9 +1744,11 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags)
> * and allocates the socket buffers. It supports the chained and ring
> * modes.
> */
> -static int __init_dma_tx_desc_rings(struct stmmac_priv *priv, u32 queue)
> +static int __init_dma_tx_desc_rings(struct stmmac_priv *priv,
> + struct stmmac_dma_conf *dma_conf,
> + u32 queue)
> {
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1750: warning: Function parameter or member 'dma_conf' not described in '__init_dma_tx_desc_rings'
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v4 4/5] net: ethernet: stmicro: stmmac: generate stmmac dma conf before open
Date: Tue, 19 Jul 2022 18:07:05 -0700 [thread overview]
Message-ID: <20220719180705.45208cb0@kernel.org> (raw)
In-Reply-To: <20220719013219.11843-5-ansuelsmth@gmail.com>
On Tue, 19 Jul 2022 03:32:18 +0200 Christian Marangi wrote:
> Rework the driver to generate the stmmac dma_conf before stmmac_open.
> This permits a function to first check if it's possible to allocate a
> new dma_config and then pass it directly to __stmmac_open and "open" the
> interface with the new configuration.
You missed one kdoc:
> @@ -1711,9 +1744,11 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags)
> * and allocates the socket buffers. It supports the chained and ring
> * modes.
> */
> -static int __init_dma_tx_desc_rings(struct stmmac_priv *priv, u32 queue)
> +static int __init_dma_tx_desc_rings(struct stmmac_priv *priv,
> + struct stmmac_dma_conf *dma_conf,
> + u32 queue)
> {
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1750: warning: Function parameter or member 'dma_conf' not described in '__init_dma_tx_desc_rings'
next prev parent reply other threads:[~2022-07-20 1:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 1:32 [net-next PATCH v4 0/5] Add MTU change with stmmac interface running Christian Marangi
2022-07-19 1:32 ` Christian Marangi
2022-07-19 1:32 ` [net-next PATCH v4 1/5] net: ethernet: stmicro: stmmac: move queue reset to dedicated functions Christian Marangi
2022-07-19 1:32 ` Christian Marangi
2022-07-19 1:32 ` [net-next PATCH v4 2/5] net: ethernet: stmicro: stmmac: first disable all queues and disconnect in release Christian Marangi
2022-07-19 1:32 ` Christian Marangi
2022-07-19 1:32 ` [net-next PATCH v4 3/5] net: ethernet: stmicro: stmmac: move dma conf to dedicated struct Christian Marangi
2022-07-19 1:32 ` Christian Marangi
2022-07-19 1:32 ` [net-next PATCH v4 4/5] net: ethernet: stmicro: stmmac: generate stmmac dma conf before open Christian Marangi
2022-07-19 1:32 ` Christian Marangi
2022-07-20 1:07 ` Jakub Kicinski [this message]
2022-07-20 1:07 ` Jakub Kicinski
2022-07-19 1:32 ` [net-next PATCH v4 5/5] net: ethernet: stmicro: stmmac: permit MTU change with interface up Christian Marangi
2022-07-19 1:32 ` Christian Marangi
2022-07-20 1:13 ` [net-next PATCH v4 0/5] Add MTU change with stmmac interface running Jakub Kicinski
2022-07-20 1:13 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719180705.45208cb0@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.