From: kernel test robot <lkp@intel.com>
To: ckkim <changkon12@gmail.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Dongjin Kim <tobetter@gmail.com>
Subject: drivers/power/reset/odroid-reboot.c:63:6: warning: no previous prototype for 'odroid_card_reset'
Date: Tue, 19 Jul 2022 20:51:04 +0800 [thread overview]
Message-ID: <202207192004.EsFWlLBl-lkp@intel.com> (raw)
tree: https://github.com/tobetter/linux odroid-5.19.y
head: 0569e1291a824471ea27c9e90132881c0232a3a0
commit: 9aa3f0db97ed4d976f3640f69d177bf27e78099d ODROID-COMMON: power:reset: Add odroid support
date: 8 days ago
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220719/202207192004.EsFWlLBl-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/tobetter/linux/commit/9aa3f0db97ed4d976f3640f69d177bf27e78099d
git remote add tobetter https://github.com/tobetter/linux
git fetch --no-tags tobetter odroid-5.19.y
git checkout 9aa3f0db97ed4d976f3640f69d177bf27e78099d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/power/reset/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/power/reset/odroid-reboot.c:63:6: warning: no previous prototype for 'odroid_card_reset' [-Wmissing-prototypes]
63 | void odroid_card_reset(void)
| ^~~~~~~~~~~~~~~~~
drivers/power/reset/odroid-reboot.c: In function 'odroid_restart_probe':
drivers/power/reset/odroid-reboot.c:141:17: error: 'arm_pm_restart' undeclared (first use in this function); did you mean 'alarm_restart'?
141 | arm_pm_restart = do_odroid_restart;
| ^~~~~~~~~~~~~~
| alarm_restart
drivers/power/reset/odroid-reboot.c:141:17: note: each undeclared identifier is reported only once for each function it appears in
vim +/odroid_card_reset +63 drivers/power/reset/odroid-reboot.c
62
> 63 void odroid_card_reset(void)
64 {
65 int ret = 0;
66
67 if ((sd_vqsw == 0) && (sd_vmmc == 0))
68 return;
69
70 if (sd_vqen == 0) {
71 gpio_free(sd_vqsw);
72 gpio_free(sd_vmmc);
73 ret = gpio_request_one(sd_vqsw,
74 GPIOF_OUT_INIT_LOW, "REBOOT");
75 CHECK_RET(ret);
76 mdelay(10);
77 ret = gpio_direction_output(sd_vqsw, 1);
78 CHECK_RET(ret);
79 ret = gpio_request_one(sd_vmmc,
80 GPIOF_OUT_INIT_LOW, "REBOOT");
81 CHECK_RET(ret);
82 mdelay(10);
83 ret = gpio_direction_output(sd_vqsw, 0);
84 CHECK_RET(ret);
85 ret = gpio_direction_output(sd_vmmc, 1);
86 CHECK_RET(ret);
87 mdelay(5);
88 gpio_free(sd_vqsw);
89 gpio_free(sd_vmmc);
90 } else {
91 gpio_free(sd_vqsw);
92 gpio_free(sd_vqen);
93 gpio_free(sd_vmmc);
94
95 ret = gpio_request_one(sd_vqsw,
96 GPIOF_OUT_INIT_LOW, "REBOOT");
97 CHECK_RET(ret);
98 ret = gpio_request_one(sd_vqen,
99 GPIOF_OUT_INIT_LOW, "REBOOT");
100 CHECK_RET(ret);
101 ret = gpio_request_one(sd_vmmc,
102 GPIOF_OUT_INIT_LOW, "REBOOT");
103 CHECK_RET(ret);
104 mdelay(100);
105 ret = gpio_direction_input(sd_vqen);
106 CHECK_RET(ret);
107 ret = gpio_direction_input(sd_vmmc);
108 CHECK_RET(ret);
109 ret = gpio_direction_input(sd_vqsw);
110 CHECK_RET(ret);
111 mdelay(5);
112 gpio_free(sd_vqen);
113 gpio_free(sd_vmmc);
114 gpio_free(sd_vqsw);
115 }
116 }
117
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-07-19 13:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207192004.EsFWlLBl-lkp@intel.com \
--to=lkp@intel.com \
--cc=changkon12@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tobetter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.