All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: marijn.suijten@somainline.org, krzysztof.kozlowski+dt@linaro.org,
	sven.schwermer@disruptive-technologies.com,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, pavel@ucw.cz,
	andy.shevchenko@gmail.com, bjorn.andersson@linaro.org,
	johan+linaro@kernel.org
Subject: Re: [PATCH v2 3/4] dt-bindings: leds: Add binding for a multicolor group of LEDs
Date: Tue, 19 Jul 2022 17:15:55 -0600	[thread overview]
Message-ID: <20220719231555.GA2005680-robh@kernel.org> (raw)
In-Reply-To: <1658265913.899205.1852593.nullmailer@robh.at.kernel.org>

On Tue, Jul 19, 2022 at 03:25:13PM -0600, Rob Herring wrote:
> On Tue, 19 Jul 2022 21:18:00 +0200, Jean-Jacques Hiblot wrote:
> > This allows to group multiple monochromatic LEDs into a multicolor
> > LED, e.g. RGB LEDs.
> > 
> > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> > ---
> >  .../bindings/leds/leds-group-multicolor.yaml  | 61 +++++++++++++++++++
> >  1 file changed, 61 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-group-multicolor.example.dtb: multi-led: Unevaluated properties are not allowed ('color', 'function' were unexpected)
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml

Looks like this is fixed by commit de40c8496ead ("dt-bindings: leds: 
class-multicolor: reference class directly in multi-led node") in next.

Rob

  reply	other threads:[~2022-07-19 23:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 19:17 [PATCH v2 0/4] Add a multicolor LED driver for groups of monochromatic LEDs Jean-Jacques Hiblot
2022-07-19 19:17 ` [PATCH v2 1/4] leds: class: simplify the implementation of devm_of_led_get() Jean-Jacques Hiblot
2022-07-19 19:17 ` [PATCH v2 2/4] leds: class: store the color index in struct led_classdev Jean-Jacques Hiblot
2022-07-19 19:18 ` [PATCH v2 3/4] dt-bindings: leds: Add binding for a multicolor group of LEDs Jean-Jacques Hiblot
2022-07-19 21:25   ` Rob Herring
2022-07-19 23:15     ` Rob Herring [this message]
2022-07-19 23:16   ` Rob Herring
2022-07-19 19:18 ` [PATCH v2 4/4] leds: Add a multicolor LED driver to group monochromatic LEDs Jean-Jacques Hiblot
2022-07-20  7:28   ` Christophe JAILLET
2022-07-30 21:19   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220719231555.GA2005680-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jjhiblot@traphandler.com \
    --cc=johan+linaro@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=pavel@ucw.cz \
    --cc=sven.schwermer@disruptive-technologies.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.