From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <kuba@kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>,
<kuni1840@gmail.com>, <kuniyu@amazon.com>, <lkp@intel.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH v1 net-next] selftests: net: af_unix: Fix a build error of unix_connect.c.
Date: Tue, 19 Jul 2022 17:43:05 -0700 [thread overview]
Message-ID: <20220720004305.15822-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20220719173201.01807d65@kernel.org>
From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 19 Jul 2022 17:32:01 -0700
> On Mon, 18 Jul 2022 09:23:50 -0700 Kuniyuki Iwashima wrote:
> > This patch fixes a build error reported in the link. [0]
> >
> > unix_connect.c: In function ‘unix_connect_test’:
> > unix_connect.c:115:55: error: expected identifier before ‘(’ token
> > #define offsetof(type, member) ((size_t)&((type *)0)->(member))
> > ^
> > unix_connect.c:128:12: note: in expansion of macro ‘offsetof’
> > addrlen = offsetof(struct sockaddr_un, sun_path) + variant->len;
> > ^~~~~~~~
>
> Can we delete this define and use stddef.h instead? man offsetof
> This is not kernel code the C standard lib is at our disposal.
Ah, it works.
I'll respin v2.
Thank you!
prev parent reply other threads:[~2022-07-20 0:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 16:23 [PATCH v1 net-next] selftests: net: af_unix: Fix a build error of unix_connect.c Kuniyuki Iwashima
2022-07-20 0:32 ` Jakub Kicinski
2022-07-20 0:43 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720004305.15822-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.