From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D79B2C43334 for ; Wed, 20 Jul 2022 07:05:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 452C584072; Wed, 20 Jul 2022 09:05:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="dBsjFhKh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9CCE284072; Wed, 20 Jul 2022 09:05:14 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CAAE584053 for ; Wed, 20 Jul 2022 09:05:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 024FC61880; Wed, 20 Jul 2022 07:05:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D5E3C341C7; Wed, 20 Jul 2022 07:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658300709; bh=/nKudsgTkSPVPXjOqi9+KgaFP0560KLhXOx9P4aDab4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dBsjFhKhQ7CaSFFjyKtF6A3gmWOiCBicX4jOOuzvpoDf9tZdxwdg1yfU1Fm8STrqP h4PLtzu47w7ZC9PreVKBszIo0CSPqxPtAKe4Je6hG6KIrKAbL2tIus89dCl9lQG9d4 AjUWx/YrdCuq7J//B7C5g9YDLjzb5mIaxbfyCxfa8hkPuL8zrFLIbhospVBqiKsrfl 1Tei+xzKYfQOdWhdpA7HdrGUhZTrEdLu79dOvNv7Dal/TlOPZMSCatKKPCxW3FKsK4 jIRapzMS2P4XAeaMEwbnyu/pWNJ9MpCjvJk2O74bXPAA9hzw03BNPdhgHGsLxS2H+E Uuinhfb3H/LRw== Received: by pali.im (Postfix) id 14DC2797; Wed, 20 Jul 2022 09:05:05 +0200 (CEST) Date: Wed, 20 Jul 2022 09:05:04 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Heiko Thiery Cc: u-boot@lists.denx.de, Stefan Roese , Simon Glass , Chris Packham , Marek =?utf-8?B?QmVow7pu?= , AKASHI Takahiro , Samuel Holland Subject: Re: [PATCH 2/2] tools: kwboot: use pkg-config to get -ltinfo Message-ID: <20220720070504.elrtiddzcy7bqiv5@pali> References: <20220719183837.536343-1-heiko.thiery@gmail.com> <20220719183837.536343-2-heiko.thiery@gmail.com> <20220719192001.5ze3ux2kvwjohcaj@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wednesday 20 July 2022 08:06:28 Heiko Thiery wrote: > Hi, > > > Am Di., 19. Juli 2022 um 21:20 Uhr schrieb Pali Rohár : > > > > On Tuesday 19 July 2022 20:38:39 Heiko Thiery wrote: > > > Instead of hardcoding -ltinfo as the flags needed to build > > > kwboot, use pkg-config when available. > > > > > > We gracefully fallback on the previous behavior of hardcoding -ltinfo > > > if pkg-config is not available or fails with an error. > > > > > > Signed-off-by: Heiko Thiery > > > > So... in current form this patch is OK. > > I already sent a v2 that introduced the cflags. I will send a v3 that > removes adding this again. Ok? Ou, sorry for that :-( Anyway, details about this issue are described here: https://source.denx.de/u-boot/u-boot/-/blob/master/tools/termios_linux.h https://source.denx.de/u-boot/u-boot/-/commit/e8d26e8276358fcd1c2fe28293d3b4c82a735731 > > Reviewed-by: Pali Rohár > > > > > --- > > > tools/Makefile | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/tools/Makefile b/tools/Makefile > > > index 9f6b282ad8..45195a8ce7 100644 > > > --- a/tools/Makefile > > > +++ b/tools/Makefile > > > @@ -198,7 +198,9 @@ hostprogs-$(CONFIG_EXYNOS5420) += mkexynosspl > > > HOSTCFLAGS_mkexynosspl.o := -pedantic > > > > > > HOSTCFLAGS_kwboot.o += -pthread > > > -HOSTLDLIBS_kwboot += -pthread -ltinfo > > > +HOSTLDLIBS_kwboot += -pthread > > > +HOSTLDLIBS_kwboot += \ > > > + $(shell pkg-config --libs tinfo 2> /dev/null || echo "-ltinfo") > > > > > > ifdtool-objs := $(LIBFDT_OBJS) ifdtool.o > > > hostprogs-$(CONFIG_X86) += ifdtool > > > -- > > > 2.30.2 > > >