Re: [PATCH 3/5] nvme: refactor namespace probing

[Joel Granados <j.granados@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

On Wed, Jul 20, 2022 at 11:02:34AM +0200, Christoph Hellwig wrote:
> On Wed, Jul 20, 2022 at 10:19:12AM +0200, Joel Granados wrote:
> > > +struct nvme_ns_info {
> > > +	struct nvme_ns_ids ids;
> > > +	u32 nsid;
> > > +	__le32 anagrpid;
> > > +	bool is_shared;
> > > +	bool is_ready;
> > > +};
> > Nitpick after looking at this for the second time:
> > Should we use tabs instead of spaces to increase readability here?
> 
> Not sure why that would help.
Was unsure what the convention was, that is why I asked.

> 
> > > -	unsigned lbaf = nvme_lbaf_index(id->flbas);
> > > +	struct nvme_id_ns *id;
> > > +	unsigned lbaf;
> > Checkpatch.pl has a warning here for use of 'unsigned int' instead of
> > just 'unsigned'
> 
> checkpatch is, as so often, rather misguided here.
Don't kill the messenger ;). Should we just remove the warning?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]