From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org, penguin-kernel@i-love.sakura.ne.jp,
roman.gushchin@linux.dev, akpm@linux-foundation.org
Subject: + mm-shrinkers-fix-double-kfree-on-shrinker-name-fix.patch added to mm-unstable branch
Date: Wed, 20 Jul 2022 09:37:04 -0700 [thread overview]
Message-ID: <20220720163705.14FEBC341C7@smtp.kernel.org> (raw)
The patch titled
Subject: mm-shrinkers-fix-double-kfree-on-shrinker-name-fix
has been added to the -mm mm-unstable branch. Its filename is
mm-shrinkers-fix-double-kfree-on-shrinker-name-fix.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-shrinkers-fix-double-kfree-on-shrinker-name-fix.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Roman Gushchin <roman.gushchin@linux.dev>
Subject: mm-shrinkers-fix-double-kfree-on-shrinker-name-fix
Date: Wed, 20 Jul 2022 09:29:45 -0700
zero shrinker->name in all cases where shrinker->name is freed
Link: https://lkml.kernel.org/r/YtgteTnQTgyuKUSY@castle
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/shrinker_debug.c | 1 +
mm/vmscan.c | 5 ++++-
2 files changed, 5 insertions(+), 1 deletion(-)
--- a/mm/shrinker_debug.c~mm-shrinkers-fix-double-kfree-on-shrinker-name-fix
+++ a/mm/shrinker_debug.c
@@ -251,6 +251,7 @@ void shrinker_debugfs_remove(struct shri
lockdep_assert_held(&shrinker_rwsem);
kfree_const(shrinker->name);
+ shrinker->name = NULL;
if (!shrinker->debugfs_entry)
return;
--- a/mm/vmscan.c~mm-shrinkers-fix-double-kfree-on-shrinker-name-fix
+++ a/mm/vmscan.c
@@ -644,8 +644,10 @@ int prealloc_shrinker(struct shrinker *s
return -ENOMEM;
err = __prealloc_shrinker(shrinker);
- if (err)
+ if (err) {
kfree_const(shrinker->name);
+ shrinker->name = NULL;
+ }
return err;
}
@@ -660,6 +662,7 @@ void free_prealloced_shrinker(struct shr
{
#ifdef CONFIG_SHRINKER_DEBUG
kfree_const(shrinker->name);
+ shrinker->name = NULL;
#endif
if (shrinker->flags & SHRINKER_MEMCG_AWARE) {
down_write(&shrinker_rwsem);
_
Patches currently in -mm which might be from roman.gushchin@linux.dev are
mm-shrinkers-fix-double-kfree-on-shrinker-name-fix.patch
mm-memcontrol-do-not-miss-memcg_max-events-for-enforced-allocations.patch
reply other threads:[~2022-07-20 16:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720163705.14FEBC341C7@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.