From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6069CCA485 for ; Wed, 20 Jul 2022 17:53:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232557AbiGTRxX (ORCPT ); Wed, 20 Jul 2022 13:53:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231420AbiGTRxX (ORCPT ); Wed, 20 Jul 2022 13:53:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24AD85A46D; Wed, 20 Jul 2022 10:53:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D2FC5B82182; Wed, 20 Jul 2022 17:53:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7D84C3411E; Wed, 20 Jul 2022 17:53:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658339599; bh=x0uoeCIE00jBCB0YsHFm8nmWmRbsfgR/8F8WDW1SzJA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QIcahOnx1TtfWCEC81bY7HUrMKo8wrqvOeTbRHIpSlaDgd1g7seudbmSlILukBcvA 3s8xSQLvajbYZFtBz71kRejzIh9c4sHLUPMXC9w7WkZngHAID6pxqjYshoX8DWGSNj l8iLLGwAdD7QNcry+fBMvj/zmMqGApbLZib3MHF2+iX1iZeKkIDOsrv8XfQzWZVJRZ g/3a0eY4QQ/n9afC6ymDHHk8ht7QgsQEXwfgcUJL/dxyxEknFqCobqYl5lqaHa1L1U H+uzeAgBfYOt7RT69SlvARy+JwE2FJZM7+0+0z95SfxQ+D80vi9k/lVNU/So6RyMs/ 5WVD9V+DMJ7wg== Received: by pali.im (Postfix) id ACA5E797; Wed, 20 Jul 2022 19:53:15 +0200 (CEST) Date: Wed, 20 Jul 2022 19:53:15 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Rob Herring Cc: Arnd Bergmann , Mauri Sandberg , linux-pci , DTML , Linux Kernel Mailing List , Linux ARM , Bjorn Helgaas , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Gregory CLEMENT , Russell King - ARM Linux , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Thomas Petazzoni Subject: Re: [PATCH 2/2] PCI: mvebu: add support for orion5x Message-ID: <20220720175315.paeo7n6kx2wzcdtc@pali> References: <20220718202843.6766-1-maukka@ext.kapsi.fi> <20220718202843.6766-4-maukka@ext.kapsi.fi> <20220719094649.pzyrqdvm3fm5fqh2@pali> <20220720161315.rr4ujakl7akm7pur@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wednesday 20 July 2022 11:40:40 Rob Herring wrote: > On Wed, Jul 20, 2022 at 10:13 AM Pali Rohár wrote: > > > > On Tuesday 19 July 2022 12:16:34 Arnd Bergmann wrote: > > > On Tue, Jul 19, 2022 at 11:46 AM Pali Rohár wrote: > > > > On Tuesday 19 July 2022 10:05:28 Arnd Bergmann wrote: > > > > > > +/* Relevant only for Orion-1/Orion-NAS */ > > > > > > +#define ORION5X_PCIE_WA_PHYS_BASE 0xf0000000 > > > > > > +#define ORION5X_PCIE_WA_VIRT_BASE IOMEM(0xfd000000) > > > > > > > > > > You should not need to hardcode these here. The ORION5X_PCIE_WA_PHYS_BASE > > > > > should already be part of the DT binding. > > > > > > > > Of course! But the issue is that we do not know how to do this DT > > > > binding. I have already wrote email with asking for help in which > > > > property and which format should be this config range defined, but no > > > > answer yet: https://lore.kernel.org/linux-pci/20220710225108.bgedria6igtqpz5l@pali/ > > > > > > Ah, I had not seen that email. Quoting from there: > > > > > > > So my question is: How to properly define config space range in device > > > > tree file? In which device tree property and in which format? Please > > > > note that this memory range of config space is PCIe root port specific > > > > and it requires its own MBUS_ID() like memory range of PCIe MEM and PCIe > > > > IO mapping. Please look e.g. at armada-385.dtsi how are MBUS_ID() used: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/armada-385.dtsi > > > > > > This is probably a question for Rob as the mvebu driver is a rather special > > > case. Normally this would just be a 'reg' property of the host bridge, > > > but I think > > > in your case the root device is imaginary, and the ports under it are the > > > actual hardware devices > > > > yes > > > > > so you'll probably have to do the same thing as > > > the armada-385, translating the mbus ranges for the config space in the > > > "ranges" property of the parent > > > > Problem is that "ranges" in PCIe are used for specifying MEM and IO > > mappings and kernel PCI code does not allow any other type. > > The kernel does not, but the binding does (well, the original OF PCI > bus supplement does, but the schema currently does not). If there's a > real need to support config space in ranges, then we can relax the > constraints. > > Rob Personally, I do not care where definition of address range for config space would be defined. Just I need to know where to put it and in which format, so it would be fine for schema checkers, kernel pci core, etc... https://lore.kernel.org/linux-pci/20220710225108.bgedria6igtqpz5l@pali/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B6EAC433EF for ; Wed, 20 Jul 2022 17:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/0ucLNr3V12/lnwxPrSc/WidpzVwsuD8GOSBRATF6YM=; b=POTFXYRxRLCNYk 8dg8hvEBmZGuduhWBQqKQbky2BahyCWHMQMNsm29NxGPY9Xta9ihTPKT3APsrh/Ea91KX+NNwnx4T zXJYwGV6e0sbp+9ZunuJI9hbQAGVOtxVamCNvL939FxZDTN3iTCyimcc5lwL5p+1IFdWAXzldyu8C PXZMFwW6Fk8OWuXa+u6YIRXw25JRM36NffE8EaAeEDjbgLnh5AEugwfxcP+uPK4fll4cHu78hHOTk eIBE05c7Sjpdlkx4f63Bp3aW7eauRzMzTU4YOuQEAu3LueWlQG8L/9NHl+68nnprUTcHMR/jbVemM hQurDuBLv7b57zRaHlvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEDsx-008t5z-TS; Wed, 20 Jul 2022 17:53:24 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEDsu-008t44-Fl for linux-arm-kernel@lists.infradead.org; Wed, 20 Jul 2022 17:53:22 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E6311616CF; Wed, 20 Jul 2022 17:53:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7D84C3411E; Wed, 20 Jul 2022 17:53:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658339599; bh=x0uoeCIE00jBCB0YsHFm8nmWmRbsfgR/8F8WDW1SzJA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QIcahOnx1TtfWCEC81bY7HUrMKo8wrqvOeTbRHIpSlaDgd1g7seudbmSlILukBcvA 3s8xSQLvajbYZFtBz71kRejzIh9c4sHLUPMXC9w7WkZngHAID6pxqjYshoX8DWGSNj l8iLLGwAdD7QNcry+fBMvj/zmMqGApbLZib3MHF2+iX1iZeKkIDOsrv8XfQzWZVJRZ g/3a0eY4QQ/n9afC6ymDHHk8ht7QgsQEXwfgcUJL/dxyxEknFqCobqYl5lqaHa1L1U H+uzeAgBfYOt7RT69SlvARy+JwE2FJZM7+0+0z95SfxQ+D80vi9k/lVNU/So6RyMs/ 5WVD9V+DMJ7wg== Received: by pali.im (Postfix) id ACA5E797; Wed, 20 Jul 2022 19:53:15 +0200 (CEST) Date: Wed, 20 Jul 2022 19:53:15 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Rob Herring Cc: Arnd Bergmann , Mauri Sandberg , linux-pci , DTML , Linux Kernel Mailing List , Linux ARM , Bjorn Helgaas , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Gregory CLEMENT , Russell King - ARM Linux , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Thomas Petazzoni Subject: Re: [PATCH 2/2] PCI: mvebu: add support for orion5x Message-ID: <20220720175315.paeo7n6kx2wzcdtc@pali> References: <20220718202843.6766-1-maukka@ext.kapsi.fi> <20220718202843.6766-4-maukka@ext.kapsi.fi> <20220719094649.pzyrqdvm3fm5fqh2@pali> <20220720161315.rr4ujakl7akm7pur@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220720_105320_631537_74AFD31C X-CRM114-Status: GOOD ( 36.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkbmVzZGF5IDIwIEp1bHkgMjAyMiAxMTo0MDo0MCBSb2IgSGVycmluZyB3cm90ZToKPiBP biBXZWQsIEp1bCAyMCwgMjAyMiBhdCAxMDoxMyBBTSBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwu b3JnPiB3cm90ZToKPiA+Cj4gPiBPbiBUdWVzZGF5IDE5IEp1bHkgMjAyMiAxMjoxNjozNCBBcm5k IEJlcmdtYW5uIHdyb3RlOgo+ID4gPiBPbiBUdWUsIEp1bCAxOSwgMjAyMiBhdCAxMTo0NiBBTSBQ YWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4gPiBPbiBUdWVzZGF5IDE5 IEp1bHkgMjAyMiAxMDowNToyOCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+ID4gPiA+ID4gPiArLyog UmVsZXZhbnQgb25seSBmb3IgT3Jpb24tMS9Pcmlvbi1OQVMgKi8KPiA+ID4gPiA+ID4gKyNkZWZp bmUgT1JJT041WF9QQ0lFX1dBX1BIWVNfQkFTRSAgICAgIDB4ZjAwMDAwMDAKPiA+ID4gPiA+ID4g KyNkZWZpbmUgT1JJT041WF9QQ0lFX1dBX1ZJUlRfQkFTRSAgICAgIElPTUVNKDB4ZmQwMDAwMDAp Cj4gPiA+ID4gPgo+ID4gPiA+ID4gWW91IHNob3VsZCBub3QgbmVlZCB0byBoYXJkY29kZSB0aGVz ZSBoZXJlLiBUaGUgT1JJT041WF9QQ0lFX1dBX1BIWVNfQkFTRQo+ID4gPiA+ID4gc2hvdWxkIGFs cmVhZHkgYmUgcGFydCBvZiB0aGUgRFQgYmluZGluZy4KPiA+ID4gPgo+ID4gPiA+IE9mIGNvdXJz ZSEgQnV0IHRoZSBpc3N1ZSBpcyB0aGF0IHdlIGRvIG5vdCBrbm93IGhvdyB0byBkbyB0aGlzIERU Cj4gPiA+ID4gYmluZGluZy4gSSBoYXZlIGFscmVhZHkgd3JvdGUgZW1haWwgd2l0aCBhc2tpbmcg Zm9yIGhlbHAgaW4gd2hpY2gKPiA+ID4gPiBwcm9wZXJ0eSBhbmQgd2hpY2ggZm9ybWF0IHNob3Vs ZCBiZSB0aGlzIGNvbmZpZyByYW5nZSBkZWZpbmVkLCBidXQgbm8KPiA+ID4gPiBhbnN3ZXIgeWV0 OiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1wY2kvMjAyMjA3MTAyMjUxMDguYmdlZHJp YTZpZ3RxcHo1bEBwYWxpLwo+ID4gPgo+ID4gPiBBaCwgSSBoYWQgbm90IHNlZW4gdGhhdCBlbWFp bC4gUXVvdGluZyBmcm9tIHRoZXJlOgo+ID4gPgo+ID4gPiA+IFNvIG15IHF1ZXN0aW9uIGlzOiBI b3cgdG8gcHJvcGVybHkgZGVmaW5lIGNvbmZpZyBzcGFjZSByYW5nZSBpbiBkZXZpY2UKPiA+ID4g PiB0cmVlIGZpbGU/IEluIHdoaWNoIGRldmljZSB0cmVlIHByb3BlcnR5IGFuZCBpbiB3aGljaCBm b3JtYXQ/IFBsZWFzZQo+ID4gPiA+IG5vdGUgdGhhdCB0aGlzIG1lbW9yeSByYW5nZSBvZiBjb25m aWcgc3BhY2UgaXMgUENJZSByb290IHBvcnQgc3BlY2lmaWMKPiA+ID4gPiBhbmQgaXQgcmVxdWly ZXMgaXRzIG93biBNQlVTX0lEKCkgbGlrZSBtZW1vcnkgcmFuZ2Ugb2YgUENJZSBNRU0gYW5kIFBD SWUKPiA+ID4gPiBJTyBtYXBwaW5nLiBQbGVhc2UgbG9vayBlLmcuIGF0IGFybWFkYS0zODUuZHRz aSBob3cgYXJlIE1CVVNfSUQoKSB1c2VkOgo+ID4gPiA+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcv cHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL2FyY2gvYXJt L2Jvb3QvZHRzL2FybWFkYS0zODUuZHRzaQo+ID4gPgo+ID4gPiBUaGlzIGlzIHByb2JhYmx5IGEg cXVlc3Rpb24gZm9yIFJvYiBhcyB0aGUgbXZlYnUgZHJpdmVyIGlzIGEgcmF0aGVyIHNwZWNpYWwK PiA+ID4gY2FzZS4gTm9ybWFsbHkgdGhpcyB3b3VsZCBqdXN0IGJlIGEgJ3JlZycgcHJvcGVydHkg b2YgdGhlIGhvc3QgYnJpZGdlLAo+ID4gPiBidXQgSSB0aGluawo+ID4gPiBpbiB5b3VyIGNhc2Ug dGhlIHJvb3QgZGV2aWNlIGlzIGltYWdpbmFyeSwgYW5kIHRoZSBwb3J0cyB1bmRlciBpdCBhcmUg dGhlCj4gPiA+IGFjdHVhbCBoYXJkd2FyZSBkZXZpY2VzCj4gPgo+ID4geWVzCj4gPgo+ID4gPiBz byB5b3UnbGwgcHJvYmFibHkgaGF2ZSB0byBkbyB0aGUgc2FtZSB0aGluZyBhcwo+ID4gPiB0aGUg YXJtYWRhLTM4NSwgdHJhbnNsYXRpbmcgdGhlIG1idXMgcmFuZ2VzIGZvciB0aGUgY29uZmlnIHNw YWNlIGluIHRoZQo+ID4gPiAicmFuZ2VzIiBwcm9wZXJ0eSBvZiB0aGUgcGFyZW50Cj4gPgo+ID4g UHJvYmxlbSBpcyB0aGF0ICJyYW5nZXMiIGluIFBDSWUgYXJlIHVzZWQgZm9yIHNwZWNpZnlpbmcg TUVNIGFuZCBJTwo+ID4gbWFwcGluZ3MgYW5kIGtlcm5lbCBQQ0kgY29kZSBkb2VzIG5vdCBhbGxv dyBhbnkgb3RoZXIgdHlwZS4KPiAKPiBUaGUga2VybmVsIGRvZXMgbm90LCBidXQgdGhlIGJpbmRp bmcgZG9lcyAod2VsbCwgdGhlIG9yaWdpbmFsIE9GIFBDSQo+IGJ1cyBzdXBwbGVtZW50IGRvZXMs IGJ1dCB0aGUgc2NoZW1hIGN1cnJlbnRseSBkb2VzIG5vdCkuIElmIHRoZXJlJ3MgYQo+IHJlYWwg bmVlZCB0byBzdXBwb3J0IGNvbmZpZyBzcGFjZSBpbiByYW5nZXMsIHRoZW4gd2UgY2FuIHJlbGF4 IHRoZQo+IGNvbnN0cmFpbnRzLgo+IAo+IFJvYgoKUGVyc29uYWxseSwgSSBkbyBub3QgY2FyZSB3 aGVyZSBkZWZpbml0aW9uIG9mIGFkZHJlc3MgcmFuZ2UgZm9yIGNvbmZpZwpzcGFjZSB3b3VsZCBi ZSBkZWZpbmVkLiBKdXN0IEkgbmVlZCB0byBrbm93IHdoZXJlIHRvIHB1dCBpdCBhbmQgaW4gd2hp Y2gKZm9ybWF0LCBzbyBpdCB3b3VsZCBiZSBmaW5lIGZvciBzY2hlbWEgY2hlY2tlcnMsIGtlcm5l bCBwY2kgY29yZSwgZXRjLi4uCmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXBjaS8yMDIy MDcxMDIyNTEwOC5iZ2VkcmlhNmlndHFwejVsQHBhbGkvCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==