All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Barisani, Andrea" <andrea.barisani@withsecure.com>
Cc: Fabio Estevam <festevam@gmail.com>,
	"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/crucible: Pass 'osusergo netgo' tags
Date: Wed, 20 Jul 2022 22:24:30 +0200	[thread overview]
Message-ID: <20220720222430.7eb519f6@windsurf> (raw)
In-Reply-To: <8CF2C8F5-F7EA-43C2-80BA-1D4122D22A66@withsecure.com>

Hello,

On Wed, 20 Jul 2022 17:05:42 +0000
"Barisani, Andrea" <andrea.barisani@withsecure.com> wrote:

> These flags are not crucible specific but they are necessary when
> compiling static Go binaries with CGO enabled (which crucible does
> not require by the way) to ensure portability as cgo versions of net
> and os/users are not portable. 

Thanks for your feedback, much appreciated!

So, I see we're passing CGO_ENABLED=1 (when thread support is
available) to all packages, and you're saying that this is incorrect as
not all Go packages need CGO? Passing CGO_ENABLED=1/0 should be a
per-package decision?

However, when CGO is enabled and we need static linking, passing
osusergo and netgo tags is needed, correct?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-07-20 20:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 12:57 [Buildroot] [PATCH] package/crucible: Pass 'osusergo netgo' tags Fabio Estevam
2022-07-20 16:38 ` Thomas Petazzoni via buildroot
     [not found]   ` <8CF2C8F5-F7EA-43C2-80BA-1D4122D22A66@withsecure.com>
2022-07-20 20:24     ` Thomas Petazzoni via buildroot [this message]
2022-07-22 21:04       ` Arnout Vandecappelle
2022-07-22 21:15         ` Thomas Petazzoni via buildroot
2022-07-22 22:03           ` Arnout Vandecappelle
2022-07-23  0:41             ` Christian Stewart via buildroot
2022-07-23  8:54               ` Arnout Vandecappelle
2022-09-18 12:50                 ` Arnout Vandecappelle
2022-09-18 13:09                   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720222430.7eb519f6@windsurf \
    --to=buildroot@buildroot.org \
    --cc=andrea.barisani@withsecure.com \
    --cc=festevam@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.