All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Francois Perrad <fperrad@gmail.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 4/5] package/open62541: add encryption support
Date: Wed, 20 Jul 2022 23:01:44 +0200	[thread overview]
Message-ID: <20220720230144.4cb7f39a@windsurf> (raw)
In-Reply-To: <20220615161753.2580142-4-francois.perrad@gadz.org>

On Wed, 15 Jun 2022 18:17:52 +0200
Francois Perrad <fperrad@gmail.com> wrote:

> +config BR2_PACKAGE_OPEN62541_ENCRYPTION_MBEDTLS
> +	bool "mbedtls"
> +	select BR2_PACKAGE_MBEDTLS
> +
> +config BR2_PACKAGE_OPEN62541_ENCRYPTION_OPENSSL
> +	bool "openssl"
> +	select BR2_PACKAGE_LIBOPENSSL

This is not the correct way to force OpenSSL. Indeed you can't select
an option that is within a choice...endchoice. Instead, you need to:

        select BR2_PACKAGE_OPENSSL
        select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL

> +ifeq ($(BR2_PACKAGE_OPEN62541_ENCRYPTION_OPENSSL),y)
> +OPEN62541_DEPENDENCIES += libopenssl

and:

OPEN62541_DEPENDENCIES += openssl

so, I fixed that up. I also explained in the commit log why we are
doing this: open62541 does not build with LibreSSL.

Applied to master with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-07-20 21:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-15 16:17 [Buildroot] [PATCH 1/5] package/open62541: bump to version 1.3.1 Francois Perrad
2022-06-15 16:17 ` [Buildroot] [PATCH 2/5] package/open62541: more options Francois Perrad
2022-07-20 20:58   ` Thomas Petazzoni via buildroot
2022-06-15 16:17 ` [Buildroot] [PATCH 3/5] package/open62541: more PubSub options Francois Perrad
2022-07-20 20:59   ` Thomas Petazzoni via buildroot
2022-06-15 16:17 ` [Buildroot] [PATCH 4/5] package/open62541: add encryption support Francois Perrad
2022-07-20 21:01   ` Thomas Petazzoni via buildroot [this message]
2022-06-15 16:17 ` [Buildroot] [PATCH 5/5] package/open62541: refactor choice UA_NAMESPACE with a proper default Francois Perrad
2022-07-20 21:02   ` Thomas Petazzoni via buildroot
2022-07-20 20:58 ` [Buildroot] [PATCH 1/5] package/open62541: bump to version 1.3.1 Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720230144.4cb7f39a@windsurf \
    --to=buildroot@buildroot.org \
    --cc=buildroot@busybox.net \
    --cc=fperrad@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.