From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49EB1CCA479 for ; Thu, 21 Jul 2022 10:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=22vQdR968DkCEqoDMLbWHyND49dyKa8PH5iJuwHz/fQ=; b=tYhg6I1vKxlrGS Og0dCh4nDSqI3K8sNTlrpdQNx2E+DhBPTWC1szdCprZXq8FCQdRnS7T+q43dEmKwyJ9dNSzTY6DR4 T/cO5TfJDON/3vR1F+Usl8Yu5+4RglIe/Wz4TH8hXmfBftH9IRSGcgmnHYSRfFxbeD3wkb5r0JNQH 0GRT9KDrSSk3OA4kYNhl9k03L328wh6Z0W07SP89T7D2iyy5qwJPKGbcxv2N4fFliAQJE5wNJ5K2g /530H0VFrrlAX660MEb1icpp6Cokq2w1obi1baqIbOuCLR0JnvssFhQiSLoDAkCwxacNYAkVVBe5C /syvGCpTgPz0xqJdugLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oETHP-003nVD-4q; Thu, 21 Jul 2022 10:19:39 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oETHJ-003nRU-Ve for ath11k@lists.infradead.org; Thu, 21 Jul 2022 10:19:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99386B8239B; Thu, 21 Jul 2022 10:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7376CC3411E; Thu, 21 Jul 2022 10:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658398770; bh=uF9353hnQZd3BXE41rHODhzKSUHBPzaXqjrZu5+fQok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g5wyVh3Gn4BsqDlCw+fbSxAn78RXXIoT3k3EmqB0Q3qRZUwmQ3UxcuC/hHdKqjryt UL0Z3gxCcIXkmUt1MDIx/8wSh5BRe3U1sVMgqUoU3kk9dU5JZyxzmaiHhZOV5zqVXq VCQQPVKwcPaCvLe+g9GrpaAbZuqIwOebbv+dSZjjxDLLw4CMvvoC8rEv7kjHLkXAxa svCKnBBJDIrefopoBqpBDgBxHyCpIOSm3qOic/fwAaTJ7batwifueGm+IchNg8O24J ef957N0zqIj6XCdzvwVhwuqnowdjeKGFsjxOrarhIm38uqnun3ZcHGXXHkYY3EdZeZ ms8mPLsXjnVOQ== Date: Thu, 21 Jul 2022 15:49:14 +0530 From: Manivannan Sadhasivam To: Qiang Yu Cc: Manivannan Sadhasivam , Kalle Valo , quic_hemantk@quicinc.com, loic.poulain@linaro.org, quic_jhugo@quicinc.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, ath11k@lists.infradead.org Subject: Re: [PATCH v4 1/1] bus: mhi: host: Move IRQ allocation to controller registration phase Message-ID: <20220721101914.GC36189@thinkpad> References: <1655952183-66792-1-git-send-email-quic_qianyu@quicinc.com> <20220624072740.GA12171@thinkpad> <87k08an038.fsf@kernel.org> <20220720093909.GA5747@thinkpad> <063fe6bf-11b1-1724-058f-0fed7247906e@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <063fe6bf-11b1-1724-058f-0fed7247906e@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220721_031934_391001_2C80A434 X-CRM114-Status: GOOD ( 34.87 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMjAsIDIwMjIgYXQgMDU6NDc6MzdQTSArMDgwMCwgUWlhbmcgWXUgd3JvdGU6 Cj4gCj4gT24gNy8yMC8yMDIyIDU6MzkgUE0sIE1hbml2YW5uYW4gU2FkaGFzaXZhbSB3cm90ZToK PiA+IE9uIE1vbiwgSnVsIDE4LCAyMDIyIGF0IDAyOjE1OjIzUE0gKzAzMDAsIEthbGxlIFZhbG8g d3JvdGU6Cj4gPiA+ICsgYXRoMTFrIGxpc3QKPiA+ID4gCj4gPiA+IE1hbml2YW5uYW4gU2FkaGFz aXZhbSA8bWFuaUBrZXJuZWwub3JnPiB3cml0ZXM6Cj4gPiA+IAo+ID4gPiA+IE9uIFRodSwgSnVu IDIzLCAyMDIyIGF0IDEwOjQzOjAzQU0gKzA4MDAsIFFpYW5nIFl1IHdyb3RlOgo+ID4gPiA+ID4g RHVyaW5nIHJ1bnRpbWUsIHRoZSBNSEkgZW5kcG9pbnQgbWF5IGJlIHBvd2VyZWQgdXAvZG93biBz ZXZlcmFsIHRpbWVzLgo+ID4gPiA+ID4gU28gaW5zdGVhZCBvZiBhbGxvY2F0aW5nIGFuZCBkZXN0 cm95aW5nIHRoZSBJUlFzIGFsbCB0aGUgdGltZSwgbGV0J3MganVzdAo+ID4gPiA+ID4gZW5hYmxl L2Rpc2FibGUgSVJRcyBkdXJpbmcgcG93ZXIgdXAvZG93bi4KPiA+ID4gPiA+IAo+ID4gPiA+ID4g VGhlIElSUXMgd2lsbCBiZSBhbGxvY2F0ZWQgZHVyaW5nIG1oaV9yZWdpc3Rlcl9jb250cm9sbGVy KCkgYW5kIGZyZWVkCj4gPiA+ID4gPiBkdXJpbmcgbWhpX3VucmVnaXN0ZXJfY29udHJvbGxlcigp LiBUaGlzIHdvcmtzIHdlbGwgZm9yIHRoaW5ncyBsaWtlIFBDSQo+ID4gPiA+ID4gaG90cGx1ZyBh bHNvIGFzIG9uY2UgdGhlIFBDSSBkZXZpY2UgZ2V0cyByZW1vdmVkLCB0aGUgY29udHJvbGxlciB3 aWxsCj4gPiA+ID4gPiBnZXQgdW5yZWdpc3RlcmVkLiBBbmQgb25jZSBpdCBjb21lcyBiYWNrLCBp dCB3aWxsIGdldCByZWdpc3RlcmVkIGJhY2sKPiA+ID4gPiA+IGFuZCBldmVuIGlmIHRoZSBJUlEg Y29uZmlndXJhdGlvbiBjaGFuZ2VzIChNU0kpLCB0aGF0IHdpbGwgZ2V0IGFjY291bnRlZC4KPiA+ ID4gPiA+IAo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogUWlhbmcgWXUgPHF1aWNfcWlhbnl1QHF1 aWNpbmMuY29tPgo+ID4gPiA+IEFwcGxpZWQgdG8gbWhpLW5leHQhCj4gPiA+IEkgZGlkIGEgYmlz ZWN0IGFuZCB0aGlzIHBhdGNoIGJyZWFrcyBhdGgxMWsgZHVyaW5nIHJtbW9kLiBJJ20gb24KPiA+ ID4gdmFjYXRpb24gcmlnaHQgbm93IHNvIEkgY2FuJ3QgaW52ZXN0aWdhdGUgaW4gZGV0YWlsIGJ1 dCBtb3JlIGluZm8gYmVsb3cuCj4gPiA+IAo+ID4gSSBqdXN0IHRlc3RlZCBsaW51eC1uZXh0L21h c3RlciBuZXh0LTIwMjIwNzE4IG9uIG15IE5VQyB3aXRoIFFDQTYzOTAsIGJ1dCBJJ20KPiA+IG5v dCBhYmxlIHRvIHJlcHJvZHVjZSB0aGUgaXNzdWUgZHVyaW5nIHJtbW9kISBJbnN0ZWFkIEkgY291 bGRuJ3QgY29ubmVjdCB0byBBUC4KPiAKPiBJIHN1c3BlY3QgdGhhdCBpbiBfX2ZyZWVfaXJxKCks IGlmIENPTkZJR19ERUJVR19TSElSUSBpcyBlbmFibGVkLCBpcnEKPiBoYW5kbGVyIGZvciBhIHNo YXJlZCBJUlEgd2lsbCBiZSBpbnZva2VkIGFuZCBudWxsIHBvaW50ZXIgYWNjZXNzIGhhcHBlbi4K PiAKPiAjaWZkZWYgQ09ORklHX0RFQlVHX1NISVJRCj4gwqDCoCDCoC8qCj4gwqDCoCDCoCAqIEl0 J3MgYSBzaGFyZWQgSVJRIC0tIHRoZSBkcml2ZXIgb3VnaHQgdG8gYmUgcHJlcGFyZWQgZm9yIGFu IElSUQo+IMKgwqAgwqAgKiBldmVudCB0byBoYXBwZW4gZXZlbiBub3cgaXQncyBiZWluZyBmcmVl ZCwgc28gbGV0J3MgbWFrZSBzdXJlIHRoYXQKPiDCoMKgIMKgICogaXMgc28gYnkgZG9pbmcgYW4g ZXh0cmEgY2FsbCB0byB0aGUgaGFuZGxlciAuLi4uCj4gwqDCoCDCoCAqCj4gwqDCoCDCoCAqICgg V2UgZG8gdGhpcyBhZnRlciBhY3R1YWxseSBkZXJlZ2lzdGVyaW5nIGl0LCB0byBtYWtlIHN1cmUg dGhhdCBhCj4gwqDCoCDCoCAqwqDCoCAncmVhbCcgSVJRIGRvZXNuJ3QgcnVuIGluIHBhcmFsbGVs IHdpdGggb3VyIGZha2UuICkKPiDCoMKgIMKgICovCj4gwqDCoCDCoGlmIChhY3Rpb24tPmZsYWdz ICYgSVJRRl9TSEFSRUQpIHsKPiDCoMKgIMKgwqDCoMKgIGxvY2FsX2lycV9zYXZlKGZsYWdzKTsK PiDCoMKgIMKgwqDCoMKgIGFjdGlvbi0+aGFuZGxlcihpcnEsIGRldl9pZCk7Cj4gwqDCoCDCoMKg wqDCoCBsb2NhbF9pcnFfcmVzdG9yZShmbGFncyk7Cj4gwqDCoCDCoH0KPiAjZW5kaWYKPiAKCkFo IHllcywgYWZ0ZXIgZW5hYmxpbmcgQ09ORklHX0RFQlVHX1NISVJRIEkgY291bGQgcmVwcm9kdWNl IHRoZSBpc3N1ZS4KClRoYW5rcywKTWFuaQoKPiA+IAo+ID4gbG9nOiBodHRwczovL3Bhc3RlLmRl Ymlhbi5uZXQvMTI0Nzc4OC8KPiA+IAo+ID4gVGhhbmtzLAo+ID4gTWFuaQo+ID4gCj4gPiA+IFsg ICA2Ni45Mzk4NzhdIHJtbW9kIGF0aDExa19wY2kKPiA+ID4gWyAgIDY3LjYwNjI2OV0gZ2VuZXJh bCBwcm90ZWN0aW9uIGZhdWx0LCBwcm9iYWJseSBmb3Igbm9uLWNhbm9uaWNhbAo+ID4gPiBhZGRy ZXNzIDB4ZGZmZmZjMDAwMDAwMDAwMDogMDAwMCBbIzFdIFBSRUVNUFQgU01QIERFQlVHX1BBR0VB TExPQyBLQVNBTgo+ID4gPiBQVEkKPiA+ID4gWyAgIDY3LjYwNjMyOF0gS0FTQU46IG51bGwtcHRy LWRlcmVmIGluIHJhbmdlCj4gPiA+IFsweDAwMDAwMDAwMDAwMDAwMDAtMHgwMDAwMDAwMDAwMDAw MDA3XQo+ID4gPiBbICAgNjcuNjA2Mzg3XSBDUFU6IDMgUElEOiAxNDYzIENvbW06IHJtbW9kIE5v dCB0YWludGVkIDUuMTkuMC1yYzErICM2NjkKPiA+ID4gWyAgIDY3LjYwNjQ1Nl0gSGFyZHdhcmUg bmFtZTogSW50ZWwoUikgQ2xpZW50IFN5c3RlbXMKPiA+ID4gTlVDOGk3SFZLL05VQzhpN0hWQiwg QklPUyBITktCTGk3MC44NkEuMDA2Ny4yMDIxLjA1MjguMTMzOSAwNS8yOC8yMDIxCj4gPiA+IFsg ICA2Ny42MDY0OTJdIFJJUDogMDAxMDptaGlfaXJxX2hhbmRsZXIrMHg2MS8weDM3MCBbbWhpXQo+ ID4gPiBbICAgNjcuNjA2NTY1XSBDb2RlOiAwMCA0OCA4OSBmYSA0OCBjMSBlYSAwMyA4MCAzYyAw MiAwMCAwZiA4NSA5YiAwMiAwMAo+ID4gPiAwMCA0OSA4YiBhZCAyMCAwMSAwMCAwMCA0OCBiOCAw MCAwMCAwMCAwMCAwMCBmYyBmZiBkZiA0OCA4OSBlYSA0OCBjMSBlYQo+ID4gPiAwMyA8ODA+IDNj IDAyIDAwIDBmIDg1IGJkIDAyIDAwIDAwIDQ4IDhkIDdiIDEwIDQ4IDhiIDZkIDAwIDQ4IGI4IDAw IDAwCj4gPiA+IFsgICA2Ny42MDY2MzldIFJTUDogMDAxODpmZmZmYzkwMDA0MmZmYmE4IEVGTEFH UzogMDAwMTAwNDYKPiA+ID4gWyAgIDY3LjYwNjcwNl0gUkFYOiBkZmZmZmMwMDAwMDAwMDAwIFJC WDogZmZmZjg4ODEyZTFlMjgwMCBSQ1g6Cj4gPiA+IDAwMDAwMDAwMDAwMDAwMDEKPiA+ID4gWyAg IDY3LjYwNjc0Ml0gUkRYOiAwMDAwMDAwMDAwMDAwMDAwIFJTSTogZmZmZjg4ODEyZTFlMjgwMCBS REk6Cj4gPiA+IGZmZmY4ODgxMTBlOGQxMjAKPiA+ID4gWyAgIDY3LjYwNjc3Nl0gUkJQOiAwMDAw MDAwMDAwMDAwMDAwIFIwODogMDAwMDAwMDAwMDAwMDAwMSBSMDk6Cj4gPiA+IGZmZmZmZmZmODZh YzE3YWYKPiA+ID4gWyAgIDY3LjYwNjgxMF0gUjEwOiBmZmZmZmJmZmYwZDU4MmY1IFIxMTogMDAw MDAwMDAwMDAwMDAwMSBSMTI6Cj4gPiA+IGZmZmY4ODgxMmMzYWZiODAKPiA+ID4gWyAgIDY3LjYw Njg0NV0gUjEzOiBmZmZmODg4MTEwZThkMDAwIFIxNDogZmZmZjg4ODExZGRiYTgwMCBSMTU6Cj4g PiA+IGZmZmY4ODgxMmUxZTI4MDAKPiA+ID4gWyAgIDY3LjYwNjg4MF0gRlM6ICAwMDAwN2ZlZjAw Nzk0NzQwKDAwMDApIEdTOmZmZmY4ODgyMzQyMDAwMDAoMDAwMCkKPiA+ID4ga25sR1M6MDAwMDAw MDAwMDAwMDAwMAo+ID4gPiBbICAgNjcuNjA2OTE1XSBDUzogIDAwMTAgRFM6IDAwMDAgRVM6IDAw MDAgQ1IwOiAwMDAwMDAwMDgwMDUwMDMzCj4gPiA+IFsgICA2Ny42MDY5NTBdIENSMjogMDAwMDU1 ZGYyMzIzYjc4OCBDUjM6IDAwMDAwMDAxMDk4NDQwMDEgQ1I0Ogo+ID4gPiAwMDAwMDAwMDAwMzcw NmUwCj4gPiA+IFsgICA2Ny42MDY5ODddIENhbGwgVHJhY2U6Cj4gPiA+IFsgICA2Ny42MDcwMjFd ICA8VEFTSz4KPiA+ID4gWyAgIDY3LjYwNzA1Nl0gIF9fZnJlZV9pcnErMHg1OTAvMHg5ZDAKPiA+ ID4gWyAgIDY3LjYwNzA5OV0gID8gc2xhYl9mcmVlX2ZyZWVsaXN0X2hvb2srMHhmMC8weDFhMAo+ ID4gPiBbICAgNjcuNjA3MTM2XSAgZnJlZV9pcnErMHg3Yi8weDExMAo+ID4gPiBbICAgNjcuNjA3 MTcxXSAgbWhpX2RlaW5pdF9mcmVlX2lycSsweDE0ZS8weDI2MCBbbWhpXQo+ID4gPiBbICAgNjcu NjA3MjEwXSAgbWhpX3VucmVnaXN0ZXJfY29udHJvbGxlcisweDY5LzB4MjkwIFttaGldCj4gPiA+ IFsgICA2Ny42MDcyNDldICBhdGgxMWtfbWhpX3VucmVnaXN0ZXIrMHgyYi8weDcwIFthdGgxMWtf cGNpXQo+ID4gPiBbICAgNjcuNjA3Mjg0XSAgYXRoMTFrX3BjaV9yZW1vdmUrMHgxMDcvMHgyYTAg W2F0aDExa19wY2ldCj4gPiA+IFsgICA2Ny42MDczMjFdICBwY2lfZGV2aWNlX3JlbW92ZSsweDg5 LzB4MWIwCj4gPiA+IFsgICA2Ny42MDczNTldICBkZXZpY2VfcmVsZWFzZV9kcml2ZXJfaW50ZXJu YWwrMHgzYmMvMHg2MDAKPiA+ID4gWyAgIDY3LjYwNzQwMF0gIGRyaXZlcl9kZXRhY2grMHhiYy8w eDE4MAo+ID4gPiBbICAgNjcuNjA3NDM5XSAgYnVzX3JlbW92ZV9kcml2ZXIrMHhlMi8weDJkMAo+ ID4gPiBbICAgNjcuNjA3NDc2XSAgcGNpX3VucmVnaXN0ZXJfZHJpdmVyKzB4MjEvMHgyNTAKPiA+ ID4gWyAgIDY3LjYwNzUxMl0gIF9fZG9fc3lzX2RlbGV0ZV9tb2R1bGUrMHgzMDcvMHg0YjAKPiA+ ID4gWyAgIDY3LjYwNzU0OF0gID8gZnJlZV9tb2R1bGUrMHg0ZTAvMHg0ZTAKPiA+ID4gWyAgIDY3 LjYwNzU4NF0gID8gbG9ja2RlcF9oYXJkaXJxc19vbl9wcmVwYXJlLnBhcnQuMCsweDE4Yy8weDM3 MAo+ID4gPiBbICAgNjcuNjA3NjE4XSAgPyBzeXNjYWxsX2VudGVyX2Zyb21fdXNlcl9tb2RlKzB4 MWQvMHg1MAo+ID4gPiBbICAgNjcuNjA3NjUzXSAgPyBsb2NrZGVwX2hhcmRpcnFzX29uKzB4Nzkv MHgxMDAKPiA+ID4gWyAgIDY3LjYwNzY4OF0gIGRvX3N5c2NhbGxfNjQrMHgzNS8weDgwCj4gPiA+ IFsgICA2Ny42MDc3MjNdICBlbnRyeV9TWVNDQUxMXzY0X2FmdGVyX2h3ZnJhbWUrMHg0Ni8weGIw Cj4gPiA+IFsgICA2Ny42MDc3NThdIFJJUDogMDAzMzoweDdmZWYwMDhlMWE2Ygo+ID4gPiBbICAg NjcuNjA3Nzk0XSBDb2RlOiA3MyAwMSBjMyA0OCA4YiAwZCAyNSBjNCAwYyAwMCBmNyBkOCA2NCA4 OSAwMSA0OCA4Mwo+ID4gPiBjOCBmZiBjMyA2NiAyZSAwZiAxZiA4NCAwMCAwMCAwMCAwMCAwMCA5 MCBmMyAwZiAxZSBmYSBiOCBiMCAwMCAwMCAwMCAwZgo+ID4gPiAwNSA8NDg+IDNkIDAxIGYwIGZm IGZmIDczIDAxIGMzIDQ4IDhiIDBkIGY1IGMzIDBjIDAwIGY3IGQ4IDY0IDg5IDAxIDQ4Cj4gPiA+ IFsgICA2Ny42MDc4MzZdIFJTUDogMDAyYjowMDAwN2ZmZGQ1ODAzYTM4IEVGTEFHUzogMDAwMDAy MDYgT1JJR19SQVg6Cj4gPiA+IDAwMDAwMDAwMDAwMDAwYjAKPiA+ID4gWyAgIDY3LjYwNzg3M10g UkFYOiBmZmZmZmZmZmZmZmZmZmRhIFJCWDogMDAwMDU1YzBkM2YxMDdhMCBSQ1g6Cj4gPiA+IDAw MDA3ZmVmMDA4ZTFhNmIKPiA+ID4gWyAgIDY3LjYwNzk2MV0gUkRYOiAwMDAwMDAwMDAwMDAwMDBh IFJTSTogMDAwMDAwMDAwMDAwMDgwMCBSREk6Cj4gPiA+IDAwMDA1NWMwZDNmMTA4MDgKPiA+ID4g WyAgIDY3LjYwNzk5NV0gUkJQOiAwMDAwN2ZmZGQ1ODAzYTk4IFIwODogMDAwMDAwMDAwMDAwMDAw MCBSMDk6Cj4gPiA+IDAwMDAwMDAwMDAwMDAwMDAKPiA+ID4gWyAgIDY3LjYwODAyOV0gUjEwOiAw MDAwN2ZlZjAwOTVkYWMwIFIxMTogMDAwMDAwMDAwMDAwMDIwNiBSMTI6Cj4gPiA+IDAwMDA3ZmZk ZDU4MDNjNzAKPiA+ID4gWyAgIDY3LjYwODA2M10gUjEzOiAwMDAwN2ZmZGQ1ODA0ZWI3IFIxNDog MDAwMDU1YzBkM2YwZjJhMCBSMTU6Cj4gPiA+IDAwMDA1NWMwZDNmMTA3YTAKPiA+ID4gWyAgIDY3 LjYwODEwMF0gIDwvVEFTSz4KPiA+ID4gWyAgIDY3LjYwODEzNF0gTW9kdWxlcyBsaW5rZWQgaW46 IGF0aDExa19wY2koLSkgYXRoMTFrIG1hYzgwMjExIGxpYmFyYzQKPiA+ID4gY2ZnODAyMTEgcW1p X2hlbHBlcnMgcXJ0cl9taGkgbWhpIHFydHIgbnZtZSBudm1lX2NvcmUKPiA+ID4gWyAgIDY3LjYw ODE4NV0gLS0tWyBlbmQgdHJhY2UgMDAwMDAwMDAwMDAwMDAwMCBdLS0tCj4gPiA+IFsgICA2Ny42 MDgxODZdIFJJUDogMDAxMDptaGlfaXJxX2hhbmRsZXIrMHg2MS8weDM3MCBbbWhpXQo+ID4gPiBb ICAgNjcuNjA4MTkyXSBDb2RlOiAwMCA0OCA4OSBmYSA0OCBjMSBlYSAwMyA4MCAzYyAwMiAwMCAw ZiA4NSA5YiAwMiAwMAo+ID4gPiAwMCA0OSA4YiBhZCAyMCAwMSAwMCAwMCA0OCBiOCAwMCAwMCAw MCAwMCAwMCBmYyBmZiBkZiA0OCA4OSBlYSA0OCBjMSBlYQo+ID4gPiAwMyA8ODA+IDNjIDAyIDAw IDBmIDg1IGJkIDAyIDAwIDAwIDQ4IDhkIDdiIDEwIDQ4IDhiIDZkIDAwIDQ4IGI4IDAwIDAwCj4g PiA+IFsgICA2Ny42MDgxOTRdIFJTUDogMDAxODpmZmZmYzkwMDA0MmZmYmE4IEVGTEFHUzogMDAw MTAwNDYKPiA+ID4gWyAgIDY3LjYwODE5Nl0gUkFYOiBkZmZmZmMwMDAwMDAwMDAwIFJCWDogZmZm Zjg4ODEyZTFlMjgwMCBSQ1g6Cj4gPiA+IDAwMDAwMDAwMDAwMDAwMDEKPiA+ID4gWyAgIDY3LjYw ODE5N10gUkRYOiAwMDAwMDAwMDAwMDAwMDAwIFJTSTogZmZmZjg4ODEyZTFlMjgwMCBSREk6Cj4g PiA+IGZmZmY4ODgxMTBlOGQxMjAKPiA+ID4gWyAgIDY3LjYwODE5OF0gUkJQOiAwMDAwMDAwMDAw MDAwMDAwIFIwODogMDAwMDAwMDAwMDAwMDAwMSBSMDk6Cj4gPiA+IGZmZmZmZmZmODZhYzE3YWYK PiA+ID4gWyAgIDY3LjYwODE5OV0gUjEwOiBmZmZmZmJmZmYwZDU4MmY1IFIxMTogMDAwMDAwMDAw MDAwMDAwMSBSMTI6Cj4gPiA+IGZmZmY4ODgxMmMzYWZiODAKPiA+ID4gWyAgIDY3LjYwODIwMF0g UjEzOiBmZmZmODg4MTEwZThkMDAwIFIxNDogZmZmZjg4ODExZGRiYTgwMCBSMTU6Cj4gPiA+IGZm ZmY4ODgxMmUxZTI4MDAKPiA+ID4gWyAgIDY3LjYwODIwMV0gRlM6ICAwMDAwN2ZlZjAwNzk0NzQw KDAwMDApIEdTOmZmZmY4ODgyMzQyMDAwMDAoMDAwMCkKPiA+ID4ga25sR1M6MDAwMDAwMDAwMDAw MDAwMAo+ID4gPiBbICAgNjcuNjA4MjAzXSBDUzogIDAwMTAgRFM6IDAwMDAgRVM6IDAwMDAgQ1Iw OiAwMDAwMDAwMDgwMDUwMDMzCj4gPiA+IFsgICA2Ny42MDgyMDRdIENSMjogMDAwMDU1ZGYyMzIz Yjc4OCBDUjM6IDAwMDAwMDAxMDk4NDQwMDEgQ1I0Ogo+ID4gPiAwMDAwMDAwMDAwMzcwNmUwCj4g PiA+IFsgICA2Ny42MDgyMDZdIEtlcm5lbCBwYW5pYyAtIG5vdCBzeW5jaW5nOiBGYXRhbCBleGNl cHRpb24KPiA+ID4gWyAgIDY3LjYwODY2NV0gS2VybmVsIE9mZnNldDogMHhhMDAwMDAgZnJvbSAw eGZmZmZmZmZmODEwMDAwMDAKPiA+ID4gKHJlbG9jYXRpb24gcmFuZ2U6IDB4ZmZmZmZmZmY4MDAw MDAwMC0weGZmZmZmZmZmYmZmZmZmZmYpCj4gPiA+IFsgICA2Ny42MDg3MDRdIFJlYm9vdGluZyBp biAxMCBzZWNvbmRzLi4KPiA+ID4gCj4gPiA+IGdpdCBiaXNlY3Qgc3RhcnQKPiA+ID4gIyBiYWQ6 IFs5ZGYxMjVhZjA4MjJkM2UyYmRlNzUwOGU5NTM2ZDY3YWI1NDFhMTY2XSBidXM6IG1oaTogZXA6 IENoZWNrIGRldl9zZXRfbmFtZSgpIHJldHVybiB2YWx1ZQo+ID4gPiBnaXQgYmlzZWN0IGJhZCA5 ZGYxMjVhZjA4MjJkM2UyYmRlNzUwOGU5NTM2ZDY3YWI1NDFhMTY2Cj4gPiA+ICMgZ29vZDogWzE3 ODMyOWQ0ZDYzNWZiMTg0OGNjN2NhMTgwM2RlZTVhNjM0Y2RlMGRdIGJ1czogbWhpOiBob3N0OiBw Y2lfZ2VuZXJpYzogQWRkIHN1cHBvcnQgZm9yIFF1ZWN0ZWwgRU0xMjAgRkNDTCBtb2RlbQo+ID4g PiBnaXQgYmlzZWN0IGdvb2QgMTc4MzI5ZDRkNjM1ZmIxODQ4Y2M3Y2ExODAzZGVlNWE2MzRjZGUw ZAo+ID4gPiAjIGJhZDogWzEyMjdkMmEyMGNkNzMxOWZiNDVjNjJmYWI0YjI1MjYwMGUwMzA4YmZd IGJ1czogbWhpOiBob3N0OiBNb3ZlIElSUSBhbGxvY2F0aW9uIHRvIGNvbnRyb2xsZXIgcmVnaXN0 cmF0aW9uIHBoYXNlCj4gPiA+IGdpdCBiaXNlY3QgYmFkIDEyMjdkMmEyMGNkNzMxOWZiNDVjNjJm YWI0YjI1MjYwMGUwMzA4YmYKPiA+ID4gIyBnb29kOiBbYjdjZTcxNjI1NDMxNWRmZmNmY2U2MGUx NDlkZGQwMjJjOGE2MDM0NV0gYnVzOiBtaGk6IGhvc3Q6IHBjaV9nZW5lcmljOiBBZGQgQ2ludGVy aW9uIE1WMzEtVyB3aXRoIG5ldyBiYXNlbGluZQo+ID4gPiBnaXQgYmlzZWN0IGdvb2QgYjdjZTcx NjI1NDMxNWRmZmNmY2U2MGUxNDlkZGQwMjJjOGE2MDM0NQo+ID4gPiAjIGZpcnN0IGJhZCBjb21t aXQ6IFsxMjI3ZDJhMjBjZDczMTlmYjQ1YzYyZmFiNGIyNTI2MDBlMDMwOGJmXSBidXM6IG1oaTog aG9zdDogTW92ZSBJUlEgYWxsb2NhdGlvbiB0byBjb250cm9sbGVyIHJlZ2lzdHJhdGlvbiBwaGFz ZQo+ID4gPiAKPiA+ID4gLS0gCj4gPiA+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJv amVjdC9saW51eC13aXJlbGVzcy9saXN0Lwo+ID4gPiAKPiA+ID4gaHR0cHM6Ly93aXJlbGVzcy53 aWtpLmtlcm5lbC5vcmcvZW4vZGV2ZWxvcGVycy9kb2N1bWVudGF0aW9uL3N1Ym1pdHRpbmdwYXRj aGVzCj4gPiA+IAo+IAoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDgrprgrqTgrr7g rprgrr/grrXgrq7gr40KCi0tIAphdGgxMWsgbWFpbGluZyBsaXN0CmF0aDExa0BsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRo MTFrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F81C433EF for ; Thu, 21 Jul 2022 10:19:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231859AbiGUKTg (ORCPT ); Thu, 21 Jul 2022 06:19:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230149AbiGUKTf (ORCPT ); Thu, 21 Jul 2022 06:19:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E89F782397; Thu, 21 Jul 2022 03:19:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E892B8239C; Thu, 21 Jul 2022 10:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7376CC3411E; Thu, 21 Jul 2022 10:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658398770; bh=uF9353hnQZd3BXE41rHODhzKSUHBPzaXqjrZu5+fQok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g5wyVh3Gn4BsqDlCw+fbSxAn78RXXIoT3k3EmqB0Q3qRZUwmQ3UxcuC/hHdKqjryt UL0Z3gxCcIXkmUt1MDIx/8wSh5BRe3U1sVMgqUoU3kk9dU5JZyxzmaiHhZOV5zqVXq VCQQPVKwcPaCvLe+g9GrpaAbZuqIwOebbv+dSZjjxDLLw4CMvvoC8rEv7kjHLkXAxa svCKnBBJDIrefopoBqpBDgBxHyCpIOSm3qOic/fwAaTJ7batwifueGm+IchNg8O24J ef957N0zqIj6XCdzvwVhwuqnowdjeKGFsjxOrarhIm38uqnun3ZcHGXXHkYY3EdZeZ ms8mPLsXjnVOQ== Date: Thu, 21 Jul 2022 15:49:14 +0530 From: Manivannan Sadhasivam To: Qiang Yu Cc: Manivannan Sadhasivam , Kalle Valo , quic_hemantk@quicinc.com, loic.poulain@linaro.org, quic_jhugo@quicinc.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, ath11k@lists.infradead.org Subject: Re: [PATCH v4 1/1] bus: mhi: host: Move IRQ allocation to controller registration phase Message-ID: <20220721101914.GC36189@thinkpad> References: <1655952183-66792-1-git-send-email-quic_qianyu@quicinc.com> <20220624072740.GA12171@thinkpad> <87k08an038.fsf@kernel.org> <20220720093909.GA5747@thinkpad> <063fe6bf-11b1-1724-058f-0fed7247906e@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <063fe6bf-11b1-1724-058f-0fed7247906e@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Jul 20, 2022 at 05:47:37PM +0800, Qiang Yu wrote: > > On 7/20/2022 5:39 PM, Manivannan Sadhasivam wrote: > > On Mon, Jul 18, 2022 at 02:15:23PM +0300, Kalle Valo wrote: > > > + ath11k list > > > > > > Manivannan Sadhasivam writes: > > > > > > > On Thu, Jun 23, 2022 at 10:43:03AM +0800, Qiang Yu wrote: > > > > > During runtime, the MHI endpoint may be powered up/down several times. > > > > > So instead of allocating and destroying the IRQs all the time, let's just > > > > > enable/disable IRQs during power up/down. > > > > > > > > > > The IRQs will be allocated during mhi_register_controller() and freed > > > > > during mhi_unregister_controller(). This works well for things like PCI > > > > > hotplug also as once the PCI device gets removed, the controller will > > > > > get unregistered. And once it comes back, it will get registered back > > > > > and even if the IRQ configuration changes (MSI), that will get accounted. > > > > > > > > > > Signed-off-by: Qiang Yu > > > > Applied to mhi-next! > > > I did a bisect and this patch breaks ath11k during rmmod. I'm on > > > vacation right now so I can't investigate in detail but more info below. > > > > > I just tested linux-next/master next-20220718 on my NUC with QCA6390, but I'm > > not able to reproduce the issue during rmmod! Instead I couldn't connect to AP. > > I suspect that in __free_irq(), if CONFIG_DEBUG_SHIRQ is enabled, irq > handler for a shared IRQ will be invoked and null pointer access happen. > > #ifdef CONFIG_DEBUG_SHIRQ >     /* >      * It's a shared IRQ -- the driver ought to be prepared for an IRQ >      * event to happen even now it's being freed, so let's make sure that >      * is so by doing an extra call to the handler .... >      * >      * ( We do this after actually deregistering it, to make sure that a >      *   'real' IRQ doesn't run in parallel with our fake. ) >      */ >     if (action->flags & IRQF_SHARED) { >         local_irq_save(flags); >         action->handler(irq, dev_id); >         local_irq_restore(flags); >     } > #endif > Ah yes, after enabling CONFIG_DEBUG_SHIRQ I could reproduce the issue. Thanks, Mani > > > > log: https://paste.debian.net/1247788/ > > > > Thanks, > > Mani > > > > > [ 66.939878] rmmod ath11k_pci > > > [ 67.606269] general protection fault, probably for non-canonical > > > address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN > > > PTI > > > [ 67.606328] KASAN: null-ptr-deref in range > > > [0x0000000000000000-0x0000000000000007] > > > [ 67.606387] CPU: 3 PID: 1463 Comm: rmmod Not tainted 5.19.0-rc1+ #669 > > > [ 67.606456] Hardware name: Intel(R) Client Systems > > > NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0067.2021.0528.1339 05/28/2021 > > > [ 67.606492] RIP: 0010:mhi_irq_handler+0x61/0x370 [mhi] > > > [ 67.606565] Code: 00 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 9b 02 00 > > > 00 49 8b ad 20 01 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 ea 48 c1 ea > > > 03 <80> 3c 02 00 0f 85 bd 02 00 00 48 8d 7b 10 48 8b 6d 00 48 b8 00 00 > > > [ 67.606639] RSP: 0018:ffffc900042ffba8 EFLAGS: 00010046 > > > [ 67.606706] RAX: dffffc0000000000 RBX: ffff88812e1e2800 RCX: > > > 0000000000000001 > > > [ 67.606742] RDX: 0000000000000000 RSI: ffff88812e1e2800 RDI: > > > ffff888110e8d120 > > > [ 67.606776] RBP: 0000000000000000 R08: 0000000000000001 R09: > > > ffffffff86ac17af > > > [ 67.606810] R10: fffffbfff0d582f5 R11: 0000000000000001 R12: > > > ffff88812c3afb80 > > > [ 67.606845] R13: ffff888110e8d000 R14: ffff88811ddba800 R15: > > > ffff88812e1e2800 > > > [ 67.606880] FS: 00007fef00794740(0000) GS:ffff888234200000(0000) > > > knlGS:0000000000000000 > > > [ 67.606915] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > [ 67.606950] CR2: 000055df2323b788 CR3: 0000000109844001 CR4: > > > 00000000003706e0 > > > [ 67.606987] Call Trace: > > > [ 67.607021] > > > [ 67.607056] __free_irq+0x590/0x9d0 > > > [ 67.607099] ? slab_free_freelist_hook+0xf0/0x1a0 > > > [ 67.607136] free_irq+0x7b/0x110 > > > [ 67.607171] mhi_deinit_free_irq+0x14e/0x260 [mhi] > > > [ 67.607210] mhi_unregister_controller+0x69/0x290 [mhi] > > > [ 67.607249] ath11k_mhi_unregister+0x2b/0x70 [ath11k_pci] > > > [ 67.607284] ath11k_pci_remove+0x107/0x2a0 [ath11k_pci] > > > [ 67.607321] pci_device_remove+0x89/0x1b0 > > > [ 67.607359] device_release_driver_internal+0x3bc/0x600 > > > [ 67.607400] driver_detach+0xbc/0x180 > > > [ 67.607439] bus_remove_driver+0xe2/0x2d0 > > > [ 67.607476] pci_unregister_driver+0x21/0x250 > > > [ 67.607512] __do_sys_delete_module+0x307/0x4b0 > > > [ 67.607548] ? free_module+0x4e0/0x4e0 > > > [ 67.607584] ? lockdep_hardirqs_on_prepare.part.0+0x18c/0x370 > > > [ 67.607618] ? syscall_enter_from_user_mode+0x1d/0x50 > > > [ 67.607653] ? lockdep_hardirqs_on+0x79/0x100 > > > [ 67.607688] do_syscall_64+0x35/0x80 > > > [ 67.607723] entry_SYSCALL_64_after_hwframe+0x46/0xb0 > > > [ 67.607758] RIP: 0033:0x7fef008e1a6b > > > [ 67.607794] Code: 73 01 c3 48 8b 0d 25 c4 0c 00 f7 d8 64 89 01 48 83 > > > c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00 00 0f > > > 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d f5 c3 0c 00 f7 d8 64 89 01 48 > > > [ 67.607836] RSP: 002b:00007ffdd5803a38 EFLAGS: 00000206 ORIG_RAX: > > > 00000000000000b0 > > > [ 67.607873] RAX: ffffffffffffffda RBX: 000055c0d3f107a0 RCX: > > > 00007fef008e1a6b > > > [ 67.607961] RDX: 000000000000000a RSI: 0000000000000800 RDI: > > > 000055c0d3f10808 > > > [ 67.607995] RBP: 00007ffdd5803a98 R08: 0000000000000000 R09: > > > 0000000000000000 > > > [ 67.608029] R10: 00007fef0095dac0 R11: 0000000000000206 R12: > > > 00007ffdd5803c70 > > > [ 67.608063] R13: 00007ffdd5804eb7 R14: 000055c0d3f0f2a0 R15: > > > 000055c0d3f107a0 > > > [ 67.608100] > > > [ 67.608134] Modules linked in: ath11k_pci(-) ath11k mac80211 libarc4 > > > cfg80211 qmi_helpers qrtr_mhi mhi qrtr nvme nvme_core > > > [ 67.608185] ---[ end trace 0000000000000000 ]--- > > > [ 67.608186] RIP: 0010:mhi_irq_handler+0x61/0x370 [mhi] > > > [ 67.608192] Code: 00 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 9b 02 00 > > > 00 49 8b ad 20 01 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 ea 48 c1 ea > > > 03 <80> 3c 02 00 0f 85 bd 02 00 00 48 8d 7b 10 48 8b 6d 00 48 b8 00 00 > > > [ 67.608194] RSP: 0018:ffffc900042ffba8 EFLAGS: 00010046 > > > [ 67.608196] RAX: dffffc0000000000 RBX: ffff88812e1e2800 RCX: > > > 0000000000000001 > > > [ 67.608197] RDX: 0000000000000000 RSI: ffff88812e1e2800 RDI: > > > ffff888110e8d120 > > > [ 67.608198] RBP: 0000000000000000 R08: 0000000000000001 R09: > > > ffffffff86ac17af > > > [ 67.608199] R10: fffffbfff0d582f5 R11: 0000000000000001 R12: > > > ffff88812c3afb80 > > > [ 67.608200] R13: ffff888110e8d000 R14: ffff88811ddba800 R15: > > > ffff88812e1e2800 > > > [ 67.608201] FS: 00007fef00794740(0000) GS:ffff888234200000(0000) > > > knlGS:0000000000000000 > > > [ 67.608203] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > [ 67.608204] CR2: 000055df2323b788 CR3: 0000000109844001 CR4: > > > 00000000003706e0 > > > [ 67.608206] Kernel panic - not syncing: Fatal exception > > > [ 67.608665] Kernel Offset: 0xa00000 from 0xffffffff81000000 > > > (relocation range: 0xffffffff80000000-0xffffffffbfffffff) > > > [ 67.608704] Rebooting in 10 seconds.. > > > > > > git bisect start > > > # bad: [9df125af0822d3e2bde7508e9536d67ab541a166] bus: mhi: ep: Check dev_set_name() return value > > > git bisect bad 9df125af0822d3e2bde7508e9536d67ab541a166 > > > # good: [178329d4d635fb1848cc7ca1803dee5a634cde0d] bus: mhi: host: pci_generic: Add support for Quectel EM120 FCCL modem > > > git bisect good 178329d4d635fb1848cc7ca1803dee5a634cde0d > > > # bad: [1227d2a20cd7319fb45c62fab4b252600e0308bf] bus: mhi: host: Move IRQ allocation to controller registration phase > > > git bisect bad 1227d2a20cd7319fb45c62fab4b252600e0308bf > > > # good: [b7ce716254315dffcfce60e149ddd022c8a60345] bus: mhi: host: pci_generic: Add Cinterion MV31-W with new baseline > > > git bisect good b7ce716254315dffcfce60e149ddd022c8a60345 > > > # first bad commit: [1227d2a20cd7319fb45c62fab4b252600e0308bf] bus: mhi: host: Move IRQ allocation to controller registration phase > > > > > > -- > > > https://patchwork.kernel.org/project/linux-wireless/list/ > > > > > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches > > > > -- மணிவண்ணன் சதாசிவம்