From: Rob Herring <robh@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: christophe.jaillet@wanadoo.fr, krzysztof.kozlowski+dt@linaro.org,
linux-usb@vger.kernel.org, robh+dt@kernel.org,
amelie.delaunay@foss.st.com, linux-kernel@vger.kernel.org,
alexandre.torgue@foss.st.com, heikki.krogerus@linux.intel.com,
linux-stm32@st-md-mailman.stormreply.com,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 1/3] dt-bindings: usb: typec: add bindings for stm32g0 controller
Date: Thu, 21 Jul 2022 18:25:46 -0600 [thread overview]
Message-ID: <20220722002546.GA2240166-robh@kernel.org> (raw)
In-Reply-To: <20220713120842.560902-2-fabrice.gasnier@foss.st.com>
On Wed, 13 Jul 2022 14:08:40 +0200, Fabrice Gasnier wrote:
> Add DT schema documentation for the STM32G0 Type-C PD (Power Delivery)
> controller.
> STM32G0 provides an integrated USB Type-C and power delivery interface.
> It can be programmed with a firmware to handle UCSI protocol over I2C
> interface. A GPIO is used as an interrupt line.
> It may be used as a wakeup source, so use optional "wakeup-source" and
> "power-domains" properties to support wakeup.
> The firmware itself may be flashed or later updated (optional). Choice is
> let to the application to allow firmware update. A default firmware could
> be already programmed in production and be customized (to not allow it).
> So the firmware-name is made optional to represent this option.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> ---
> Changes in v3:
> - Add connector to the required properties as pointed out by Krzysztof.
> Update commit message to explain why the firmware-name is optional.
> Changes in v2:
> - Krzysztof's review comments: update commit message, use ports, use
> unevaluatedProperties: false for usb-connector schema, define maxItems
> for power-domains, adopt generic node names, remove quotes
> ---
> .../bindings/usb/st,typec-stm32g0.yaml | 91 +++++++++++++++++++
> 1 file changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/st,typec-stm32g0.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-07-22 0:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 12:08 [PATCH v3 0/3] usb: typec: ucsi: add support for stm32g0 Fabrice Gasnier
2022-07-13 12:08 ` [PATCH v3 1/3] dt-bindings: usb: typec: add bindings for stm32g0 controller Fabrice Gasnier
2022-07-22 0:25 ` Rob Herring [this message]
2022-07-13 12:08 ` [PATCH v3 2/3] usb: typec: ucsi: stm32g0: add support " Fabrice Gasnier
2022-07-13 12:08 ` [PATCH v3 3/3] usb: typec: ucsi: stm32g0: add bootloader support Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722002546.GA2240166-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.