From: Dan Carpenter <dan.carpenter@oracle.com>
To: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
Cc: Corentin Labbe <clabbe@baylibre.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: staging: media: zoran: Fixed Block comments
Date: Fri, 22 Jul 2022 09:32:08 +0300 [thread overview]
Message-ID: <20220722063208.GN2338@kadam> (raw)
In-Reply-To: <20220721173729.63844-1-abhijeet.srivastava2308@gmail.com>
On Thu, Jul 21, 2022 at 11:07:22PM +0530, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
> drivers/staging/media/zoran/zoran_driver.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> index 4304b7e21709..b408c1d4e0a7 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -746,9 +746,11 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
> .vidioc_enum_input = zoran_enum_input,
> .vidioc_g_input = zoran_g_input,
> .vidioc_s_input = zoran_s_input,
> +
> /* .vidioc_enum_output = zoran_enum_output,
> - .vidioc_g_output = zoran_g_output,
> - .vidioc_s_output = zoran_s_output,*/
> + * .vidioc_g_output = zoran_g_output,
> + * .vidioc_s_output = zoran_s_output,
> + */
Always, just delete dead code.
regards,
dan carpenter
prev parent reply other threads:[~2022-07-22 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 17:37 [PATCH] media: staging: media: zoran: Fixed Block comments Abhijeet Srivastava
2022-07-21 17:37 ` Abhijeet Srivastava
2022-07-22 6:32 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722063208.GN2338@kadam \
--to=dan.carpenter@oracle.com \
--cc=abhijeet.srivastava2308@gmail.com \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.