From: Jakub Kicinski <kuba@kernel.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: David Miller <davem@davemloft.net>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
Subject: Re: pull request: bluetooth-next 2022-07-22
Date: Fri, 22 Jul 2022 17:19:19 -0700 [thread overview]
Message-ID: <20220722171919.04493224@kernel.org> (raw)
In-Reply-To: <CABBYNZLj2z_81p=q0iSxEBgVW_L3dw8UKGwQKOEDj9fgDLYJ0g@mail.gmail.com>
On Fri, 22 Jul 2022 17:09:33 -0700 Luiz Augusto von Dentz wrote:
> > I see two new sparse warnings (for a follow up):
> >
> > net/bluetooth/hci_event.c:3789:26: warning: cast to restricted __le16
> > net/bluetooth/hci_event.c:3791:26: warning: cast to restricted __le16
>
> Crap, let me fix them.
Do you mean i should hold off with pushing or you'll follow up?
> > Two bad Fixes tags:
> >
> > Commit: 68253f3cd715 ("Bluetooth: hci_sync: Fix resuming scan after suspend resume")
> > Fixes tag: Fixes: 3b42055388c30 (Bluetooth: hci_sync: Fix attempting to suspend with
> > Has these problem(s):
> > - Subject has leading but no trailing parentheses
> > Commit: 9111786492f1 ("Bluetooth: fix an error code in hci_register_dev()")
> > Fixes tag: Fixes: d6bb2a91f95b ("Bluetooth: Unregister suspend with userchannel")
> > Has these problem(s):
> > - Target SHA1 does not exist
> >
> > And a whole bunch of patches committed by you but signed off by Marcel.
> > Last time we tried to fix that it ended up making things worse.
> > So I guess it is what it is :) Pulling...
>
> Yep, that happens when I rebase on top of net-next so I would have to
> redo all the Signed-off-by lines if the patches were originally
> applied by Marcel, at least I don't know of any option to keep the
> original committer while rebasing?
I think the most common way is to avoid rebasing. Do you rebase to get
rid of revised patches or such?
next prev parent reply other threads:[~2022-07-23 0:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 20:54 pull request: bluetooth-next 2022-07-22 Luiz Augusto von Dentz
2022-07-22 23:55 ` Jakub Kicinski
2022-07-23 0:09 ` Luiz Augusto von Dentz
2022-07-23 0:19 ` Jakub Kicinski [this message]
2022-07-23 0:25 ` Luiz Augusto von Dentz
2022-07-23 0:50 ` Jakub Kicinski
2022-07-26 22:05 ` Luiz Augusto von Dentz
2022-07-26 22:31 ` Jakub Kicinski
2022-07-27 1:06 ` Luiz Augusto von Dentz
2022-07-27 2:47 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2022-07-23 0:22 Luiz Augusto von Dentz
2022-07-23 2:10 ` patchwork-bot+netdevbpf
2022-08-01 21:15 ` patchwork-bot+bluetooth
2022-07-22 20:53 Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722171919.04493224@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.