From: Jason Gunthorpe <jgg@nvidia.com>
To: Md Haris Iqbal <haris.phnx@gmail.com>
Cc: linux-rdma@vger.kernel.org, zyjzyj2000@gmail.com,
leon@kernel.org, haris.iqbal@ionos.com, jinpu.wang@ionos.com,
aleksei.marov@ionos.com, rpearsonhpe@gmail.com
Subject: Re: [PATCH] RDMA/rxe: For invalidate compare according to set keys in mr
Date: Fri, 22 Jul 2022 17:38:16 -0300 [thread overview]
Message-ID: <20220722203816.GA64457@nvidia.com> (raw)
In-Reply-To: <20220707073006.328737-1-haris.phnx@gmail.com>
On Thu, Jul 07, 2022 at 09:30:06AM +0200, Md Haris Iqbal wrote:
> The 'rkey' input can be an lkey or rkey, and in rxe the lkey or rkey have
> the same value, including the variant bits.
>
> So, if mr->rkey is set, compare the invalidate key with it, otherwise
> compare with the mr->lkey.
>
> Since we already did a lookup on the non-varient bits to get this far,
> the check's only purpose is to confirm that the wqe has the correct
> variant bits.
>
> Fixes: 001345339f4c ("RDMA/rxe: Separate HW and SW l/rkeys")
> Cc: rpearsonhpe@gmail.com
> Signed-off-by: Md Haris Iqbal <haris.phnx@gmail.com>
> Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>
> ---
> drivers/infiniband/sw/rxe/rxe_loc.h | 2 +-
> drivers/infiniband/sw/rxe/rxe_mr.c | 12 ++++++------
> 2 files changed, 7 insertions(+), 7 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2022-07-22 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 7:30 [PATCH] RDMA/rxe: For invalidate compare according to set keys in mr Md Haris Iqbal
2022-07-15 9:21 ` haris iqbal
2022-07-22 15:10 ` haris iqbal
2022-07-22 15:14 ` Jason Gunthorpe
2022-07-22 16:50 ` haris iqbal
2022-07-22 19:04 ` Bob Pearson
2022-07-22 20:38 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722203816.GA64457@nvidia.com \
--to=jgg@nvidia.com \
--cc=aleksei.marov@ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=haris.phnx@gmail.com \
--cc=jinpu.wang@ionos.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.