From: Jakub Kicinski <kuba@kernel.org>
To: Vikas Gupta <vikas.gupta@broadcom.com>
Cc: jiri@nvidia.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
dsahern@kernel.org, stephen@networkplumber.org,
edumazet@google.com, pabeni@redhat.com, ast@kernel.org,
leon@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net,
michael.chan@broadcom.com, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH net-next v6 1/2] devlink: introduce framework for selftests
Date: Sat, 23 Jul 2022 09:16:00 -0700 [thread overview]
Message-ID: <20220723091600.1277e903@kernel.org> (raw)
In-Reply-To: <20220723042206.8104-2-vikas.gupta@broadcom.com>
On Sat, 23 Jul 2022 09:52:05 +0530 Vikas Gupta wrote:
> +enum devlink_attr_selftest_test_id {
> + DEVLINK_ATTR_SELFTEST_TEST_ID_UNSPEC,
> + DEVLINK_ATTR_SELFTEST_TEST_ID_FLASH, /* flag */
> +
> + __DEVLINK_ATTR_SELFTEST_TEST_ID_MAX,
> + DEVLINK_ATTR_SELFTEST_TEST_ID_MAX = __DEVLINK_ATTR_SELFTEST_TEST_ID_MAX - 1
> +};
> +
> +enum devlink_selftest_test_status {
> + DEVLINK_SELFTEST_TEST_STATUS_SKIP,
> + DEVLINK_SELFTEST_TEST_STATUS_PASS,
> + DEVLINK_SELFTEST_TEST_STATUS_FAIL
> +};
> +
> +enum devlink_attr_selftest_result {
> + DEVLINK_ATTR_SELFTEST_RESULT_UNSPEC,
> + DEVLINK_ATTR_SELFTEST_RESULT, /* nested */
> + DEVLINK_ATTR_SELFTEST_RESULT_TEST_ID, /* u32,
> + * enum devlink_attr_selftest_test_id
> + */
> + DEVLINK_ATTR_SELFTEST_RESULT_TEST_STATUS, /* u8,
> + * enum devlink_selftest_test_status
> + */
> +
> + __DEVLINK_ATTR_SELFTEST_RESULT_MAX,
> + DEVLINK_ATTR_SELFTEST_RESULT_MAX = __DEVLINK_ATTR_SELFTEST_RESULT_MAX - 1
Any thoughts on running:
sed -i '/_SELFTEST/ {s/_TEST_/_/g}' $patch
on this patch? For example DEVLINK_ATTR_SELFTEST_RESULT_TEST_STATUS
is 40 characters long, ain't nobody typing that, and _TEST is repeated..
Otherwise LGTM!
next prev parent reply other threads:[~2022-07-23 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 4:22 [PATCH net-next v6 0/2] add framework for selftests in devlink Vikas Gupta
2022-07-23 4:22 ` [PATCH net-next v6 1/2] devlink: introduce framework for selftests Vikas Gupta
2022-07-23 15:43 ` Jiri Pirko
2022-07-23 16:16 ` Jakub Kicinski [this message]
2022-07-23 17:03 ` David Ahern
2022-07-25 7:53 ` Jiri Pirko
2022-07-25 8:48 ` Vikas Gupta
2022-07-25 11:07 ` Jiri Pirko
2022-07-23 4:22 ` [PATCH net-next v6 2/2] bnxt_en: implement callbacks for devlink selftests Vikas Gupta
2022-07-23 15:44 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220723091600.1277e903@kernel.org \
--to=kuba@kernel.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=ast@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
--cc=vikas.gupta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.