All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: David GOUARIN <dgouarin@gmail.com>
Cc: David GOUARIN <david.gouarin@thalesgroup.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/pkg-waf.mk: enable definiton of env. variables in every build steps
Date: Sun, 24 Jul 2022 00:26:51 +0200	[thread overview]
Message-ID: <20220723222651.GN2641@scaer> (raw)
In-Reply-To: <20220705134402.5914-1-david.gouarin@thalesgroup.com>

David, All,

On 2022-07-05 15:44 +0200, David GOUARIN spake thusly:
> It might be necessary for some packages to define environment variables when calling waf build and waf install.
> This is done the same way as the others package types, by defining $(PKG)_MAKE_ENV in .mk.
> 
> Signed-off-by: David GOUARIN <david.gouarin@thalesgroup.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/pkg-waf.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/pkg-waf.mk b/package/pkg-waf.mk
> index d546b4a817..e090afa9e6 100644
> --- a/package/pkg-waf.mk
> +++ b/package/pkg-waf.mk
> @@ -75,7 +75,7 @@ endif
>  ifndef $(2)_BUILD_CMDS
>  define $(2)_BUILD_CMDS
>  	cd $$($$(PKG)_SRCDIR) && \
> -	$$(TARGET_MAKE_ENV) $$(HOST_DIR)/bin/python3 $$($(2)_WAF) \
> +	$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$(HOST_DIR)/bin/python3 $$($(2)_WAF) \
>  		build $$(WAF_OPTS) $$($(2)_BUILD_OPTS) \
>  		$$($(2)_WAF_OPTS)
>  endef
> @@ -88,7 +88,7 @@ endif
>  ifndef $(2)_INSTALL_STAGING_CMDS
>  define $(2)_INSTALL_STAGING_CMDS
>  	cd $$($$(PKG)_SRCDIR) && \
> -	$$(TARGET_MAKE_ENV) $$(HOST_DIR)/bin/python3 $$($(2)_WAF) \
> +	$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$(HOST_DIR)/bin/python3 $$($(2)_WAF) \
>  		install --destdir=$$(STAGING_DIR) \
>  		$$($(2)_INSTALL_STAGING_OPTS) \
>  		$$($(2)_WAF_OPTS)
> @@ -102,7 +102,7 @@ endif
>  ifndef $(2)_INSTALL_TARGET_CMDS
>  define $(2)_INSTALL_TARGET_CMDS
>  	cd $$($$(PKG)_SRCDIR) && \
> -	$$(TARGET_MAKE_ENV) $$(HOST_DIR)/bin/python3 $$($(2)_WAF) \
> +	$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$(HOST_DIR)/bin/python3 $$($(2)_WAF) \
>  		install --destdir=$$(TARGET_DIR) \
>  		$$($(2)_INSTALL_TARGET_OPTS) \
>  		$$($(2)_WAF_OPTS)
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-07-23 22:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 13:44 [Buildroot] [PATCH 1/2] package/pkg-waf.mk: enable definiton of env. variables in every build steps David GOUARIN
2022-07-05 13:44 ` [Buildroot] [PATCH 2/2] package/libtalloc: bump version to 2.3.4 David GOUARIN
2022-07-23 17:15   ` Romain Naour
2022-07-24  7:59     ` Yann E. MORIN
2022-07-24  8:19       ` Romain Naour
2022-07-24  8:46         ` Yann E. MORIN
2022-07-24  8:55           ` Romain Naour
2022-07-24 10:54             ` Yann E. MORIN
2022-07-23 22:26 ` Yann E. MORIN [this message]
2022-08-16 19:59 ` [Buildroot] [PATCH 1/2] package/pkg-waf.mk: enable definiton of env. variables in every build steps Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220723222651.GN2641@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=david.gouarin@thalesgroup.com \
    --cc=dgouarin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.