All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: David GOUARIN <dgouarin@gmail.com>
Cc: romain.naour@smile.fr,
	David GOUARIN <david.gouarin@thalesgroup.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH V3] package/libtallc: bump version to 2.3.4
Date: Sun, 24 Jul 2022 16:58:46 +0200	[thread overview]
Message-ID: <20220724145846.GW2641@scaer> (raw)
In-Reply-To: <20220724142615.22630-1-dgouarin@gmail.com>

David, All,

On 2022-07-24 16:26 +0200, David GOUARIN spake thusly:
> Version 2.3.4 of libtalloc needs to define PYTHONHASHSEED, as a check has been added
> to the configure script, and build will fail if it is not defined.
> 
> This is originately a workaround by samba developpers meant to avoid rebuilding talloc
> with each call to make. Defining PYTHONHASHSEED would not be required in the context
> of builroot, if not for the check in the configure script.
> 
> Signed-off-by: David GOUARIN <david.gouarin@thalesgroup.com>
> 
> ---
> Changes v2 -> v3:
>   - fix commented lines and commit message. sorry for the mess.
> 
> Changes v1 -> v2:
>   - edit commit message (suggested by Yann E. MORIN)
> Signed-off-by: David GOUARIN <dgouarin@gmail.com>
> ---
>  package/libtalloc/libtalloc.hash | 2 +-
>  package/libtalloc/libtalloc.mk   | 5 ++++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libtalloc/libtalloc.hash b/package/libtalloc/libtalloc.hash
> index cbfd11e63b..0bc8edb695 100644
> --- a/package/libtalloc/libtalloc.hash
> +++ b/package/libtalloc/libtalloc.hash
> @@ -1,3 +1,3 @@
>  # Locally calculated
> -sha256  6be95b2368bd0af1c4cd7a88146eb6ceea18e46c3ffc9330bf6262b40d1d8aaa  talloc-2.3.3.tar.gz
> +sha256  179f9ebe265e67e4ab2c26cad2b7de4b6a77c6c212f966903382869f06be6505  talloc-2.3.4.tar.gz
>  sha256  f8340c449dd64a55c6605b02fcad2aec6f473612ac6026739a22995380a8043c  talloc.h
> diff --git a/package/libtalloc/libtalloc.mk b/package/libtalloc/libtalloc.mk
> index 8cba699ea1..6a5e1ef4b6 100644
> --- a/package/libtalloc/libtalloc.mk
> +++ b/package/libtalloc/libtalloc.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -LIBTALLOC_VERSION = 2.3.3
> +LIBTALLOC_VERSION = 2.3.4
>  LIBTALLOC_SOURCE = talloc-$(LIBTALLOC_VERSION).tar.gz
>  LIBTALLOC_SITE = https://www.samba.org/ftp/talloc
>  LIBTALLOC_LICENSE = LGPL-3.0+
> @@ -40,6 +40,9 @@ else
>  LIBTALLOC_CONF_OPTS += --disable-python
>  endif
>  
> +LIBTALLOC_CONF_ENV += PYTHONHASHSEED=1
> +LIBTALLOC_MAKE_ENV += PYTHONHASHSEED=1

I've added a little blurb just above that, moved it earlier in the file,
(and thus made them simple assignments), fixed the typo in the commit
log, and applied to master, thanks.

Regards,
Yann E. MORIN.

>  LIBTALLOC_WAF = ./buildtools/bin/waf
>  
>  # like samba4, libtalloc uses the waf build system which requires a
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-07-24 14:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-24 14:26 [Buildroot] [PATCH V3] package/libtallc: bump version to 2.3.4 David GOUARIN
2022-07-24 14:58 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220724145846.GW2641@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=david.gouarin@thalesgroup.com \
    --cc=dgouarin@gmail.com \
    --cc=romain.naour@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.