All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Aleksandr Makarov <aleksandr.o.makarov@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 1/2] package/libest: auto-select safeclib to avoid use of bundled copy of library
Date: Sun, 24 Jul 2022 17:11:39 +0200	[thread overview]
Message-ID: <20220724151139.GX2641@scaer> (raw)
In-Reply-To: <20220724144318.653289-1-aleksandr.o.makarov@gmail.com>

Aleksandr, All,

On 2022-07-24 17:43 +0300, Aleksandr Makarov spake thusly:
> Support for libsafec can not be completely disabled - currently,
> --disable-safec does not exactly allow for compiling libest on
> systems without libsafec, but instead just uses bundled copy of
> library from safe_c_stub/
> 
> To avoid that, do automatically select the full-featured safeclib
> package and always use --with-system-libsafec
> 
> Signed-off-by: Aleksandr Makarov <aleksandr.o.makarov@gmail.com>

Thanks for the fast respin. Series of two patches applied to master,
thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libest/Config.in |  1 +
>  package/libest/libest.mk | 14 +++++---------
>  2 files changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/package/libest/Config.in b/package/libest/Config.in
> index 6abe9d2848..bd5f40afae 100644
> --- a/package/libest/Config.in
> +++ b/package/libest/Config.in
> @@ -7,6 +7,7 @@ config BR2_PACKAGE_LIBEST
>  	select BR2_PACKAGE_LIBEXECINFO if !BR2_TOOLCHAIN_USES_GLIBC
>  	select BR2_PACKAGE_OPENSSL
>  	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
> +	select BR2_PACKAGE_SAFECLIB
>  	help
>  	  libest is a C implementation of RFC 7030 (Enrollment over
>  	  Secure Transport).
> diff --git a/package/libest/libest.mk b/package/libest/libest.mk
> index d9f3cf87bc..0dd3e7d0e4 100644
> --- a/package/libest/libest.mk
> +++ b/package/libest/libest.mk
> @@ -12,14 +12,17 @@ LIBEST_LICENSE = BSD-3-Clause, MIT, W3C
>  LIBEST_LICENSE_FILES = LICENSE
>  LIBEST_INSTALL_STAGING = YES
>  LIBEST_AUTORECONF = YES
> -LIBEST_DEPENDENCIES = openssl host-pkgconf
> +LIBEST_DEPENDENCIES = openssl host-pkgconf safeclib
>  # libcoap support is explicitly disabled because it breaks the build
> +# libsafec support is explicitly enabled because we want to avoid
> +# possible hidden use of bundled copy of library.
>  LIBEST_CONF_OPTS = \
>  	--with-ssl-dir=$(STAGING_DIR)/usr \
>  	$(if $(BR2_TOOLCHAIN_HAS_THREADS),--enable-pthreads,--disable-pthreads) \
>  	$(if $(BR2_PACKAGE_LIBEST_BRSKI),--enable-brski,--disable-brski) \
>  	--disable-examples \
> -	--without-libcoap-dir
> +	--without-libcoap-dir \
> +	--with-system-libsafec
>  
>  ifeq ($(BR2_PACKAGE_LIBEXECINFO),y)
>  LIBEST_DEPENDENCIES += libexecinfo
> @@ -55,13 +58,6 @@ else
>  LIBEST_CONF_OPTS += --without-uriparser-dir
>  endif
>  
> -ifeq ($(BR2_PACKAGE_SAFECLIB),y)
> -LIBEST_CONF_OPTS += --with-system-libsafec
> -LIBEST_DEPENDENCIES += safeclib
> -else
> -LIBEST_CONF_OPTS += --without-system-libsafec
> -endif
> -
>  define LIBEST_INSTALL_PC
>  	$(INSTALL) -c -m 0644 $(LIBEST_PKGDIR)/libest.pc \
>  		$(STAGING_DIR)/usr/lib/pkgconfig/libest.pc
> -- 
> 2.36.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-07-24 15:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-24 14:43 [Buildroot] [PATCH v3 1/2] package/libest: auto-select safeclib to avoid use of bundled copy of library Aleksandr Makarov
2022-07-24 14:43 ` [Buildroot] [PATCH v3 2/2] package/libest: bump version to current HEAD Aleksandr Makarov
2022-07-24 15:11 ` Yann E. MORIN [this message]
2022-08-17  5:48 ` [Buildroot] [PATCH v3 1/2] package/libest: auto-select safeclib to avoid use of bundled copy of library Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220724151139.GX2641@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=aleksandr.o.makarov@gmail.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.