From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Nicolas Tran <nicolas.tran@smile.fr>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Romain Naour <romain.naour@smile.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/hyperfine: new package
Date: Mon, 25 Jul 2022 08:36:38 +0200 [thread overview]
Message-ID: <20220725083638.6f14624a@windsurf> (raw)
In-Reply-To: <20220519082800.926607-1-nicolas.tran@smile.fr>
Hello,
On Thu, 19 May 2022 10:28:00 +0200
Nicolas Tran <nicolas.tran@smile.fr> wrote:
> hyperfine is a benchmark tool written in Rust. It evaluates
> execution time of a command passed in arguments and make
> a relative comparison if multiple arguments are used at the
> same time.
> It can be convinient for purposes of Rust-written systems as
> it runs in a stable version of Rust.
>
> The package has been checked with correct formatting and
> without typos:
> ./utils/check-package package/hyperfine/*
>
> A CI test was run on gitlab.com to verify toolchain compatibilities.
>
> Signed-off-by: Nicolas Tran <nicolas.tran@smile.fr>
> ---
> test-pkg config:
> BR2_PACKAGE_HYPERFINE=y
> ---
> package/Config.in | 1 +
> package/hyperfine/Config.in | 11 +++++++++++
> package/hyperfine/hyperfine.hash | 4 ++++
> package/hyperfine/hyperfine.mk | 12 ++++++++++++
> 4 files changed, 28 insertions(+)
> create mode 100644 package/hyperfine/Config.in
> create mode 100644 package/hyperfine/hyperfine.hash
> create mode 100644 package/hyperfine/hyperfine.mk
Thanks a lot, I've applied your patch, after fixing two minor issues:
- An entry in the DEVELOPERS file was missing, so I've added it
- There were some trailing white space in Config.in, which were
reported by check-package, so I was surprised to read in your commit
log that you had no check-package warning. Anyway, I fixed this up
as well.
Thanks for your contribution!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-25 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 8:28 [Buildroot] [PATCH 1/1] package/hyperfine: new package Nicolas Tran
2022-05-23 10:00 ` Romain Naour
2022-07-25 6:36 ` Thomas Petazzoni via buildroot [this message]
2022-07-25 9:25 ` Nicolas TRAN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725083638.6f14624a@windsurf \
--to=buildroot@buildroot.org \
--cc=eric.le.bihan.dev@free.fr \
--cc=nicolas.tran@smile.fr \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.