All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Christian Stewart <christian@paral.in>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4 1/1] package/runc: add host package
Date: Mon, 25 Jul 2022 10:38:55 +0200	[thread overview]
Message-ID: <20220725083855.GA3168@scaer> (raw)
In-Reply-To: <20220725002414.704892-1-christian@paral.in>

Christian, All,

On 2022-07-24 17:24 -0700, Christian Stewart spake thusly:
> Adds support for building runc as a host package.
> 
> The bin name and gomod have to be specified as the pkg-golang infrastructure
> assumes the bin name will be "host-runc" on default.

Is that still true, even after 8539378771f (package/pkg-golang: default
to rawname to install binaries) ?

Regards,
Yann E. MORIN.

> Signed-off-by: Christian Stewart <christian@paral.in>
> 
> ---
> 
> changes v3 -> v4:
> 
>  - drop unnecessary GOMOD line
>  - remove seccomp and apparmor tags for host package
>  - thanks Thomas for the review.
> 
> Signed-off-by: Christian Stewart <christian@paral.in>
> ---
>  package/Config.in.host      | 1 +
>  package/runc/Config.in.host | 8 ++++++++
>  package/runc/runc.mk        | 6 ++++++
>  3 files changed, 15 insertions(+)
>  create mode 100644 package/runc/Config.in.host
> 
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 71f2a9311c..8078a8304d 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -82,6 +82,7 @@ menu "Host utilities"
>  	source "package/raspberrypi-usbboot/Config.in.host"
>  	source "package/rauc/Config.in.host"
>  	source "package/riscv-isa-sim/Config.in.host"
> +	source "package/runc/Config.in.host"
>  	source "package/rustc/Config.in.host"
>  	source "package/s6-rc/Config.in.host"
>  	source "package/sam-ba/Config.in.host"
> diff --git a/package/runc/Config.in.host b/package/runc/Config.in.host
> new file mode 100644
> index 0000000000..ce0dd518a6
> --- /dev/null
> +++ b/package/runc/Config.in.host
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_HOST_RUNC
> +	bool "host runc"
> +	depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS
> +	help
> +	  runC is a CLI tool for spawning and running containers
> +	  according to the OCP specification.
> +
> +	  https://github.com/opencontainers/runc
> diff --git a/package/runc/runc.mk b/package/runc/runc.mk
> index 5faa8b683d..8ccff13a3e 100644
> --- a/package/runc/runc.mk
> +++ b/package/runc/runc.mk
> @@ -23,4 +23,10 @@ RUNC_TAGS += seccomp
>  RUNC_DEPENDENCIES += libseccomp host-pkgconf
>  endif
>  
> +HOST_RUNC_BIN_NAME = runc
> +HOST_RUNC_LDFLAGS = $(RUNC_LDFLAGS)
> +HOST_RUNC_TAGS = cgo static_build
> +HOST_RUNC_INSTALL_BINS = $(HOST_RUNC_BIN_NAME)
> +
>  $(eval $(golang-package))
> +$(eval $(host-golang-package))
> -- 
> 2.35.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-07-25  8:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25  0:24 [Buildroot] [PATCH v4 1/1] package/runc: add host package Christian Stewart via buildroot
2022-07-25  7:33 ` Christian Stewart via buildroot
2022-07-25  8:38 ` Yann E. MORIN [this message]
2022-07-25  9:37 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220725083855.GA3168@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=christian@paral.in \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.