From: Stephen Hemminger <stephen@networkplumber.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Jiri Pirko <jiri@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
David Ahern <dsahern@kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: [iproute2-next v3 3/3] devlink: add dry run attribute support to devlink flash
Date: Mon, 25 Jul 2022 14:13:14 -0700 [thread overview]
Message-ID: <20220725141314.01771885@hermes.local> (raw)
In-Reply-To: <20220725205650.4018731-4-jacob.e.keller@intel.com>
On Mon, 25 Jul 2022 13:56:50 -0700
Jacob Keller <jacob.e.keller@intel.com> wrote:
> To avoid potential issues, only allow the attribute to be added to
> commands when the kernel recognizes it. This is important because some
> commands do not perform strict validation. If we were to add the
> attribute without this check, an old kernel may silently accept the
> command and perform an update even when dry_run was requested.
Sigh. Looks like the old kernels are buggy. The workaround in userspace
is also likely to be source of bugs.
next prev parent reply other threads:[~2022-07-25 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 20:56 [iproute2-next v3 0/3] devlink: support dry run attribute for flash update Jacob Keller
2022-07-25 20:56 ` [iproute2-next v3 1/3] update <linux/devlink.h> UAPI header Jacob Keller
2022-07-25 20:56 ` [iproute2-next v3 2/3] mnlg: add function to get CTRL_ATTR_MAXATTR value Jacob Keller
2022-07-26 7:46 ` Jiri Pirko
2022-08-26 0:40 ` Keller, Jacob E
2022-08-26 8:38 ` Jiri Pirko
2022-07-25 20:56 ` [iproute2-next v3 3/3] devlink: add dry run attribute support to devlink flash Jacob Keller
2022-07-25 21:13 ` Stephen Hemminger [this message]
2022-07-25 21:19 ` Keller, Jacob E
2022-07-25 21:27 ` Keller, Jacob E
2022-07-26 7:47 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725141314.01771885@hermes.local \
--to=stephen@networkplumber.org \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.