Re: [PATCH mptcp-next v7 06/13] bpf: Add bpf_mptcp_sched_kfunc_set

[Geliang Tang <geliang.tang@suse.com>]

On Mon, Jul 25, 2022 at 09:56:10AM +0200, Matthieu Baerts wrote:
> Hi Geliang, Mat,
> 
> On 02/06/2022 06:53, Geliang Tang wrote:
> > This patch adds a new struct btf_kfunc_id_set for MPTCP scheduler. Add
> > mptcp_subflow_set_scheduled() helper into this id_set, and register it
> > in bpf_mptcp_sched_kfunc_init() to make sure this helper can be accessed
> > from the BPF context.
> > 
> > Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> > ---
> >  net/mptcp/bpf.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/net/mptcp/bpf.c b/net/mptcp/bpf.c
> > index 0529e70d53b1..e86dff4272d5 100644
> > --- a/net/mptcp/bpf.c
> > +++ b/net/mptcp/bpf.c
> > @@ -161,6 +161,22 @@ struct bpf_struct_ops bpf_mptcp_sched_ops = {
> >  	.init		= bpf_mptcp_sched_init,
> >  	.name		= "mptcp_sched_ops",
> >  };
> > +
> > +BTF_SET_START(bpf_mptcp_sched_kfunc_ids)
> > +BTF_ID(func, mptcp_subflow_set_scheduled)
> > +BTF_SET_END(bpf_mptcp_sched_kfunc_ids)
> > +
> > +static const struct btf_kfunc_id_set bpf_mptcp_sched_kfunc_set = {
> > +	.owner		= THIS_MODULE,
> > +	.check_set	= &bpf_mptcp_sched_kfunc_ids,
> 
> FYI, I had to change this commit in our tree, see 556f2a5949dd ("mptcp:
> bpf: fix compilation error").
> 
> In short, I had to adapt the code due to modification on BPF side,
> related to commit a4703e318432 ("bpf: Switch to new kfunc flags
> infrastructure"). I hope I did the proper modification.

Thanks for this modification, Matt, it looks good to me.

-Geliang

> 
> Cheers,
> Matt
> -- 
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net