From: "Michael S. Tsirkin" <mst@redhat.com>
To: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com,
hreitz@redhat.com, stefanha@redhat.com, den@virtuozzo.com
Subject: Re: [RFC patch 0/1] block: vhost-blk backend
Date: Tue, 26 Jul 2022 09:51:15 -0400 [thread overview]
Message-ID: <20220726094740-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220725205527.313973-1-andrey.zhadchenko@virtuozzo.com>
On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote:
> Although QEMU virtio-blk is quite fast, there is still some room for
> improvements. Disk latency can be reduced if we handle virito-blk requests
> in host kernel so we avoid a lot of syscalls and context switches.
>
> The biggest disadvantage of this vhost-blk flavor is raw format.
> Luckily Kirill Thai proposed device mapper driver for QCOW2 format to attach
> files as block devices: https://www.spinics.net/lists/kernel/msg4292965.html
That one seems stalled. Do you plan to work on that too?
> Also by using kernel modules we can bypass iothread limitation and finaly scale
> block requests with cpus for high-performance devices. This is planned to be
> implemented in next version.
>
> Linux kernel module part:
> https://lore.kernel.org/kvm/20220725202753.298725-1-andrey.zhadchenko@virtuozzo.com/
>
> test setups and results:
> fio --direct=1 --rw=randread --bs=4k --ioengine=libaio --iodepth=128
> QEMU drive options: cache=none
> filesystem: xfs
>
> SSD:
> | randread, IOPS | randwrite, IOPS |
> Host | 95.8k | 85.3k |
> QEMU virtio | 57.5k | 79.4k |
> QEMU vhost-blk | 95.6k | 84.3k |
>
> RAMDISK (vq == vcpu):
> | randread, IOPS | randwrite, IOPS |
> virtio, 1vcpu | 123k | 129k |
> virtio, 2vcpu | 253k (??) | 250k (??) |
> virtio, 4vcpu | 158k | 154k |
> vhost-blk, 1vcpu | 110k | 113k |
> vhost-blk, 2vcpu | 247k | 252k |
> vhost-blk, 4vcpu | 576k | 567k |
>
> Andrey Zhadchenko (1):
> block: add vhost-blk backend
From vhost/virtio side the patchset looks ok. But let's see what do
block devs think about it.
> configure | 13 ++
> hw/block/Kconfig | 5 +
> hw/block/meson.build | 1 +
> hw/block/vhost-blk.c | 395 ++++++++++++++++++++++++++++++++++
> hw/virtio/meson.build | 1 +
> hw/virtio/vhost-blk-pci.c | 102 +++++++++
> include/hw/virtio/vhost-blk.h | 44 ++++
> linux-headers/linux/vhost.h | 3 +
> 8 files changed, 564 insertions(+)
> create mode 100644 hw/block/vhost-blk.c
> create mode 100644 hw/virtio/vhost-blk-pci.c
> create mode 100644 include/hw/virtio/vhost-blk.h
>
> --
> 2.31.1
next prev parent reply other threads:[~2022-07-26 14:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 20:55 [RFC patch 0/1] block: vhost-blk backend Andrey Zhadchenko via
2022-07-25 20:55 ` [RFC PATCH 1/1] block: add " Andrey Zhadchenko via
2022-10-04 18:45 ` Stefan Hajnoczi
2022-10-05 13:06 ` Andrey Zhadchenko
2022-10-05 15:50 ` Stefan Hajnoczi
2022-07-26 13:51 ` Michael S. Tsirkin [this message]
2022-07-26 14:15 ` [RFC patch 0/1] block: " Denis V. Lunev
2022-07-27 13:06 ` Stefano Garzarella
2022-07-28 5:28 ` Andrey Zhadchenko
2022-07-28 15:40 ` Stefano Garzarella
2022-10-04 18:13 ` Stefan Hajnoczi
2022-10-05 9:14 ` Andrey Zhadchenko
2022-10-05 15:18 ` Stefan Hajnoczi
2022-10-04 18:26 ` Stefan Hajnoczi
2022-10-05 10:28 ` Andrey Zhadchenko
2022-10-05 15:30 ` Stefan Hajnoczi
2022-10-04 19:00 ` Stefan Hajnoczi
2022-10-05 11:50 ` Andrey Zhadchenko
2022-10-05 15:40 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726094740-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.