Re: [Buildroot] [PATCH 6/7] package/avocado: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello José,

On Fri, 10 Dec 2021 16:12:08 +0200
José Pekkarinen <jose.pekkarinen@unikie.com> wrote:

> This patch adds a basic package for
> avocado framework.
> 
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>

I have finally applied this package, but with a number of changes. See below.

> diff --git a/package/avocado/Config.in b/package/avocado/Config.in
> new file mode 100644
> index 0000000000..402a639969
> --- /dev/null
> +++ b/package/avocado/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_AVOCADO
> +	bool "avocado"
> +	depends on !BR2_STATIC_LIBS # dlopen()
> +	select BR2_PACKAGE_LIBFFI
> +	select BR2_PACKAGE_PYTHON3

Since you select Python, you need to inherit all its dependencies:

+       depends on BR2_USE_WCHAR # python3
+       depends on BR2_USE_MMU # python3
+       depends on BR2_TOOLCHAIN_HAS_THREADS # python3
+       depends on !BR2_STATIC_LIBS # python3

Also, you were missing a number of modules part of the Python standard
library, and one external module, so I had to add:

+       select BR2_PACKAGE_PYTHON3_BZIP2
+       select BR2_PACKAGE_PYTHON3_PYEXPAT
+       select BR2_PACKAGE_PYTHON3_SQLITE
+       select BR2_PACKAGE_PYTHON3_XZ
+       select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime, pkg_resources

for Avocado to work properly.

> +	help
> +	  Avocado is an automated testing suite containing
> +	  tests for various subsystems.
> +
> +	  https://avocado-framework.readthedocs.io/
> +
> +comment "avocado needs a toolchain with dynamic library support"
> +	depends on BR2_STATIC_LIBS

You had forgotten BR2_USE_MMU here, and this had to be updated
according to the dependencies:

+comment "avocado needs a toolchain w/ wchar, threads, dynamic library"
+       depends on BR2_USE_MMU
+       depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS

> diff --git a/package/avocado/avocado.hash b/package/avocado/avocado.hash
> new file mode 100644
> index 0000000000..257ee5d5ae
> --- /dev/null
> +++ b/package/avocado/avocado.hash
> @@ -0,0 +1,4 @@
> +# From https://github.com/avocado-framework/avocado/archive/refs/tags

This page does not exist.

> +sha256  b7a35552cd0f0d8e4b3aa4bb7009ce9e474a40c1cd111698ed03da90d71a2f4b  93.0.tar.gz
> +# Locally computed
> +sha256  680ce56e9c4043826f0f1420935d2453ea3ddacd1582cb6f1cef26c1077fcc93  LICENSE
> diff --git a/package/avocado/avocado.mk b/package/avocado/avocado.mk
> new file mode 100644
> index 0000000000..8474fa48c8
> --- /dev/null
> +++ b/package/avocado/avocado.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# avocado-framework
> +#
> +################################################################################
> +
> +AVOCADO_VERSION = 93.0

I have updated to version 98.0

> +AVOCADO_SOURCE = $(AVOCADO_VERSION).tar.gz
> +AVOCADO_SITE = https://github.com/avocado-framework/avocado/archive/refs/tags

And here replaced both of those lines by:

+AVOCADO_SITE = $(call github,avocado-framework,avocado,$(AVOCADO_VERSION))

> +AVOCADO_SETUP_TYPE = setuptools
> +AVOCADO_LICENSE = Apache-2.0

And now I realize this is wrong... the license is not Apache-2.0, but
GPL-2.0. I forgot to check this, I will commit a follow-up patch.

Another thing I did is add a runtime test for Avocado, in
support/testing/tests/package/test_avocado.py

Thanks for your contribution!

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot