From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvmet: avoid unnecessary fsync and flush bio
Date: Tue, 26 Jul 2022 13:33:33 +0200 [thread overview]
Message-ID: <20220726113333.GA2867@lst.de> (raw)
In-Reply-To: <1658730498-11857-1-git-send-email-kanie@linux.alibaba.com>
On Mon, Jul 25, 2022 at 02:28:18PM +0800, Guixin Liu wrote:
> u16 nvmet_file_flush(struct nvmet_req *req)
> {
> - return errno_to_nvme_status(req, vfs_fsync(req->ns->file, 1));
> + if (req->ns->buffered_io)
> + return errno_to_nvme_status(req, vfs_fsync(req->ns->file, 1));
> + return NVME_SC_SUCCESS;
This is broken. Even direct I/O needs an fsync to commit metadata
changes.
next prev parent reply other threads:[~2022-07-26 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 6:28 [PATCH v2] nvmet: avoid unnecessary fsync and flush bio Guixin Liu
2022-07-26 6:17 ` Chaitanya Kulkarni
2022-07-26 11:33 ` Christoph Hellwig [this message]
2022-07-27 8:03 ` Guixin Liu
2022-07-27 8:08 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726113333.GA2867@lst.de \
--to=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.