From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_queue: only allow supported families
Date: Tue, 26 Jul 2022 19:50:58 +0200 [thread overview]
Message-ID: <20220726175058.GC7785@breakpoint.cc> (raw)
In-Reply-To: <Yt/sKPSv8K1gD1oX@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > + case NFPROTO_INET:
>
> there is a special inet/ingress, maybe it requires a sanity check here?
Right, this patch allows 'inet+ingress', whoch doesn't work either.
> > static int nft_queue_init(const struct nft_ctx *ctx,
> > const struct nft_expr *expr,
> > const struct nlattr * const tb[])
> > @@ -82,6 +100,9 @@ static int nft_queue_init(const struct nft_ctx *ctx,
>
> Maybe .validate is a better place for this?
Yep, I sent a v2.
prev parent reply other threads:[~2022-07-26 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 10:43 [PATCH nf] netfilter: nft_queue: only allow supported families Florian Westphal
2022-07-26 13:29 ` Pablo Neira Ayuso
2022-07-26 17:50 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726175058.GC7785@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.