All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Lang Daniel via buildroot <buildroot@buildroot.org>
Cc: Lang Daniel <d.lang@abatec.at>
Subject: Re: [Buildroot] [PATCH 1/1] toolchain: handle white spaces in sysroot path
Date: Tue, 26 Jul 2022 23:31:27 +0200	[thread overview]
Message-ID: <20220726233127.1ceaeee9@windsurf> (raw)
In-Reply-To: <VI1P190MB0493383AF3C4D4BA08C5CDC09FCE9@VI1P190MB0493.EURP190.PROD.OUTLOOK.COM>

Hello Daniel,

On Tue, 17 May 2022 10:32:12 +0000
Lang Daniel via buildroot <buildroot@buildroot.org> wrote:

> When changing permissions on all directories in the staging directory,
> after copying sysroot, paths that contain spaces break the call to chmod.
> 
> With -print0 for find and -0 for xargs white spaces are correctly interpreted.
> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> ---
> Backport to: 2022.02.x
> ---
>  toolchain/helpers.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

To be honest, I am not sure this is sufficient to use a sysroot path
with white-space, and it's a scenario that we are not testing, so it's
likely to break in the future. But your patch doesn't hurt, so I've
applied it anyway.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-07-26 21:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 10:32 [Buildroot] [PATCH 1/1] toolchain: handle white spaces in sysroot path Lang Daniel via buildroot
2022-07-26 21:31 ` Thomas Petazzoni via buildroot [this message]
2022-07-27  6:36   ` Lang Daniel via buildroot
2022-07-27  7:13     ` Thomas Petazzoni via buildroot
2022-07-27  8:47       ` Arnout Vandecappelle
2022-08-29  6:22 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220726233127.1ceaeee9@windsurf \
    --to=buildroot@buildroot.org \
    --cc=d.lang@abatec.at \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.