From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: TIAN Yuanhao <tianyuanhao3@163.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/pkg-utils: refine KCONFIG_MUNGE_DOT_CONFIG
Date: Wed, 27 Jul 2022 17:30:25 +0200 [thread overview]
Message-ID: <20220727153025.GB1134587@scaer> (raw)
In-Reply-To: <20220727140822.355859-1-tianyuanhao3@163.com>
Yuanhao, All,
On 2022-07-27 07:08 -0700, TIAN Yuanhao spake thusly:
> Given a .config with:
>
> FOO="1234"
> BAR="$(FOO)"
>
> and then:
>
> $(call KCONFIG_SET_OPT,FOO,azerty)
>
> would yield a .config with just:
>
> FOO="azerty"
>
> because \<FOO\> would match the assignment to BAR.
>
> Reported-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
>
> I found something similar in uClibc-ng:
>
> TARGET_ARCH="x86_64"
> RUNTIME_PREFIX="/usr/$(TARGET_ARCH)-linux-uclibc/"
> ---
> package/pkg-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index e5dba2add0..6ece27baa2 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -22,7 +22,7 @@ KCONFIG_DOT_CONFIG = $(strip \
>
> # KCONFIG_MUNGE_DOT_CONFIG (option, newline [, file])
> define KCONFIG_MUNGE_DOT_CONFIG
> - $(SED) "/\\<$(strip $(1))\\>/d" $(call KCONFIG_DOT_CONFIG,$(3)) && \
> + $(SED) '/^\(# \)\?$(strip $(1))\>/d' $(call KCONFIG_DOT_CONFIG,$(3)) && \
> echo '$(strip $(2))' >> $(call KCONFIG_DOT_CONFIG,$(3))
> endef
>
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-27 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 14:08 [Buildroot] [PATCH] package/pkg-utils: refine KCONFIG_MUNGE_DOT_CONFIG TIAN Yuanhao
2022-07-27 15:30 ` Yann E. MORIN [this message]
2022-08-30 16:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727153025.GB1134587@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=tianyuanhao3@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.