From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Romain Naour <romain.naour@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH] toolchain/toolchain-buildroot, package/glibc: sync glibc dependency comments
Date: Wed, 27 Jul 2022 16:58:31 +0200 [thread overview]
Message-ID: <20220727165831.56080dca@windsurf> (raw)
In-Reply-To: <20220726134436.2014032-1-thomas.petazzoni@bootlin.com>
On Tue, 26 Jul 2022 15:44:35 +0200
Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:
> In commit fd839aeb7f40596e60bc53a96b7a65892924cc26 ("package/glibc:
> introduce and use BR2_PACKAGE_GLIBC_ARCH_SUPPORTS and
> BR2_PACKAGE_GLIBC_SUPPORTS") we moved the Config.in logic about glibc
> dependencies from toolchain/toolchain-buildroot/Config.in into
> package/glibc/Config.in.
>
> Unfortunately, it is not possible to move the Config.in comments that
> tell the user, within the choice..endchoice for the C library why
> glibc is not currently selectable, so we had to keep them in
> toolchain/toolchain-buildroot/Config.in.
>
> Turns out that the comments were out of sync with the dependencies,
> and two comments were missing. This commit adds the missing ones, and
> adds a comment in package/glibc/Config.in explaining that we need to
> be careful about updating toolchain/toolchain-buildroot/Config.in as
> well.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/glibc/Config.in | 3 +++
> toolchain/toolchain-buildroot/Config.in | 8 ++++++++
> 2 files changed, 11 insertions(+)
Seems like I was stupid: I mistakenly pushed this patch *before*
submitting it... So well, it's applied. Don't hesitate to let me know
if you see anything wrong with it, of course, and I'll fix it!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-27 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 13:44 [Buildroot] [PATCH] toolchain/toolchain-buildroot, package/glibc: sync glibc dependency comments Thomas Petazzoni via buildroot
2022-07-27 14:58 ` Thomas Petazzoni via buildroot [this message]
2022-08-18 6:16 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727165831.56080dca@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.