From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: ecree@xilinx.com, davem@davemloft.net, pabeni@redhat.com,
linux-net-drivers@amd.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 12/14] sfc: set EF100 VF MAC address through representor
Date: Thu, 28 Jul 2022 09:20:08 -0700 [thread overview]
Message-ID: <20220728092008.2117846e@kernel.org> (raw)
In-Reply-To: <67138e0a-9b89-c99a-6eb1-b5bdd316196f@gmail.com>
On Thu, 28 Jul 2022 16:47:36 +0100 Edward Cree wrote:
> On 28/07/2022 04:10, Jakub Kicinski wrote:
> > On Wed, 27 Jul 2022 18:46:02 +0100 ecree@xilinx.com wrote:
> >> When setting the VF rep's MAC address, set the provisioned MAC address
> >> for the VF through MC_CMD_SET_CLIENT_MAC_ADDRESSES.
> >
> > Wait.. hm? The VF rep is not the VF. It's the other side of the wire.
> > Are you passing the VF rep's MAC on the VF? Ethernet packets between
> > the hypervisor and the VF would have the same SA and DA.
>
> Yes (but only if there's an IP stack on the repr; I think it's fine if
> the repr is plugged straight into a bridge so any ARP picks up a
> different DA?).
> I thought that was weird but I also thought that was 'how it's done'
> with reps — properties of the VF are set by applying them to the rep.
> Is there some other way to configure VF MAC? (Are we supposed to still
> be using the legacy SR-IOV interface, .ndo_set_vf_mac()? I thought
> that was deprecated in favour of more switchdev-flavoured stuff…)
It's set thru
devlink port function set DEV/PORT_INDEX hw_addr ADDR
"port functions" is a weird object representing something
in Mellanox FW. Hopefully it makes more sense to you than
it does to me.
next prev parent reply other threads:[~2022-07-28 16:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 17:45 [PATCH net-next v2 00/14] sfc: VF representors for EF100 - RX side ecree
2022-07-27 17:45 ` [PATCH net-next v2 01/14] sfc: plumb ef100 representor stats ecree
2022-07-27 17:45 ` [PATCH net-next v2 02/14] sfc: ef100 representor RX NAPI poll ecree
2022-07-27 17:45 ` [PATCH net-next v2 03/14] sfc: ef100 representor RX top half ecree
2022-07-27 17:45 ` [PATCH net-next v2 04/14] sfc: determine wire m-port at EF100 PF probe time ecree
2022-07-27 17:45 ` [PATCH net-next v2 05/14] sfc: check ef100 RX packets are from the wire ecree
2022-07-27 17:45 ` [PATCH net-next v2 06/14] sfc: receive packets from EF100 VFs into representors ecree
2022-07-27 17:45 ` [PATCH net-next v2 07/14] sfc: insert default MAE rules to connect VFs to representors ecree
2022-07-27 17:45 ` [PATCH net-next v2 08/14] sfc: move table locking into filter_table_{probe,remove} methods ecree
2022-07-27 17:45 ` [PATCH net-next v2 09/14] sfc: use a dynamic m-port for representor RX and set it promisc ecree
2022-07-27 17:46 ` [PATCH net-next v2 10/14] sfc: look up VF's client ID when creating representor ecree
2022-07-27 17:46 ` [PATCH net-next v2 11/14] sfc: fetch existing assigned MAC address from FW when creating VF rep ecree
2022-07-27 17:46 ` [PATCH net-next v2 12/14] sfc: set EF100 VF MAC address through representor ecree
2022-07-28 3:10 ` Jakub Kicinski
2022-07-28 15:47 ` Edward Cree
2022-07-28 16:20 ` Jakub Kicinski [this message]
2022-07-28 18:12 ` Edward Cree
2022-07-28 18:32 ` Jakub Kicinski
2022-07-28 18:54 ` Edward Cree
2022-07-28 19:27 ` Jakub Kicinski
2022-07-28 20:23 ` Edward Cree
2022-07-29 1:45 ` Jakub Kicinski
2022-07-29 15:17 ` Edward Cree
2022-07-27 17:46 ` [PATCH net-next v2 13/14] sfc: get provisioned MAC address on EF100 VF probe ecree
2022-07-27 17:46 ` [PATCH net-next v2 14/14] sfc: implement ethtool get/set RX ring size for EF100 reps ecree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728092008.2117846e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=ecree@xilinx.com \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.