From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2FEFC19F2C for ; Thu, 28 Jul 2022 12:01:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 13D1583D01; Thu, 28 Jul 2022 14:01:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="fSyNbEYr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E67D383F9F; Thu, 28 Jul 2022 14:01:51 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E5CAE83F36 for ; Thu, 28 Jul 2022 14:01:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id u12so947758qtk.0 for ; Thu, 28 Jul 2022 05:01:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eY0MzzyzS9kPxge+dl8SPmHDa2frPF7FuDk6sknsh9w=; b=fSyNbEYr9XmLSnc00gEfHNbrDRZe2gnTtq/w1jk4o080xscZbtDOwDEvSNbEXq2WcH UnNMc3BF8dHhvjg9HR7hNwRfwqVBLxwzAUFnT3ytFy2csMdSiFXjLfYjGyd2VNsZ6lR7 u8h/W6psaGmM2D8G5wzAlHT0vmOxPrtnS81BQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eY0MzzyzS9kPxge+dl8SPmHDa2frPF7FuDk6sknsh9w=; b=VDF/ggTi3xZaCQhUXHGs2+grx3NeOStWuCsB7yvU5mnBjo6mOFOD25tVp/gkrPDgb9 GU7a8fLrQfb9jUimjo6EGgmkquMvDxEugXg8H5hr5CLdHYT/aeGzrEaYS74sL/PeJrGJ xm9rI7Fyo1AmbtSrHRuAZFMF7QclsIQX76yijOK/CSSgS4Wyirusbl5eBpUCN5pDiZFC W96MtMDBIfM8o1ymeH6Tg9dewRJ2AVajR7jlN5HM1eMkaqRgAquHE/hADz8+YtfEGU2b f/dN1qkWb6zCqqWqqyZynXa963XN9QaPjjhyCTjJSwoLSp4zMuthT5ZIZUN7tLCriIJ3 hrcA== X-Gm-Message-State: AJIora/Fo+iG+W1qzkNZgkn0zlAYAsypa/KQrKNX3jk8TljHzJy5RrNU 7U4qC2hbH4DTw6y9/cSMUQMmog== X-Google-Smtp-Source: AGRyM1tlWeat1a40pRbWey9w5xt4Dz/PGNYNIrmnH+6OeSysEgyvG1lepNxQNj7m5EAhtvzuX8+NMw== X-Received: by 2002:ac8:5f0c:0:b0:31f:44f1:48cc with SMTP id x12-20020ac85f0c000000b0031f44f148ccmr9059600qta.640.1659009707590; Thu, 28 Jul 2022 05:01:47 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id dt45-20020a05620a47ad00b006b46a78bc0fsm393456qkb.118.2022.07.28.05.01.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 05:01:46 -0700 (PDT) Date: Thu, 28 Jul 2022 08:01:44 -0400 From: Tom Rini To: Fabio Estevam Cc: Josua Mayer , U-Boot-Denx , Yazan Shhady , Stefano Babic , "NXP i.MX U-Boot Team" , Baruch Siach , Marcel Ziswiler Subject: Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree Message-ID: <20220728120144.GH1146598@bill-the-cat> References: <20220728070540.28554-1-josua@solid-run.com> <20220728114154.GG1146598@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JK6HpeQXHbFuA1Bq" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --JK6HpeQXHbFuA1Bq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 28, 2022 at 08:51:01AM -0300, Fabio Estevam wrote: > Hi Tom, >=20 > On Thu, Jul 28, 2022 at 8:41 AM Tom Rini wrote: > > > > On Thu, Jul 28, 2022 at 10:05:40AM +0300, Josua Mayer wrote: > > > > > The i.MX6 Cubox-i and HummingBoards can have different PHYs at varying > > > addresses. U-Boot needs to auto-detect which phy is actually present, > > > and at which address it is responding. > > > > > > Auto-detection from multiple phy nodes specified in device-tree does = not > > > currently work correct. As a work-around merge all three possible phys > > > into one node with the special address 0xffffffff which indicates to = the > > > generic phy driver to probe all addresses. > > > Also fixup this fake address before booting Linux, *if* booting with > > > U-Boot's internal dtb. > > > > > > Signed-off-by: Josua Mayer > > > Fixes: d0399a46e7cd > > > > Tested-by: Tom Rini >=20 > It's great that it worked, but if we take the patch as-is, then we > will run into issues again in the future > when a new re-sync is done. Agreed. > I see two alternatives: >=20 > 1. Make the arch/arm/dts/imx6qdl-sr-som.dtsi changes into > arch/arm/dts/imx6qdl-sr-som-u-boot.dtsi, so that the main dtsi can > still be used from Linux. >=20 > 2. Make the same dtsi work for both Linux and U-Boot. >=20 > What do you think? If we can make #2 work that would be the best path forward I hope. --=20 Tom --JK6HpeQXHbFuA1Bq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLiep4ACgkQFHw5/5Y0 tyxz5wv/Xl5DxwKizQ22B8HRD3F/5Zehe/uBMNjvVcipYGcvQ97VkH6saSLfGxJ2 +RN+p5pi6OPGRyvZIZM8jZNEyxbBaLSWJqdfnFZq6Dn7jLkFYJlmBmDfwJnjvZA1 tEedt56r0ZVMsfb3SWbWR77t3VLFZ42+bI5xE5tiNAlgg8vsLxuegDOHCAAFHl0q RUxnZyuotyFjbvh2xy4N2aH6SSAmxYFILvKSPWPhcXW4bdyW5o89U5TmmQLA2yiS sAjueTktGXHdIDefFjsR4ds0omRSBhH6cBuvjap+2qnrLpfgL6wlBiJJ97zZWedY lF0BGCiITTXzyoy28QrSAzO0uXslKFEn+z7agTXMrYG8IDjZC7tn0pP7GwKR90rD sV8R1dqEtzKEETXbMYaHrI2S6//e6IkwGygBuu9rdB1JnEdvzF/jBzFGR/NnobIX tkYUzrrfIfFViDTfkOTpfmC1tRmA17HqfiLrwp5CzpHU9rbPNIu9YvyGRph7I3iz PMuJU4re =ehl3 -----END PGP SIGNATURE----- --JK6HpeQXHbFuA1Bq--