From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: linux-mm@kvack.org, akpm@linux-foundation.org
Cc: Wei Xu <weixugc@google.com>, Huang Ying <ying.huang@intel.com>,
Yang Shi <shy828301@gmail.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Tim C Chen <tim.c.chen@intel.com>,
Michal Hocko <mhocko@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hesham Almatary <hesham.almatary@huawei.com>,
Dave Hansen <dave.hansen@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Alistair Popple <apopple@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
jvgediya.oss@gmail.com,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Subject: [PATCH v12 3/8] mm/demotion: Add hotplug callbacks to handle new numa node onlined
Date: Fri, 29 Jul 2022 11:43:44 +0530 [thread overview]
Message-ID: <20220729061349.968148-4-aneesh.kumar@linux.ibm.com> (raw)
In-Reply-To: <20220729061349.968148-1-aneesh.kumar@linux.ibm.com>
If the new NUMA node onlined doesn't have a abstract distance assigned,
the kernel adds the NUMA node to default memory tier.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
include/linux/memory-tiers.h | 1 +
mm/memory-tiers.c | 83 ++++++++++++++++++++++++++++++++++++
2 files changed, 84 insertions(+)
diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h
index 6fa7b4fe6ac7..eeb4b045e631 100644
--- a/include/linux/memory-tiers.h
+++ b/include/linux/memory-tiers.h
@@ -12,6 +12,7 @@
*/
#define MEMTIER_ADISTANCE_DRAM (1 << (MEMTIER_CHUNK_BITS + 2))
#define MEMTIER_ADISTANCE_PMEM (1 << (MEMTIER_CHUNK_BITS + 3))
+#define MEMTIER_HOTPLUG_PRIO 100
#ifdef CONFIG_NUMA
#include <linux/types.h>
diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
index 83c13f9df245..0a7a79cad2a0 100644
--- a/mm/memory-tiers.c
+++ b/mm/memory-tiers.c
@@ -5,6 +5,7 @@
#include <linux/lockdep.h>
#include <linux/sysfs.h>
#include <linux/kobject.h>
+#include <linux/memory.h>
#include <linux/memory-tiers.h>
struct memory_tier {
@@ -85,6 +86,87 @@ static struct memory_tier *find_create_memory_tier(struct memory_dev_type *memty
return new_memtier;
}
+static struct memory_tier *__node_get_memory_tier(int node)
+{
+ struct memory_dev_type *memtype;
+
+ memtype = node_memory_types[node];
+ if (memtype)
+ return memtype->memtier;
+ return NULL;
+}
+
+static void init_node_memory_tier(int node)
+{
+ struct memory_tier *memtier;
+
+ mutex_lock(&memory_tier_lock);
+
+ memtier = __node_get_memory_tier(node);
+ if (!memtier) {
+ struct memory_dev_type *memtype;
+
+ if (!node_memory_types[node]) {
+ node_memory_types[node] = &default_dram_type;
+ node_set(node, default_dram_type.nodes);
+ }
+ memtype = node_memory_types[node];
+ memtier = find_create_memory_tier(memtype);
+ }
+ mutex_unlock(&memory_tier_lock);
+}
+
+static void destroy_memory_tier(struct memory_tier *memtier)
+{
+ list_del(&memtier->list);
+ kfree(memtier);
+}
+
+static void clear_node_memory_tier(int node)
+{
+ struct memory_tier *current_memtier;
+
+ mutex_lock(&memory_tier_lock);
+ current_memtier = __node_get_memory_tier(node);
+ if (current_memtier) {
+ struct memory_dev_type *memtype;
+
+ memtype = node_memory_types[node];
+ node_clear(node, memtype->nodes);
+ if (nodes_empty(memtype->nodes)) {
+ list_del(&memtype->tier_sibiling);
+ memtype->memtier = NULL;
+ if (list_empty(¤t_memtier->memory_types))
+ destroy_memory_tier(current_memtier);
+ }
+ }
+ mutex_unlock(&memory_tier_lock);
+}
+
+static int __meminit memtier_hotplug_callback(struct notifier_block *self,
+ unsigned long action, void *_arg)
+{
+ struct memory_notify *arg = _arg;
+
+ /*
+ * Only update the node migration order when a node is
+ * changing status, like online->offline.
+ */
+ if (arg->status_change_nid < 0)
+ return notifier_from_errno(0);
+
+ switch (action) {
+ case MEM_OFFLINE:
+ clear_node_memory_tier(arg->status_change_nid);
+ break;
+ case MEM_ONLINE:
+ init_node_memory_tier(arg->status_change_nid);
+ break;
+ }
+
+ return notifier_from_errno(0);
+}
+
static int __init memory_tier_init(void)
{
int node;
@@ -104,6 +186,7 @@ static int __init memory_tier_init(void)
mutex_unlock(&memory_tier_lock);
+ hotplug_memory_notifier(memtier_hotplug_callback, MEMTIER_HOTPLUG_PRIO);
return 0;
}
subsys_initcall(memory_tier_init);
--
2.37.1
next prev parent reply other threads:[~2022-07-29 6:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 6:13 [PATCH v12 0/8] mm/demotion: Memory tiers and demotion Aneesh Kumar K.V
2022-07-29 6:13 ` [PATCH v12 1/8] mm/demotion: Add support for explicit memory tiers Aneesh Kumar K.V
2022-07-31 9:54 ` kernel test robot
2022-08-01 2:37 ` Huang, Ying
2022-08-01 4:47 ` Aneesh Kumar K V
2022-07-29 6:13 ` [PATCH v12 2/8] mm/demotion: Move memory demotion related code Aneesh Kumar K.V
2022-07-29 6:13 ` Aneesh Kumar K.V [this message]
2022-07-29 6:13 ` [PATCH v12 4/8] mm/demotion/dax/kmem: Set node's abstract distance to MEMTIER_ADISTANCE_PMEM Aneesh Kumar K.V
2022-07-29 6:13 ` [PATCH v12 5/8] mm/demotion: Build demotion targets based on explicit memory tiers Aneesh Kumar K.V
2022-07-29 6:13 ` [PATCH v12 6/8] mm/demotion: Add pg_data_t member to track node memory tier details Aneesh Kumar K.V
2022-07-29 6:13 ` [PATCH v12 7/8] mm/demotion: Demote pages according to allocation fallback order Aneesh Kumar K.V
2022-07-29 6:13 ` [PATCH v12 8/8] mm/demotion: Update node_is_toptier to work with memory tiers Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729061349.968148-4-aneesh.kumar@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave@stgolabs.net \
--cc=hannes@cmpxchg.org \
--cc=hesham.almatary@huawei.com \
--cc=jvgediya.oss@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shy828301@gmail.com \
--cc=tim.c.chen@intel.com \
--cc=weixugc@google.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.