From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/libdill: new package
Date: Fri, 29 Jul 2022 10:47:54 +0200 [thread overview]
Message-ID: <20220729104754.2beb327c@windsurf> (raw)
In-Reply-To: <20220728211259.121416-1-angelo@amarulasolutions.com>
Hello Angelo,
On Thu, 28 Jul 2022 23:12:59 +0200
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> Libdill is a C library that makes writing structured concurrent programs
> easy.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
Looks good. A few comments/questions.
> diff --git a/package/libdill/Config.in b/package/libdill/Config.in
> new file mode 100644
> index 0000000000..0e6757b809
> --- /dev/null
> +++ b/package/libdill/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBDILL
> + bool "libdill"
No dependencies at all? Tested with test-pkg?
> diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
> new file mode 100644
> index 0000000000..822f07b939
> --- /dev/null
> +++ b/package/libdill/libdill.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# libdill
> +#
> +################################################################################
> +
> +LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
> +LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
> +LIBDILL_LICENSE = MIT
> +LIBDILL_LICENSE_FILES = COPYING
> +LIBDILL_CPE_ID_VENDOR = libdill
> +LIBDILL_CPE_ID_PRODUCT = libdill
Could you add a link in the commit log that shows you have verified these?
> +LIBDILL_INSTALL_STAGING = YES
> +# Fetched from Github, with no configure script
> +LIBDILL_AUTORECONF = YES
> +
> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
> +LIBDILL_CONF_OPTS += --disable-threads
> +endif
> +
> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +LIBDILL_DEPENDENCIES = openssl
> +LIBDILL_CONF_OPTS += --enable-tls
No "else" clause to explicitly disable?
> +endif
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-29 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 21:12 [Buildroot] [PATCH v2] package/libdill: new package Angelo Compagnucci
2022-07-29 8:47 ` Thomas Petazzoni via buildroot [this message]
2022-07-29 19:00 ` Arnout Vandecappelle
2022-07-29 22:04 ` Angelo Compagnucci
2022-07-29 22:06 ` Angelo Compagnucci
-- strict thread matches above, loose matches on Subject: below --
2022-03-26 22:07 Angelo Compagnucci
2022-07-26 21:49 ` Romain Naour
2022-07-28 21:11 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729104754.2beb327c@windsurf \
--to=buildroot@buildroot.org \
--cc=angelo@amarulasolutions.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.