From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
ZiyangZhang <ZiyangZhang@linux.alibaba.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 2/5] ublk_drv: fix ublk device leak in case that add_disk fails
Date: Fri, 29 Jul 2022 16:20:11 +0200 [thread overview]
Message-ID: <20220729142011.GB32321@lst.de> (raw)
In-Reply-To: <20220729072954.1070514-3-ming.lei@redhat.com>
On Fri, Jul 29, 2022 at 03:29:51PM +0800, Ming Lei wrote:
> get_device(&ub->cdev_dev);
> ret = add_disk(disk);
> if (ret) {
> + /*
> + * has to drop the reference since ->free_disk won't be
> + * called in case of add_disk failure
> + */
Nit: Multi-line comments typically start with a capitalized word and
end with a dot to form a proper sentence.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-07-29 14:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 7:29 [PATCH V3 0/5] ublk_drv: add generic mechanism to get/set parameters Ming Lei
2022-07-29 7:29 ` [PATCH V3 1/5] ublk_drv: cancel device even though disk isn't up Ming Lei
2022-07-29 14:19 ` Christoph Hellwig
2022-07-29 7:29 ` [PATCH V3 2/5] ublk_drv: fix ublk device leak in case that add_disk fails Ming Lei
2022-07-29 14:20 ` Christoph Hellwig [this message]
2022-07-29 7:29 ` [PATCH V3 3/5] ublk_drv: add SET_PARAM/GET_PARAM control command Ming Lei
2022-07-29 14:22 ` Christoph Hellwig
2022-07-29 14:59 ` Ming Lei
2022-07-29 7:29 ` [PATCH V3 4/5] ublk_drv: add two parameter types Ming Lei
2022-07-29 14:23 ` Christoph Hellwig
2022-07-29 7:29 ` [PATCH V3 5/5] ublk_drv: cleanup ublksrv_ctrl_dev_info Ming Lei
2022-07-29 14:24 ` Christoph Hellwig
2022-07-29 15:02 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729142011.GB32321@lst.de \
--to=hch@lst.de \
--cc=ZiyangZhang@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.