All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guillaume Nault <gnault@redhat.com>
To: "Drewek, Wojciech" <wojciech.drewek@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"dsahern@gmail.com" <dsahern@gmail.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [PATCH iproute-next v4 1/3] lib: refactor ll_proto functions
Date: Fri, 29 Jul 2022 18:04:55 +0200	[thread overview]
Message-ID: <20220729160455.GE10877@pc-4.home> (raw)
In-Reply-To: <MW4PR11MB5776E25C99B1DC3505BB4A54FD999@MW4PR11MB5776.namprd11.prod.outlook.com>

On Fri, Jul 29, 2022 at 02:32:36PM +0000, Drewek, Wojciech wrote:
> 
> 
> > -----Original Message-----
> > From: Guillaume Nault <gnault@redhat.com>
> > Sent: piątek, 29 lipca 2022 15:22
> > To: Drewek, Wojciech <wojciech.drewek@intel.com>
> > Cc: netdev@vger.kernel.org; dsahern@gmail.com; stephen@networkplumber.org
> > Subject: Re: [PATCH iproute-next v4 1/3] lib: refactor ll_proto functions
> > 
> > On Fri, Jul 29, 2022 at 10:50:33AM +0200, Wojciech Drewek wrote:
> > > Move core logic of ll_proto_n2a and ll_proto_a2n
> > > to utils.c and make it more generic by allowing to
> > > pass table of protocols as argument (proto_tb).
> > > Introduce struct proto with protocol ID and name to
> > > allow this. This wil allow to use those functions by
> > > other use cases.
> > 
> > Acked-by: Guillaume Nault <gnault@redhat.com>
> 
> Sorry, I forgot to add your Acked-by, if next version will be needed I'll add it.

No worry :)


  parent reply	other threads:[~2022-07-29 16:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29  8:50 [PATCH iproute-next v4 0/3] PPPoE support in tc-flower Wojciech Drewek
2022-07-29  8:50 ` [PATCH iproute-next v4 1/3] lib: refactor ll_proto functions Wojciech Drewek
2022-07-29 13:22   ` Guillaume Nault
2022-07-29 14:32     ` Drewek, Wojciech
2022-07-29 14:56       ` David Ahern
2022-07-29 16:04       ` Guillaume Nault [this message]
2022-07-29  8:50 ` [PATCH iproute-next v4 2/3] lib: Introduce ppp protocols Wojciech Drewek
2022-07-29 13:22   ` Guillaume Nault
2022-07-29 14:58   ` David Ahern
2022-07-29 16:03     ` Guillaume Nault
2022-07-29 17:21       ` David Ahern
2022-07-29  8:50 ` [PATCH iproute-next v4 3/3] f_flower: Introduce PPPoE support Wojciech Drewek
2022-07-29 13:22   ` Guillaume Nault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220729160455.GE10877@pc-4.home \
    --to=gnault@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=wojciech.drewek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.