From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Cezar Bulinaru <cbulinaru@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null
Date: Fri, 29 Jul 2022 19:03:07 -0700 [thread overview]
Message-ID: <20220729190307.667b4be0@kernel.org> (raw)
In-Reply-To: <CA+FuTSewa5gCcDJzfQc4j6oQVU6d1kpPqL+D9ZQ9BQUi6Zp9Nw@mail.gmail.com>
On Fri, 29 Jul 2022 08:52:04 +0200 Willem de Bruijn wrote:
> > drivers/net/tap.c | 21 +-
> > tools/testing/selftests/net/Makefile | 2 +-
> > tools/testing/selftests/net/tap.c | 395 +++++++++++++++++++++++++++
>
> Is there prior art in mixing fixes and tests? Should the test go to
> net or always to net-next?
Not sure if there is any official guidance, but I usually put both
together. Separate patches in the same series, targeting one tree.
next prev parent reply other threads:[~2022-07-30 2:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220728185640.085c83b6@kernel.org>
2022-07-29 5:17 ` Cezar Bulinaru
2022-07-29 5:17 ` [PATCH v2] net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null Cezar Bulinaru
2022-07-29 6:52 ` Willem de Bruijn
2022-07-30 2:03 ` Jakub Kicinski [this message]
2022-08-01 4:57 ` [PATCH v3 1/2] Fixes: 924a9bc362a5 ("net: check if protocol extracted by virtio_net_hdr_set_proto is correct") Cezar Bulinaru
2022-08-01 4:57 ` [PATCH v3 2/2] selftests: add few test cases for tap driver Cezar Bulinaru
2022-08-01 8:22 ` Willem de Bruijn
2022-08-03 4:29 ` [PATCH v4 " Cezar Bulinaru
2022-08-01 8:13 ` [PATCH v3 1/2] Fixes: 924a9bc362a5 ("net: check if protocol extracted by virtio_net_hdr_set_proto is correct") Willem de Bruijn
2022-08-03 4:28 ` [PATCH v4 1/2] net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null Cezar Bulinaru
2022-08-03 4:42 ` Jakub Kicinski
2022-08-03 6:29 ` c b
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729190307.667b4be0@kernel.org \
--to=kuba@kernel.org \
--cc=cbulinaru@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.