From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Romain Naour <romain.naour@gmail.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] toolchain/Config.in: update gcc bug 99410
Date: Fri, 29 Jul 2022 21:55:52 +0200 [thread overview]
Message-ID: <20220729215552.325fbe22@windsurf> (raw)
In-Reply-To: <20220729162430.1028453-2-giulio.benetti@benettiengineering.com>
On Fri, 29 Jul 2022 18:24:30 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> config BR2_TOOLCHAIN_HAS_GCC_BUG_99410
> bool
> - default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
> - default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
> + default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
> + BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
> + BR2_TOOLCHAIN_GCC_AT_LEAST_12
This looks like a very convoluted way, that can be replaced with:
config BR2_TOOLCHAIN_HAS_GCC_BUG_99410
bool
default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9
This says:
- The bug is present if you don't have at least gcc 8.x (so versions
older than gcc 8.x are affected)
- The bug is present if you have at least gcc 9.x (so all versions
more recent than 9.x included are affected)
So I replaced it with that. Let me know if you see a problem with this
change.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-29 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 16:24 [Buildroot] [PATCH 1/2] toolchain/Config.in: fix BR2_TOOLCHAIN_HAS_GCC_BUG_99140 number Giulio Benetti
2022-07-29 16:24 ` [Buildroot] [PATCH 2/2] toolchain/Config.in: update gcc bug 99410 Giulio Benetti
2022-07-29 16:43 ` Giulio Benetti
2022-07-29 19:55 ` Thomas Petazzoni via buildroot [this message]
2022-07-29 20:22 ` Giulio Benetti
2022-07-29 20:27 ` Thomas Petazzoni via buildroot
2022-09-13 14:15 ` Peter Korsgaard
2022-07-29 19:40 ` [Buildroot] [PATCH 1/2] toolchain/Config.in: fix BR2_TOOLCHAIN_HAS_GCC_BUG_99140 number Arnout Vandecappelle
2022-07-29 19:54 ` Thomas Petazzoni via buildroot
2022-09-13 14:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729215552.325fbe22@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.