From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 322F9C00144 for ; Sat, 30 Jul 2022 01:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231311AbiG3BBA (ORCPT ); Fri, 29 Jul 2022 21:01:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbiG3BA7 (ORCPT ); Fri, 29 Jul 2022 21:00:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F3C6814A8; Fri, 29 Jul 2022 18:00:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CAB11B829FD; Sat, 30 Jul 2022 01:00:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CF6BC433D6; Sat, 30 Jul 2022 01:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659142856; bh=+InU6DDPWuuUM25a8VhayS37OQxLsx3tuBE0/qqb3aA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=hey4AyJjXGgwdIeZX+TIzwM0uRat9O61ztXTZTuz1MtO1arOYvAm52jlnKF6+uT74 WLRjvmkUvS6tWu6u220VrmU8g3ysvF31VTiZUEAjKbtwFb1jTaZrGfl5GpngYisqHb skb3PpWxzDzXdMkuRlwh1uqAyScOodeBVnpJsZ6Ty9zvbX7IGJrpa8WuZPOHscPUd2 2U7K/OVSQAzHCAhwEDCa3lZ8Bpk57K0t599odFuwhOproYWXSQUmgdOG7aXizyE+vL 4EkAFs8YXu9IzhEU0y37dLo50V1mp/FgsnC8AyHOPeWGHLPcj+ecAOmJ0tkMogHgVT bwINbV5mMAZdg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220630141308.121526-1-yangyingliang@huawei.com> References: <20220630141308.121526-1-yangyingliang@huawei.com> Subject: Re: [PATCH -next] clk: imx: remove unnecessary NULL check of clk From: Stephen Boyd Cc: abelvesa@kernel.org, shawnguo@kernel.org To: Yang Yingliang , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 29 Jul 2022 18:00:54 -0700 User-Agent: alot/0.10 Message-Id: <20220730010056.7CF6BC433D6@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Yang Yingliang (2022-06-30 07:13:08) > It has NULL check in clk_prepare_enable(), so it no need > to check the clk before calling it. >=20 > Signed-off-by: Yang Yingliang > --- > drivers/clk/imx/clk.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c > index 5582f18dd632..1c5d5b957c96 100644 > --- a/drivers/clk/imx/clk.c > +++ b/drivers/clk/imx/clk.c > @@ -189,9 +189,7 @@ void imx_register_uart_clocks(unsigned int clk_count) > if (IS_ERR(imx_uart_clocks[imx_enabled_uart_clock= s])) > return; > =20 > - /* Only enable the clock if it's not NULL */ > - if (imx_uart_clocks[imx_enabled_uart_clocks]) > - clk_prepare_enable(imx_uart_clocks[imx_en= abled_uart_clocks++]); > + clk_prepare_enable(imx_uart_clocks[imx_enabled_ua= rt_clocks++]); Nak The ++ operator has side-effects, which wasn't the case before this patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4728C00144 for ; Sat, 30 Jul 2022 01:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rBj4irtXDZNpXcGBpDyJ9KZhcOaL2KrfaRp5d85YrjU=; b=OGskK8TpDREAAW cO7GFez7W5Pb5se5d5pO1Tyd5Lwa2vp/+jqKSAv6xHHHnBlWc4zJA4A1vz2/y0wIOlIjeq2jI6ITM k3MgtHiNEnyPgAsD0Dm+tJbroevc46/6OWxxEDJPQgCMwU1aQh+sTYLMmYDbxtxYz1UGMJRHlGAd/ DBSVY/l8g96n+LLCTpBRRijdHr73NYFoGTCSn4QdNDVsBnCsFciB6ZQSsFUAufN2n3ysnQjwS/EfE t6rTnQ75m27IGL8tedzY1lNE78z+WFPHH3za8G7cHPRQfo94PbBFkql1WIkSy5lixy7d/SNi9KxJW /bhYV9RnzaThhHFpqTSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHaqi-00Euco-M7; Sat, 30 Jul 2022 01:01:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHaqf-00Euc5-Px for linux-arm-kernel@lists.infradead.org; Sat, 30 Jul 2022 01:00:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 29504619EE; Sat, 30 Jul 2022 01:00:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CF6BC433D6; Sat, 30 Jul 2022 01:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659142856; bh=+InU6DDPWuuUM25a8VhayS37OQxLsx3tuBE0/qqb3aA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=hey4AyJjXGgwdIeZX+TIzwM0uRat9O61ztXTZTuz1MtO1arOYvAm52jlnKF6+uT74 WLRjvmkUvS6tWu6u220VrmU8g3ysvF31VTiZUEAjKbtwFb1jTaZrGfl5GpngYisqHb skb3PpWxzDzXdMkuRlwh1uqAyScOodeBVnpJsZ6Ty9zvbX7IGJrpa8WuZPOHscPUd2 2U7K/OVSQAzHCAhwEDCa3lZ8Bpk57K0t599odFuwhOproYWXSQUmgdOG7aXizyE+vL 4EkAFs8YXu9IzhEU0y37dLo50V1mp/FgsnC8AyHOPeWGHLPcj+ecAOmJ0tkMogHgVT bwINbV5mMAZdg== MIME-Version: 1.0 In-Reply-To: <20220630141308.121526-1-yangyingliang@huawei.com> References: <20220630141308.121526-1-yangyingliang@huawei.com> Subject: Re: [PATCH -next] clk: imx: remove unnecessary NULL check of clk From: Stephen Boyd Cc: abelvesa@kernel.org, shawnguo@kernel.org To: Yang Yingliang , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 29 Jul 2022 18:00:54 -0700 User-Agent: alot/0.10 Message-Id: <20220730010056.7CF6BC433D6@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220729_180057_901428_C6E632C2 X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Yang Yingliang (2022-06-30 07:13:08) > It has NULL check in clk_prepare_enable(), so it no need > to check the clk before calling it. > > Signed-off-by: Yang Yingliang > --- > drivers/clk/imx/clk.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c > index 5582f18dd632..1c5d5b957c96 100644 > --- a/drivers/clk/imx/clk.c > +++ b/drivers/clk/imx/clk.c > @@ -189,9 +189,7 @@ void imx_register_uart_clocks(unsigned int clk_count) > if (IS_ERR(imx_uart_clocks[imx_enabled_uart_clocks])) > return; > > - /* Only enable the clock if it's not NULL */ > - if (imx_uart_clocks[imx_enabled_uart_clocks]) > - clk_prepare_enable(imx_uart_clocks[imx_enabled_uart_clocks++]); > + clk_prepare_enable(imx_uart_clocks[imx_enabled_uart_clocks++]); Nak The ++ operator has side-effects, which wasn't the case before this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel