diff for duplicates of <202207311503.QBFSGqiL-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index c513f6c..5ab22a2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,6 @@ -CC: kbuild-all(a)lists.01.org -BCC: lkp(a)intel.com -CC: Ammar Faizi <ammarfaizi2@gnuweeb.org> -CC: "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org> -CC: linux-kernel(a)vger.kernel.org -TO: Jiri Pirko <jiri@nvidia.com> -CC: Jakub Kicinski <kuba@kernel.org> - tree: https://github.com/ammarfaizi2/linux-block netdev/net-next/main head: 63757225a93353bc2ce4499af5501eabdbbf23f9 commit: 2dec18ad826f52658f7781ee995d236cc449b678 [20/29] net: devlink: remove region snapshots list dependency on devlink->lock -:::::: branch date: 27 hours ago -:::::: commit date: 2 days ago config: arc-randconfig-m041-20220731 (https://download.01.org/0day-ci/archive/20220731/202207311503.QBFSGqiL-lkp(a)intel.com/config) compiler: arceb-elf-gcc (GCC) 12.1.0 @@ -27,7 +17,6 @@ arch/arc/include/asm/thread_info.h:62 current_thread_info() error: uninitialized vim +6392 net/core/devlink.c -866319bb943761 Alex Vesker 2018-07-12 6270 b9a17abfde842b Jacob Keller 2020-03-26 6271 static int b9a17abfde842b Jacob Keller 2020-03-26 6272 devlink_nl_cmd_region_new(struct sk_buff *skb, struct genl_info *info) b9a17abfde842b Jacob Keller 2020-03-26 6273 { @@ -73,6 +62,9 @@ b9a17abfde842b Jacob Keller 2020-03-26 6312 return -EOPNOTSUPP; b9a17abfde842b Jacob Keller 2020-03-26 6313 } b9a17abfde842b Jacob Keller 2020-03-26 6314 2dec18ad826f52 Jiri Pirko 2022-07-28 6315 mutex_lock(®ion->snapshot_lock); + +New locking + 2dec18ad826f52 Jiri Pirko 2022-07-28 6316 b9a17abfde842b Jacob Keller 2020-03-26 6317 if (region->cur_snapshots == region->max_snapshots) { b9a17abfde842b Jacob Keller 2020-03-26 6318 NL_SET_ERR_MSG_MOD(info->extack, "The region has reached the maximum number of stored snapshots"); @@ -121,6 +113,9 @@ b9a17abfde842b Jacob Keller 2020-03-26 6356 043b3e22768d5d Jakub Kicinski 2020-05-01 6361 snapshot_id); 043b3e22768d5d Jakub Kicinski 2020-05-01 6362 if (WARN_ON(!snapshot)) 043b3e22768d5d Jakub Kicinski 2020-05-01 6363 return -EINVAL; + +unlock before returning? + 043b3e22768d5d Jakub Kicinski 2020-05-01 6364 043b3e22768d5d Jakub Kicinski 2020-05-01 6365 msg = devlink_nl_region_notify_build(region, snapshot, 043b3e22768d5d Jakub Kicinski 2020-05-01 6366 DEVLINK_CMD_REGION_NEW, @@ -151,13 +146,6 @@ b9a17abfde842b Jacob Keller 2020-03-26 6386 return err; 2dec18ad826f52 Jiri Pirko 2022-07-28 6391 mutex_unlock(®ion->snapshot_lock); 043b3e22768d5d Jakub Kicinski 2020-05-01 @6392 return err; b9a17abfde842b Jacob Keller 2020-03-26 6393 } -b9a17abfde842b Jacob Keller 2020-03-26 6394 - -:::::: The code at line 6392 was first introduced by commit -:::::: 043b3e22768d5d909cb1474fc21ae2fbaf026c0c devlink: let kernel allocate region snapshot id - -:::::: TO: Jakub Kicinski <kuba@kernel.org> -:::::: CC: David S. Miller <davem@davemloft.net> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index df3b895..3d492b7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,22 +1,12 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[ammarfaizi2-block:netdev/net-next/main 20/29] net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent returns '®ion->snapshot_lock'.\0" - "Date\0Sun, 31 Jul 2022 16:01:33 +0800\0" - "To\0kbuild@lists.01.org\0" + "Date\0Mon, 01 Aug 2022 14:29:56 +0300\0" + "To\0kbuild-all@lists.01.org\0" "\01:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "BCC: lkp(a)intel.com\n" - "CC: Ammar Faizi <ammarfaizi2@gnuweeb.org>\n" - "CC: \"GNU/Weeb Mailing List\" <gwml@vger.gnuweeb.org>\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: Jiri Pirko <jiri@nvidia.com>\n" - "CC: Jakub Kicinski <kuba@kernel.org>\n" - "\n" "tree: https://github.com/ammarfaizi2/linux-block netdev/net-next/main\n" "head: 63757225a93353bc2ce4499af5501eabdbbf23f9\n" "commit: 2dec18ad826f52658f7781ee995d236cc449b678 [20/29] net: devlink: remove region snapshots list dependency on devlink->lock\n" - ":::::: branch date: 27 hours ago\n" - ":::::: commit date: 2 days ago\n" "config: arc-randconfig-m041-20220731 (https://download.01.org/0day-ci/archive/20220731/202207311503.QBFSGqiL-lkp(a)intel.com/config)\n" "compiler: arceb-elf-gcc (GCC) 12.1.0\n" "\n" @@ -33,7 +23,6 @@ "\n" "vim +6392 net/core/devlink.c\n" "\n" - "866319bb943761 Alex Vesker 2018-07-12 6270 \n" "b9a17abfde842b Jacob Keller 2020-03-26 6271 static int\n" "b9a17abfde842b Jacob Keller 2020-03-26 6272 devlink_nl_cmd_region_new(struct sk_buff *skb, struct genl_info *info)\n" "b9a17abfde842b Jacob Keller 2020-03-26 6273 {\n" @@ -79,6 +68,9 @@ "b9a17abfde842b Jacob Keller 2020-03-26 6313 \t}\n" "b9a17abfde842b Jacob Keller 2020-03-26 6314 \n" "2dec18ad826f52 Jiri Pirko 2022-07-28 6315 \tmutex_lock(®ion->snapshot_lock);\n" + "\n" + "New locking\n" + "\n" "2dec18ad826f52 Jiri Pirko 2022-07-28 6316 \n" "b9a17abfde842b Jacob Keller 2020-03-26 6317 \tif (region->cur_snapshots == region->max_snapshots) {\n" "b9a17abfde842b Jacob Keller 2020-03-26 6318 \t\tNL_SET_ERR_MSG_MOD(info->extack, \"The region has reached the maximum number of stored snapshots\");\n" @@ -127,6 +119,9 @@ "043b3e22768d5d Jakub Kicinski 2020-05-01 6361 \t\t\t\t\t\t\t snapshot_id);\n" "043b3e22768d5d Jakub Kicinski 2020-05-01 6362 \t\tif (WARN_ON(!snapshot))\n" "043b3e22768d5d Jakub Kicinski 2020-05-01 6363 \t\t\treturn -EINVAL;\n" + "\n" + "unlock before returning?\n" + "\n" "043b3e22768d5d Jakub Kicinski 2020-05-01 6364 \n" "043b3e22768d5d Jakub Kicinski 2020-05-01 6365 \t\tmsg = devlink_nl_region_notify_build(region, snapshot,\n" "043b3e22768d5d Jakub Kicinski 2020-05-01 6366 \t\t\t\t\t\t DEVLINK_CMD_REGION_NEW,\n" @@ -157,16 +152,9 @@ "2dec18ad826f52 Jiri Pirko 2022-07-28 6391 \tmutex_unlock(®ion->snapshot_lock);\n" "043b3e22768d5d Jakub Kicinski 2020-05-01 @6392 \treturn err;\n" "b9a17abfde842b Jacob Keller 2020-03-26 6393 }\n" - "b9a17abfde842b Jacob Keller 2020-03-26 6394 \n" - "\n" - ":::::: The code at line 6392 was first introduced by commit\n" - ":::::: 043b3e22768d5d909cb1474fc21ae2fbaf026c0c devlink: let kernel allocate region snapshot id\n" - "\n" - ":::::: TO: Jakub Kicinski <kuba@kernel.org>\n" - ":::::: CC: David S. Miller <davem@davemloft.net>\n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://01.org/lkp -50f9412ace1b027fc100232a7165bd9f28b836c12ec86ec7983d001f8309e4e4 +ed9aca338c998e6f3de863e835f5a6be36ead564d9b8c22bb9f10ba2da901080
diff --git a/a/1.txt b/N2/1.txt index c513f6c..c6932c7 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,17 +1,7 @@ -CC: kbuild-all(a)lists.01.org -BCC: lkp(a)intel.com -CC: Ammar Faizi <ammarfaizi2@gnuweeb.org> -CC: "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org> -CC: linux-kernel(a)vger.kernel.org -TO: Jiri Pirko <jiri@nvidia.com> -CC: Jakub Kicinski <kuba@kernel.org> - tree: https://github.com/ammarfaizi2/linux-block netdev/net-next/main head: 63757225a93353bc2ce4499af5501eabdbbf23f9 commit: 2dec18ad826f52658f7781ee995d236cc449b678 [20/29] net: devlink: remove region snapshots list dependency on devlink->lock -:::::: branch date: 27 hours ago -:::::: commit date: 2 days ago -config: arc-randconfig-m041-20220731 (https://download.01.org/0day-ci/archive/20220731/202207311503.QBFSGqiL-lkp(a)intel.com/config) +config: arc-randconfig-m041-20220731 (https://download.01.org/0day-ci/archive/20220731/202207311503.QBFSGqiL-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable @@ -27,7 +17,6 @@ arch/arc/include/asm/thread_info.h:62 current_thread_info() error: uninitialized vim +6392 net/core/devlink.c -866319bb943761 Alex Vesker 2018-07-12 6270 b9a17abfde842b Jacob Keller 2020-03-26 6271 static int b9a17abfde842b Jacob Keller 2020-03-26 6272 devlink_nl_cmd_region_new(struct sk_buff *skb, struct genl_info *info) b9a17abfde842b Jacob Keller 2020-03-26 6273 { @@ -73,6 +62,9 @@ b9a17abfde842b Jacob Keller 2020-03-26 6312 return -EOPNOTSUPP; b9a17abfde842b Jacob Keller 2020-03-26 6313 } b9a17abfde842b Jacob Keller 2020-03-26 6314 2dec18ad826f52 Jiri Pirko 2022-07-28 6315 mutex_lock(®ion->snapshot_lock); + +New locking + 2dec18ad826f52 Jiri Pirko 2022-07-28 6316 b9a17abfde842b Jacob Keller 2020-03-26 6317 if (region->cur_snapshots == region->max_snapshots) { b9a17abfde842b Jacob Keller 2020-03-26 6318 NL_SET_ERR_MSG_MOD(info->extack, "The region has reached the maximum number of stored snapshots"); @@ -121,6 +113,9 @@ b9a17abfde842b Jacob Keller 2020-03-26 6356 043b3e22768d5d Jakub Kicinski 2020-05-01 6361 snapshot_id); 043b3e22768d5d Jakub Kicinski 2020-05-01 6362 if (WARN_ON(!snapshot)) 043b3e22768d5d Jakub Kicinski 2020-05-01 6363 return -EINVAL; + +unlock before returning? + 043b3e22768d5d Jakub Kicinski 2020-05-01 6364 043b3e22768d5d Jakub Kicinski 2020-05-01 6365 msg = devlink_nl_region_notify_build(region, snapshot, 043b3e22768d5d Jakub Kicinski 2020-05-01 6366 DEVLINK_CMD_REGION_NEW, @@ -151,13 +146,6 @@ b9a17abfde842b Jacob Keller 2020-03-26 6386 return err; 2dec18ad826f52 Jiri Pirko 2022-07-28 6391 mutex_unlock(®ion->snapshot_lock); 043b3e22768d5d Jakub Kicinski 2020-05-01 @6392 return err; b9a17abfde842b Jacob Keller 2020-03-26 6393 } -b9a17abfde842b Jacob Keller 2020-03-26 6394 - -:::::: The code at line 6392 was first introduced by commit -:::::: 043b3e22768d5d909cb1474fc21ae2fbaf026c0c devlink: let kernel allocate region snapshot id - -:::::: TO: Jakub Kicinski <kuba@kernel.org> -:::::: CC: David S. Miller <davem@davemloft.net> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N2/content_digest index df3b895..6649307 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,23 +1,19 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[ammarfaizi2-block:netdev/net-next/main 20/29] net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent returns '®ion->snapshot_lock'.\0" - "Date\0Sun, 31 Jul 2022 16:01:33 +0800\0" - "To\0kbuild@lists.01.org\0" - "\01:1\0" + "Date\0Mon, 1 Aug 2022 14:29:56 +0300\0" + "To\0kbuild@lists.01.org" + " Jiri Pirko <jiri@nvidia.com>\0" + "Cc\0lkp@intel.com" + kbuild-all@lists.01.org + Ammar Faizi <ammarfaizi2@gnuweeb.org> + GNU/Weeb Mailing List <gwml@vger.gnuweeb.org> + " linux-kernel@vger.kernel.org\0" + "\00:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "BCC: lkp(a)intel.com\n" - "CC: Ammar Faizi <ammarfaizi2@gnuweeb.org>\n" - "CC: \"GNU/Weeb Mailing List\" <gwml@vger.gnuweeb.org>\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: Jiri Pirko <jiri@nvidia.com>\n" - "CC: Jakub Kicinski <kuba@kernel.org>\n" - "\n" "tree: https://github.com/ammarfaizi2/linux-block netdev/net-next/main\n" "head: 63757225a93353bc2ce4499af5501eabdbbf23f9\n" "commit: 2dec18ad826f52658f7781ee995d236cc449b678 [20/29] net: devlink: remove region snapshots list dependency on devlink->lock\n" - ":::::: branch date: 27 hours ago\n" - ":::::: commit date: 2 days ago\n" - "config: arc-randconfig-m041-20220731 (https://download.01.org/0day-ci/archive/20220731/202207311503.QBFSGqiL-lkp(a)intel.com/config)\n" + "config: arc-randconfig-m041-20220731 (https://download.01.org/0day-ci/archive/20220731/202207311503.QBFSGqiL-lkp@intel.com/config)\n" "compiler: arceb-elf-gcc (GCC) 12.1.0\n" "\n" "If you fix the issue, kindly add following tag where applicable\n" @@ -33,7 +29,6 @@ "\n" "vim +6392 net/core/devlink.c\n" "\n" - "866319bb943761 Alex Vesker 2018-07-12 6270 \n" "b9a17abfde842b Jacob Keller 2020-03-26 6271 static int\n" "b9a17abfde842b Jacob Keller 2020-03-26 6272 devlink_nl_cmd_region_new(struct sk_buff *skb, struct genl_info *info)\n" "b9a17abfde842b Jacob Keller 2020-03-26 6273 {\n" @@ -79,6 +74,9 @@ "b9a17abfde842b Jacob Keller 2020-03-26 6313 \t}\n" "b9a17abfde842b Jacob Keller 2020-03-26 6314 \n" "2dec18ad826f52 Jiri Pirko 2022-07-28 6315 \tmutex_lock(®ion->snapshot_lock);\n" + "\n" + "New locking\n" + "\n" "2dec18ad826f52 Jiri Pirko 2022-07-28 6316 \n" "b9a17abfde842b Jacob Keller 2020-03-26 6317 \tif (region->cur_snapshots == region->max_snapshots) {\n" "b9a17abfde842b Jacob Keller 2020-03-26 6318 \t\tNL_SET_ERR_MSG_MOD(info->extack, \"The region has reached the maximum number of stored snapshots\");\n" @@ -127,6 +125,9 @@ "043b3e22768d5d Jakub Kicinski 2020-05-01 6361 \t\t\t\t\t\t\t snapshot_id);\n" "043b3e22768d5d Jakub Kicinski 2020-05-01 6362 \t\tif (WARN_ON(!snapshot))\n" "043b3e22768d5d Jakub Kicinski 2020-05-01 6363 \t\t\treturn -EINVAL;\n" + "\n" + "unlock before returning?\n" + "\n" "043b3e22768d5d Jakub Kicinski 2020-05-01 6364 \n" "043b3e22768d5d Jakub Kicinski 2020-05-01 6365 \t\tmsg = devlink_nl_region_notify_build(region, snapshot,\n" "043b3e22768d5d Jakub Kicinski 2020-05-01 6366 \t\t\t\t\t\t DEVLINK_CMD_REGION_NEW,\n" @@ -157,16 +158,9 @@ "2dec18ad826f52 Jiri Pirko 2022-07-28 6391 \tmutex_unlock(®ion->snapshot_lock);\n" "043b3e22768d5d Jakub Kicinski 2020-05-01 @6392 \treturn err;\n" "b9a17abfde842b Jacob Keller 2020-03-26 6393 }\n" - "b9a17abfde842b Jacob Keller 2020-03-26 6394 \n" - "\n" - ":::::: The code at line 6392 was first introduced by commit\n" - ":::::: 043b3e22768d5d909cb1474fc21ae2fbaf026c0c devlink: let kernel allocate region snapshot id\n" - "\n" - ":::::: TO: Jakub Kicinski <kuba@kernel.org>\n" - ":::::: CC: David S. Miller <davem@davemloft.net>\n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://01.org/lkp -50f9412ace1b027fc100232a7165bd9f28b836c12ec86ec7983d001f8309e4e4 +8dfda921c7c34cb96aff6d50431edaad093813fdda67001105913da596edc707
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.