From: Sebin Sebastian <mailmesebin00@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: mailmesebin00@gmail.com, Taras Chornyi <tchornyi@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH -next] net: marvell: prestera: remove reduntant code
Date: Mon, 1 Aug 2022 09:37:31 +0530 [thread overview]
Message-ID: <20220801040731.34741-1-mailmesebin00@gmail.com> (raw)
Fixes the coverity warning 'EVALUATION_ORDER' violation. port is written
twice with the same value.
Fixes: Coverity CID 1519056 (Incorrect expression)
Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com>
---
drivers/net/ethernet/marvell/prestera/prestera_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index c267ca1ccdba..0df904455d76 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -290,7 +290,7 @@ static int prestera_pcs_config(struct phylink_pcs *pcs,
const unsigned long *advertising,
bool permit_pause_to_mac)
{
- struct prestera_port *port = port = prestera_pcs_to_port(pcs);
+ struct prestera_port *port = prestera_pcs_to_port(pcs);
struct prestera_port_mac_config cfg_mac;
int err;
--
2.34.1
next reply other threads:[~2022-08-01 4:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 4:07 Sebin Sebastian [this message]
2022-08-02 3:40 ` [PATCH -next] net: marvell: prestera: remove reduntant code patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801040731.34741-1-mailmesebin00@gmail.com \
--to=mailmesebin00@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tchornyi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.