From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Pasternak <vadimp@nvidia.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH 1/2] Revert "mlxsw: core: Use different get_trend() callbacks for different thermal zones"
Date: Mon, 1 Aug 2022 20:18:33 -0700 [thread overview]
Message-ID: <20220801201833.79dd5171@kernel.org> (raw)
In-Reply-To: <BN9PR12MB5381C2B144840EB0D7390610AF9A9@BN9PR12MB5381.namprd12.prod.outlook.com>
On Mon, 1 Aug 2022 11:13:36 +0000 Vadim Pasternak wrote:
> > This reverts commit 2dc2f760052da4925482ecdcdc5c94d4a599153c.
> >
> > As discussed in the thread:
> >
> > https://lore.kernel.org/all/f3c62ebe-7d59-c537-a010-
> > bff366c8aeba@linaro.org/
> >
> > the feature provided by commits 2dc2f760052da and 6f73862fabd93 is
> > actually already handled by the thermal framework via the cooling device
> > state aggregation, thus all this code is pointless.
> >
> > No conflict happened when reverting the patch.
>
> I am sorry, I didn't run emulation yet to validate this change.
> Will do it in tomorrow and will send ACK if it is OK.
We'll also need a rebase on top of net-next, the patch as is does not
apply to either of the networking trees.
next prev parent reply other threads:[~2022-08-02 3:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 9:56 [PATCH 1/2] Revert "mlxsw: core: Use different get_trend() callbacks for different thermal zones" Daniel Lezcano
2022-08-01 9:56 ` [PATCH 2/2] Revert "mlxsw: core: Add the hottest thermal zone detection" Daniel Lezcano
2022-08-04 12:21 ` Vadim Pasternak
2022-08-05 16:07 ` Daniel Lezcano
2022-08-14 7:42 ` Vadim Pasternak
2022-08-01 11:13 ` [PATCH 1/2] Revert "mlxsw: core: Use different get_trend() callbacks for different thermal zones" Vadim Pasternak
2022-08-02 3:18 ` Jakub Kicinski [this message]
2022-08-04 12:20 ` Vadim Pasternak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801201833.79dd5171@kernel.org \
--to=kuba@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=rafael@kernel.org \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.